* [PATCH 1/2] remoteproc: imx: Broaden the Kconfig selection logic
@ 2019-06-03 23:46 Fabio Estevam
2019-06-03 23:46 ` [PATCH 2/2] remoteproc: imx: Fix typo in "failed" Fabio Estevam
` (2 more replies)
0 siblings, 3 replies; 5+ messages in thread
From: Fabio Estevam @ 2019-06-03 23:46 UTC (permalink / raw)
To: bjorn.andersson; +Cc: ohad, o.rempel, linux-remoteproc, Fabio Estevam
Besides i.MX6SX and i.MX7D, there are other i.MX devices that contain
Cortex M4 and could make use of the imx remoteproc driver, such as
i.MX7ULP, i.MX8M, etc.
Instead of adding new SoC entries in the Kconfig logic, make it
broader by using the more generic ARCH_MXC, which encompasses
all the 32-bit and 64-bit i.MX devices.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/remoteproc/Kconfig | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
index 18be41b8aa7e..0df301be6d9a 100644
--- a/drivers/remoteproc/Kconfig
+++ b/drivers/remoteproc/Kconfig
@@ -16,7 +16,7 @@ if REMOTEPROC
config IMX_REMOTEPROC
tristate "IMX6/7 remoteproc support"
- depends on SOC_IMX6SX || SOC_IMX7D
+ depends on ARCH_MXC
help
Say y here to support iMX's remote processors (Cortex M4
on iMX7D) via the remote processor framework.
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* [PATCH 2/2] remoteproc: imx: Fix typo in "failed"
2019-06-03 23:46 [PATCH 1/2] remoteproc: imx: Broaden the Kconfig selection logic Fabio Estevam
@ 2019-06-03 23:46 ` Fabio Estevam
2019-06-04 4:19 ` Oleksij Rempel
2019-06-04 4:18 ` [PATCH 1/2] remoteproc: imx: Broaden the Kconfig selection logic Oleksij Rempel
2019-06-04 5:01 ` Bjorn Andersson
2 siblings, 1 reply; 5+ messages in thread
From: Fabio Estevam @ 2019-06-03 23:46 UTC (permalink / raw)
To: bjorn.andersson; +Cc: ohad, o.rempel, linux-remoteproc, Fabio Estevam
There are several places where "failed" is spelled incorrectly.
Fix them all.
Signed-off-by: Fabio Estevam <festevam@gmail.com>
---
drivers/remoteproc/imx_rproc.c | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
index 54c07fd3f204..7e0804c72677 100644
--- a/drivers/remoteproc/imx_rproc.c
+++ b/drivers/remoteproc/imx_rproc.c
@@ -168,7 +168,7 @@ static int imx_rproc_start(struct rproc *rproc)
ret = regmap_update_bits(priv->regmap, dcfg->src_reg,
dcfg->src_mask, dcfg->src_start);
if (ret)
- dev_err(dev, "Filed to enable M4!\n");
+ dev_err(dev, "Failed to enable M4!\n");
return ret;
}
@@ -183,7 +183,7 @@ static int imx_rproc_stop(struct rproc *rproc)
ret = regmap_update_bits(priv->regmap, dcfg->src_reg,
dcfg->src_mask, dcfg->src_stop);
if (ret)
- dev_err(dev, "Filed to stop M4!\n");
+ dev_err(dev, "Failed to stop M4!\n");
return ret;
}
@@ -206,7 +206,7 @@ static int imx_rproc_da_to_sys(struct imx_rproc *priv, u64 da,
}
}
- dev_warn(priv->dev, "Translation filed: da = 0x%llx len = 0x%x\n",
+ dev_warn(priv->dev, "Translation failed: da = 0x%llx len = 0x%x\n",
da, len);
return -ENOENT;
}
@@ -352,7 +352,7 @@ static int imx_rproc_probe(struct platform_device *pdev)
ret = imx_rproc_addr_init(priv, pdev);
if (ret) {
- dev_err(dev, "filed on imx_rproc_addr_init\n");
+ dev_err(dev, "failed on imx_rproc_addr_init\n");
goto err_put_rproc;
}
--
2.17.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] remoteproc: imx: Broaden the Kconfig selection logic
2019-06-03 23:46 [PATCH 1/2] remoteproc: imx: Broaden the Kconfig selection logic Fabio Estevam
2019-06-03 23:46 ` [PATCH 2/2] remoteproc: imx: Fix typo in "failed" Fabio Estevam
@ 2019-06-04 4:18 ` Oleksij Rempel
2019-06-04 5:01 ` Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Oleksij Rempel @ 2019-06-04 4:18 UTC (permalink / raw)
To: Fabio Estevam; +Cc: bjorn.andersson, ohad, linux-remoteproc
On Mon, Jun 03, 2019 at 08:46:27PM -0300, Fabio Estevam wrote:
> Besides i.MX6SX and i.MX7D, there are other i.MX devices that contain
> Cortex M4 and could make use of the imx remoteproc driver, such as
> i.MX7ULP, i.MX8M, etc.
>
> Instead of adding new SoC entries in the Kconfig logic, make it
> broader by using the more generic ARCH_MXC, which encompasses
> all the 32-bit and 64-bit i.MX devices.
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> drivers/remoteproc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index 18be41b8aa7e..0df301be6d9a 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -16,7 +16,7 @@ if REMOTEPROC
>
> config IMX_REMOTEPROC
> tristate "IMX6/7 remoteproc support"
> - depends on SOC_IMX6SX || SOC_IMX7D
> + depends on ARCH_MXC
> help
> Say y here to support iMX's remote processors (Cortex M4
> on iMX7D) via the remote processor framework.
> --
> 2.17.1
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 2/2] remoteproc: imx: Fix typo in "failed"
2019-06-03 23:46 ` [PATCH 2/2] remoteproc: imx: Fix typo in "failed" Fabio Estevam
@ 2019-06-04 4:19 ` Oleksij Rempel
0 siblings, 0 replies; 5+ messages in thread
From: Oleksij Rempel @ 2019-06-04 4:19 UTC (permalink / raw)
To: Fabio Estevam; +Cc: bjorn.andersson, ohad, linux-remoteproc
On Mon, Jun 03, 2019 at 08:46:28PM -0300, Fabio Estevam wrote:
> There are several places where "failed" is spelled incorrectly.
>
> Fix them all.
Thank you!
Reviewed-by: Oleksij Rempel <o.rempel@pengutronix.de>
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> drivers/remoteproc/imx_rproc.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c b/drivers/remoteproc/imx_rproc.c
> index 54c07fd3f204..7e0804c72677 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -168,7 +168,7 @@ static int imx_rproc_start(struct rproc *rproc)
> ret = regmap_update_bits(priv->regmap, dcfg->src_reg,
> dcfg->src_mask, dcfg->src_start);
> if (ret)
> - dev_err(dev, "Filed to enable M4!\n");
> + dev_err(dev, "Failed to enable M4!\n");
>
> return ret;
> }
> @@ -183,7 +183,7 @@ static int imx_rproc_stop(struct rproc *rproc)
> ret = regmap_update_bits(priv->regmap, dcfg->src_reg,
> dcfg->src_mask, dcfg->src_stop);
> if (ret)
> - dev_err(dev, "Filed to stop M4!\n");
> + dev_err(dev, "Failed to stop M4!\n");
>
> return ret;
> }
> @@ -206,7 +206,7 @@ static int imx_rproc_da_to_sys(struct imx_rproc *priv, u64 da,
> }
> }
>
> - dev_warn(priv->dev, "Translation filed: da = 0x%llx len = 0x%x\n",
> + dev_warn(priv->dev, "Translation failed: da = 0x%llx len = 0x%x\n",
> da, len);
> return -ENOENT;
> }
> @@ -352,7 +352,7 @@ static int imx_rproc_probe(struct platform_device *pdev)
>
> ret = imx_rproc_addr_init(priv, pdev);
> if (ret) {
> - dev_err(dev, "filed on imx_rproc_addr_init\n");
> + dev_err(dev, "failed on imx_rproc_addr_init\n");
> goto err_put_rproc;
> }
>
> --
> 2.17.1
>
>
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0 |
Amtsgericht Hildesheim, HRA 2686 | Fax: +49-5121-206917-5555 |
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH 1/2] remoteproc: imx: Broaden the Kconfig selection logic
2019-06-03 23:46 [PATCH 1/2] remoteproc: imx: Broaden the Kconfig selection logic Fabio Estevam
2019-06-03 23:46 ` [PATCH 2/2] remoteproc: imx: Fix typo in "failed" Fabio Estevam
2019-06-04 4:18 ` [PATCH 1/2] remoteproc: imx: Broaden the Kconfig selection logic Oleksij Rempel
@ 2019-06-04 5:01 ` Bjorn Andersson
2 siblings, 0 replies; 5+ messages in thread
From: Bjorn Andersson @ 2019-06-04 5:01 UTC (permalink / raw)
To: Fabio Estevam; +Cc: ohad, o.rempel, linux-remoteproc
On Mon 03 Jun 16:46 PDT 2019, Fabio Estevam wrote:
> Besides i.MX6SX and i.MX7D, there are other i.MX devices that contain
> Cortex M4 and could make use of the imx remoteproc driver, such as
> i.MX7ULP, i.MX8M, etc.
>
> Instead of adding new SoC entries in the Kconfig logic, make it
> broader by using the more generic ARCH_MXC, which encompasses
> all the 32-bit and 64-bit i.MX devices.
>
Patches applied with Oleksij's review.
Thanks,
Bjorn
> Signed-off-by: Fabio Estevam <festevam@gmail.com>
> ---
> drivers/remoteproc/Kconfig | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/Kconfig b/drivers/remoteproc/Kconfig
> index 18be41b8aa7e..0df301be6d9a 100644
> --- a/drivers/remoteproc/Kconfig
> +++ b/drivers/remoteproc/Kconfig
> @@ -16,7 +16,7 @@ if REMOTEPROC
>
> config IMX_REMOTEPROC
> tristate "IMX6/7 remoteproc support"
> - depends on SOC_IMX6SX || SOC_IMX7D
> + depends on ARCH_MXC
> help
> Say y here to support iMX's remote processors (Cortex M4
> on iMX7D) via the remote processor framework.
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2019-06-04 5:01 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-03 23:46 [PATCH 1/2] remoteproc: imx: Broaden the Kconfig selection logic Fabio Estevam
2019-06-03 23:46 ` [PATCH 2/2] remoteproc: imx: Fix typo in "failed" Fabio Estevam
2019-06-04 4:19 ` Oleksij Rempel
2019-06-04 4:18 ` [PATCH 1/2] remoteproc: imx: Broaden the Kconfig selection logic Oleksij Rempel
2019-06-04 5:01 ` Bjorn Andersson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).