From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Arun Kumar Neelakantam <aneela@codeaurora.org>
Cc: ohad@wizery.com, bjorn.andersson@linaro.org, clew@codeaurora.org,
sricharan@codeaurora.org, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH V4 0/4] Add TIOCM Signals support for RPMSG char devices
Date: Tue, 19 May 2020 16:49:13 -0600 [thread overview]
Message-ID: <20200519224913.GD26832@xps15> (raw)
In-Reply-To: <1589346671-15226-1-git-send-email-aneela@codeaurora.org>
On Wed, May 13, 2020 at 10:41:07AM +0530, Arun Kumar Neelakantam wrote:
> Glink transport support signals to exchange state notification between
> local and remote side clients. Adding support to send/receive the signal
> command and notify the clients through callback and POLL notification.
From a general point of view it is hard to have an understanding of what this
patchset does and if it is the right solution due to a lack of context.
The cover letter and changelogs are sparse to a point where a
reviewer not familiar with the QC/Glink implementation can't offer much more
than syntactic comments.
Thanks,
Mathieu
>
> Changes since v3:
> - Correct the TICOMGET case handling as per new rpmsg_get_signals prototype
> - Update the rpmsg_get_signals function header
>
> Changes since v2:
> - Modify the rpmsg_get_signals function prototype
>
> Changes since v1:
> - Split the patches as per functional areas like core, char, glink
> - Add set, clear mask for TIOCMSET
> - Merge the char signal callback and POLLPRI patches
>
> Arun Kumar Neelakantam (4):
> rpmsg: core: Add signal API support
> rpmsg: glink: Add support to handle signals command
> rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support
> rpmsg: char: Add signal callback and POLLPRI support
>
> drivers/rpmsg/qcom_glink_native.c | 126 ++++++++++++++++++++++++++++++++++++++
> drivers/rpmsg/rpmsg_char.c | 75 ++++++++++++++++++++++-
> drivers/rpmsg/rpmsg_core.c | 41 +++++++++++++
> drivers/rpmsg/rpmsg_internal.h | 5 ++
> include/linux/rpmsg.h | 26 ++++++++
> 5 files changed, 270 insertions(+), 3 deletions(-)
>
> --
> 2.7.4
next prev parent reply other threads:[~2020-05-19 22:49 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-13 5:11 [RESEND PATCH V4 0/4] Add TIOCM Signals support for RPMSG char devices Arun Kumar Neelakantam
2020-05-13 5:11 ` [PATCH V4 1/4] rpmsg: core: Add signal API support Arun Kumar Neelakantam
2020-05-19 21:58 ` Mathieu Poirier
2020-05-13 5:11 ` [PATCH V4 2/4] rpmsg: glink: Add support to handle signals command Arun Kumar Neelakantam
2020-05-19 22:20 ` Mathieu Poirier
2020-05-13 5:11 ` [PATCH V4 3/4] rpmsg: char: Add TIOCMGET/TIOCMSET ioctl support Arun Kumar Neelakantam
2020-05-13 17:58 ` kbuild test robot
2020-05-19 22:33 ` Mathieu Poirier
2020-05-13 5:11 ` [PATCH V4 4/4] rpmsg: char: Add signal callback and POLLPRI support Arun Kumar Neelakantam
2020-05-19 22:49 ` Mathieu Poirier [this message]
-- strict thread matches above, loose matches on Subject: below --
2019-11-22 10:06 [RESEND PATCH V4 0/4] Add TIOCM Signals support for RPMSG char devices Arun Kumar Neelakantam
2019-11-22 10:06 Arun Kumar Neelakantam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200519224913.GD26832@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=aneela@codeaurora.org \
--cc=bjorn.andersson@linaro.org \
--cc=clew@codeaurora.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
--cc=sricharan@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).