From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
bjorn.andersson@linaro.org, tsoni@codeaurora.org,
psodagud@codeaurora.org, sidgup@codeaurora.org,
Sibi Sankar <sibis@codeaurora.org>
Subject: Re: [PATCH v1 2/4] remoteproc: qcom_q6v5_mss: Replace mask based tracking with size
Date: Tue, 14 Jul 2020 11:18:36 -0600 [thread overview]
Message-ID: <20200714171836.GA1407705@xps15> (raw)
In-Reply-To: <1594326716-15474-3-git-send-email-rishabhb@codeaurora.org>
On Thu, Jul 09, 2020 at 01:31:54PM -0700, Rishabh Bhatnagar wrote:
> From: Sibi Sankar <sibis@codeaurora.org>
>
> In order to land inline coredump support for mss, the dump_segment
> function would need to support granularities less than the segment
> size. This is achieved by replacing mask based tracking with size.
>
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
> ---
> drivers/remoteproc/qcom_q6v5_mss.c | 15 +++++++--------
> 1 file changed, 7 insertions(+), 8 deletions(-)
>
> diff --git a/drivers/remoteproc/qcom_q6v5_mss.c b/drivers/remoteproc/qcom_q6v5_mss.c
> index feb70283b..c6ce032 100644
> --- a/drivers/remoteproc/qcom_q6v5_mss.c
> +++ b/drivers/remoteproc/qcom_q6v5_mss.c
> @@ -181,8 +181,8 @@ struct q6v5 {
> bool running;
>
> bool dump_mba_loaded;
> - unsigned long dump_segment_mask;
> - unsigned long dump_complete_mask;
> + size_t current_dump_size;
> + size_t total_dump_size;
>
> phys_addr_t mba_phys;
> void *mba_region;
> @@ -1203,7 +1203,6 @@ static void qcom_q6v5_dump_segment(struct rproc *rproc,
> {
> int ret = 0;
> struct q6v5 *qproc = rproc->priv;
> - unsigned long mask = BIT((unsigned long)segment->priv);
> int offset = segment->da - qproc->mpss_reloc;
> void *ptr = NULL;
>
> @@ -1229,10 +1228,10 @@ static void qcom_q6v5_dump_segment(struct rproc *rproc,
> memset(dest, 0xff, segment->size);
> }
>
> - qproc->dump_segment_mask |= mask;
> + qproc->current_dump_size += segment->size;
>
> /* Reclaim mba after copying segments */
> - if (qproc->dump_segment_mask == qproc->dump_complete_mask) {
> + if (qproc->current_dump_size == qproc->total_dump_size) {
> if (qproc->dump_mba_loaded) {
> /* Try to reset ownership back to Q6 */
> q6v5_xfer_mem_ownership(qproc, &qproc->mpss_perm,
> @@ -1274,7 +1273,7 @@ static int q6v5_start(struct rproc *rproc)
> "Failed to reclaim mba buffer system may become unstable\n");
>
> /* Reset Dump Segment Mask */
> - qproc->dump_segment_mask = 0;
> + qproc->current_dump_size = 0;
> qproc->running = true;
>
> return 0;
> @@ -1323,7 +1322,7 @@ static int qcom_q6v5_register_dump_segments(struct rproc *rproc,
>
> ehdr = (struct elf32_hdr *)fw->data;
> phdrs = (struct elf32_phdr *)(ehdr + 1);
> - qproc->dump_complete_mask = 0;
> + qproc->total_dump_size = 0;
>
> for (i = 0; i < ehdr->e_phnum; i++) {
> phdr = &phdrs[i];
> @@ -1338,7 +1337,7 @@ static int qcom_q6v5_register_dump_segments(struct rproc *rproc,
> if (ret)
> break;
There is also no longer a need to carry the 'i' in:
ret = rproc_coredump_add_custom_segment(rproc, phdr->p_paddr,
phdr->p_memsz,
qcom_q6v5_dump_segment,
(void *)i);
>
> - qproc->dump_complete_mask |= BIT(i);
> + qproc->total_dump_size += phdr->p_memsz;
> }
>
> release_firmware(fw);
> --
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
>
next prev parent reply other threads:[~2020-07-14 17:18 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-09 20:31 [PATCH v7 0/4] Extend coredump functionality Rishabh Bhatnagar
2020-07-09 20:31 ` [PATCH v7 1/4] remoteproc: Move coredump functionality to a new file Rishabh Bhatnagar
2020-07-09 20:31 ` [PATCH v1 2/4] remoteproc: qcom_q6v5_mss: Replace mask based tracking with size Rishabh Bhatnagar
2020-07-14 17:18 ` Mathieu Poirier [this message]
2020-07-14 18:12 ` Sibi Sankar
2020-07-16 8:10 ` Sibi Sankar
2020-07-16 18:24 ` rishabhb
2020-07-20 16:57 ` Mathieu Poirier
2020-07-09 20:31 ` [PATCH v7 3/4] remoteproc: Add inline coredump functionality Rishabh Bhatnagar
2020-07-14 17:53 ` Mathieu Poirier
2020-07-15 19:22 ` rishabhb
2020-07-15 21:55 ` Mathieu Poirier
2020-07-16 8:25 ` Sibi Sankar
2020-07-16 18:25 ` rishabhb
2020-07-09 20:31 ` [PATCH v7 4/4] remoteproc: Add coredump debugfs entry Rishabh Bhatnagar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200714171836.GA1407705@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=psodagud@codeaurora.org \
--cc=rishabhb@codeaurora.org \
--cc=sibis@codeaurora.org \
--cc=sidgup@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).