From: Greg KH <gregkh@linuxfoundation.org>
To: Rishabh Bhatnagar <rishabhb@codeaurora.org>
Cc: linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
bjorn.andersson@linaro.org, mathieu.poirier@linaro.org,
tsoni@codeaurora.org, psodagud@codeaurora.org,
sidgup@codeaurora.org
Subject: Re: [PATCH v2 2/3] remoteproc: Add coredump configuration to sysfs
Date: Thu, 10 Sep 2020 19:58:21 +0200 [thread overview]
Message-ID: <20200910175821.GA3076593@kroah.com> (raw)
In-Reply-To: <1598557731-1566-3-git-send-email-rishabhb@codeaurora.org>
On Thu, Aug 27, 2020 at 12:48:50PM -0700, Rishabh Bhatnagar wrote:
> Expose coredump configuration in sysfs under a feature
> flag. This is useful for systems where access to
> debugfs might be limited.
>
> Signed-off-by: Rishabh Bhatnagar <rishabhb@codeaurora.org>
> ---
> Documentation/ABI/testing/sysfs-class-remoteproc | 24 +++++++++
> drivers/remoteproc/remoteproc_debugfs.c | 4 ++
> drivers/remoteproc/remoteproc_sysfs.c | 68 ++++++++++++++++++++++++
> 3 files changed, 96 insertions(+)
>
> diff --git a/Documentation/ABI/testing/sysfs-class-remoteproc b/Documentation/ABI/testing/sysfs-class-remoteproc
> index 36094fb..f6c44fa 100644
> --- a/Documentation/ABI/testing/sysfs-class-remoteproc
> +++ b/Documentation/ABI/testing/sysfs-class-remoteproc
> @@ -58,3 +58,27 @@ Description: Remote processor name
> Reports the name of the remote processor. This can be used by
> userspace in exactly identifying a remote processor and ease
> up the usage in modifying the 'firmware' or 'state' files.
> +
> +What: /sys/class/remoteproc/.../coredump
> +Date: July 2020
> +Contact: Bjorn Andersson <bjorn.andersson@linaro.org>, Ohad Ben-Cohen <ohad@wizery.com>
> +Description: Remote processor coredump configuration
> +
> + Reports the coredump configuration of the remote processor,
> + which will be one of:
> +
> + "default"
> + "inline"
> + "disabled"
> +
> + "default" means when the remote processor's coredump is
> + collected it will be copied to a separate buffer and that
> + buffer is exposed to userspace.
> +
> + "inline" means when the remote processor's coredump is
> + collected userspace will directly read from the remote
> + processor's device memory. Extra buffer will not be used to
> + copy the dump. Also recovery process will not proceed until
> + all data is read by usersapce.
> +
> + "disabled" means no dump will be collected.
> diff --git a/drivers/remoteproc/remoteproc_debugfs.c b/drivers/remoteproc/remoteproc_debugfs.c
> index 2e3b3e2..48dfd0a 100644
> --- a/drivers/remoteproc/remoteproc_debugfs.c
> +++ b/drivers/remoteproc/remoteproc_debugfs.c
> @@ -27,6 +27,7 @@
> /* remoteproc debugfs parent dir */
> static struct dentry *rproc_dbg;
>
> +#if (!IS_ENABLED(CONFIG_RPROC_SYSFS_CONFIGURATION_SUPPORT))
> /*
> * A coredump-configuration-to-string lookup table, for exposing a
> * human readable configuration via debugfs. Always keep in sync with
> @@ -114,6 +115,7 @@ static const struct file_operations rproc_coredump_fops = {
> .open = simple_open,
> .llseek = generic_file_llseek,
> };
> +#endif
>
> /*
> * Some remote processors may support dumping trace logs into a shared
> @@ -425,8 +427,10 @@ void rproc_create_debug_dir(struct rproc *rproc)
> rproc, &rproc_rsc_table_fops);
> debugfs_create_file("carveout_memories", 0400, rproc->dbg_dir,
> rproc, &rproc_carveouts_fops);
> +#if (!IS_ENABLED(CONFIG_RPROC_SYSFS_CONFIGURATION_SUPPORT))
> debugfs_create_file("coredump", 0600, rproc->dbg_dir,
> rproc, &rproc_coredump_fops);
> +#endif
Why does sysfs support for this have anything to do if you have a
debugfs file present or not? They should both work at the same time if
needed, right?
Same for patch 3/3 in this series...
thanks,
greg k-h
next prev parent reply other threads:[~2020-09-10 18:16 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-27 19:48 [PATCH v2 0/3] Expose recovery/coredump configuration from sysfs Rishabh Bhatnagar
2020-08-27 19:48 ` [PATCH v2 1/3] remoteproc: Expose remoteproc configuration through sysfs Rishabh Bhatnagar
2020-08-27 19:48 ` [PATCH v2 2/3] remoteproc: Add coredump configuration to sysfs Rishabh Bhatnagar
2020-09-10 17:58 ` Greg KH [this message]
2020-08-27 19:48 ` [PATCH v2 3/3] remoteproc: Add recovery " Rishabh Bhatnagar
2020-09-01 22:05 ` [PATCH v2 0/3] Expose recovery/coredump configuration from sysfs Mathieu Poirier
2020-09-02 23:14 ` rishabhb
2020-09-03 19:45 ` Mathieu Poirier
2020-09-03 23:59 ` Bjorn Andersson
2020-09-04 22:02 ` Mathieu Poirier
2020-09-09 17:27 ` rishabhb
2020-09-09 22:08 ` rishabhb
[not found] ` <0101017473e8b9f1-9c800bfd-d724-473f-96b8-c43920cc8967-000000@us-west-2.amazonses.com>
2020-09-10 17:46 ` Mathieu Poirier
2020-09-10 17:59 ` Greg KH
2020-09-15 9:51 ` Arnaud POULIQUEN
2020-09-26 3:31 ` Bjorn Andersson
2020-09-29 7:43 ` Arnaud POULIQUEN
2020-10-14 0:32 ` Bjorn Andersson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200910175821.GA3076593@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=psodagud@codeaurora.org \
--cc=rishabhb@codeaurora.org \
--cc=sidgup@codeaurora.org \
--cc=tsoni@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).