linux-remoteproc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Arnaud POULIQUEN <arnaud.pouliquen@st.com>
To: Rishabh Bhatnagar <rishabhb@codeaurora.org>,
	"linux-remoteproc@vger.kernel.org"
	<linux-remoteproc@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Cc: "bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
	"mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
	"tsoni@codeaurora.org" <tsoni@codeaurora.org>,
	"psodagud@codeaurora.org" <psodagud@codeaurora.org>,
	"sidgup@codeaurora.org" <sidgup@codeaurora.org>
Subject: Re: [PATCH v2 0/3] Expose recovery/coredump configuration from sysfs
Date: Tue, 15 Sep 2020 11:51:02 +0200	[thread overview]
Message-ID: <7ad40d80-5ac4-97a5-5e05-c83dc08896a2@st.com> (raw)
In-Reply-To: <1598557731-1566-1-git-send-email-rishabhb@codeaurora.org>

Hi Rishabh,

On 8/27/20 9:48 PM, Rishabh Bhatnagar wrote:
> From Android R onwards Google has restricted access to debugfs in user
> and user-debug builds. This restricts access to most of the features
> exposed through debugfs. This patch series adds a configurable option
> to move the recovery/coredump interfaces to sysfs. If the feature
> flag is selected it would move these interfaces to sysfs and remove
> the equivalent debugfs interface. 'Coredump' and 'Recovery' are critical
> interfaces that are required for remoteproc to work on Qualcomm Chipsets.
> Coredump configuration needs to be set to "inline" in debug/test build
> and "disabled" in production builds. Whereas recovery needs to be
> "disabled" for debugging purposes and "enabled" on production builds.

The remoteproc_cdev had been created to respond to some sysfs limitations.
I wonder if this evolution should not also be implemented in the cdev.
In this case an additional event could be addedd to inform the application
that a crash occurred and that a core dump is available.

Of course it's only a suggestion... As it would be a redesign.
I let Björn and Mathieu comment.

Regards,
Arnaud

> 
> Changelog:
> 
> v1 -> v2:
> - Correct the contact name in the sysfs documentation.
> - Remove the redundant write documentation for coredump/recovery sysfs
> - Add a feature flag to make this interface switch configurable.
> 
> Rishabh Bhatnagar (3):
>   remoteproc: Expose remoteproc configuration through sysfs
>   remoteproc: Add coredump configuration to sysfs
>   remoteproc: Add recovery configuration to sysfs
> 
>  Documentation/ABI/testing/sysfs-class-remoteproc |  44 ++++++++
>  drivers/remoteproc/Kconfig                       |  12 +++
>  drivers/remoteproc/remoteproc_debugfs.c          |  10 +-
>  drivers/remoteproc/remoteproc_sysfs.c            | 126 +++++++++++++++++++++++
>  4 files changed, 190 insertions(+), 2 deletions(-)
> 

  parent reply	other threads:[~2020-09-15  9:51 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-27 19:48 [PATCH v2 0/3] Expose recovery/coredump configuration from sysfs Rishabh Bhatnagar
2020-08-27 19:48 ` [PATCH v2 1/3] remoteproc: Expose remoteproc configuration through sysfs Rishabh Bhatnagar
2020-08-27 19:48 ` [PATCH v2 2/3] remoteproc: Add coredump configuration to sysfs Rishabh Bhatnagar
2020-09-10 17:58   ` Greg KH
2020-08-27 19:48 ` [PATCH v2 3/3] remoteproc: Add recovery " Rishabh Bhatnagar
2020-09-01 22:05 ` [PATCH v2 0/3] Expose recovery/coredump configuration from sysfs Mathieu Poirier
2020-09-02 23:14   ` rishabhb
2020-09-03 19:45     ` Mathieu Poirier
2020-09-03 23:59   ` Bjorn Andersson
2020-09-04 22:02     ` Mathieu Poirier
2020-09-09 17:27       ` rishabhb
2020-09-09 22:08         ` rishabhb
     [not found]       ` <0101017473e8b9f1-9c800bfd-d724-473f-96b8-c43920cc8967-000000@us-west-2.amazonses.com>
2020-09-10 17:46         ` Mathieu Poirier
2020-09-10 17:59       ` Greg KH
2020-09-15  9:51 ` Arnaud POULIQUEN [this message]
2020-09-26  3:31   ` Bjorn Andersson
2020-09-29  7:43     ` Arnaud POULIQUEN
2020-10-14  0:32       ` Bjorn Andersson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7ad40d80-5ac4-97a5-5e05-c83dc08896a2@st.com \
    --to=arnaud.pouliquen@st.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=psodagud@codeaurora.org \
    --cc=rishabhb@codeaurora.org \
    --cc=sidgup@codeaurora.org \
    --cc=tsoni@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).