linux-remoteproc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
To: Mathieu Poirier <mathieu.poirier@linaro.org>
Cc: ohad@wizery.com, bjorn.andersson@linaro.org,
	arnaud.pouliquen@st.com, linux-remoteproc@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 3/8] rpmsg: Move structure rpmsg_ns_msg to header file
Date: Tue, 3 Nov 2020 17:32:26 +0100	[thread overview]
Message-ID: <20201103163225.GA19947@ubuntu> (raw)
In-Reply-To: <20201027175218.1033609-4-mathieu.poirier@linaro.org>

Hi Mathieu,

On Tue, Oct 27, 2020 at 11:52:13AM -0600, Mathieu Poirier wrote:
> Move structure rpmsg_ns_msg to its own header file so that
> it can be used by other entities.
> 
> Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
> ---
>  drivers/rpmsg/virtio_rpmsg_bus.c | 32 +-----------------------
>  include/linux/rpmsg_ns.h         | 42 ++++++++++++++++++++++++++++++++

Sorry for a delayed comment, it just occurred to me: there is a 
include/linux/rpmsg directory already, so, perhaps it would be 
better to place the new headers there as include/linux/rpmsg/ns.h 
and include/linux/rpmsg/byteorder.h?

Thanks
Guennadi

  reply	other threads:[~2020-11-03 16:32 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-27 17:52 [PATCH v4 0/8] rpmsg: Make RPMSG name service modular Mathieu Poirier
2020-10-27 17:52 ` [PATCH v4 1/8] rpmsg: Introduce __rpmsg{16|32|64} types Mathieu Poirier
2020-10-27 17:52 ` [PATCH v4 2/8] rpmsg: virtio: Move from virtio to rpmsg byte conversion Mathieu Poirier
2020-10-27 17:52 ` [PATCH v4 3/8] rpmsg: Move structure rpmsg_ns_msg to header file Mathieu Poirier
2020-11-03 16:32   ` Guennadi Liakhovetski [this message]
2020-11-04 17:30     ` Mathieu Poirier
2020-11-04 14:03   ` Guennadi Liakhovetski
2020-10-27 17:52 ` [PATCH v4 4/8] rpmsg: virtio: Rename rpmsg_create_channel Mathieu Poirier
2020-10-27 17:52 ` [PATCH v4 5/8] rpmsg: core: Add channel creation internal API Mathieu Poirier
2020-10-27 17:52 ` [PATCH v4 6/8] rpmsg: virtio: Add rpmsg channel device ops Mathieu Poirier
2020-10-27 17:52 ` [PATCH v4 7/8] rpmsg: Make rpmsg_{register|unregister}_device() public Mathieu Poirier
2020-10-27 17:52 ` [PATCH v4 8/8] rpmsg: Turn name service into a stand alone driver Mathieu Poirier
2020-11-04 14:01   ` Guennadi Liakhovetski
2020-11-04 17:34     ` Mathieu Poirier
2020-11-04 18:39       ` Guennadi Liakhovetski
2020-11-04 20:03         ` Mathieu Poirier

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20201103163225.GA19947@ubuntu \
    --to=guennadi.liakhovetski@linux.intel.com \
    --cc=arnaud.pouliquen@st.com \
    --cc=bjorn.andersson@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=ohad@wizery.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).