From: Mathieu Poirier <mathieu.poirier@linaro.org>
To: Guennadi Liakhovetski <guennadi.liakhovetski@linux.intel.com>
Cc: ohad@wizery.com, bjorn.andersson@linaro.org,
arnaud.pouliquen@st.com, linux-remoteproc@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v4 8/8] rpmsg: Turn name service into a stand alone driver
Date: Wed, 4 Nov 2020 10:34:24 -0700 [thread overview]
Message-ID: <20201104173424.GB2893396@xps15> (raw)
In-Reply-To: <20201104140143.GA30197@ubuntu>
On Wed, Nov 04, 2020 at 03:01:44PM +0100, Guennadi Liakhovetski wrote:
> Hi Mathieu, Arnaud,
>
> I've tried the patch set with my VirtIO / vhost audio implementation,
> in general it worked quite well,
Very good - it would be nice if you could add your "Tested-by:" tags.
>
> On Tue, Oct 27, 2020 at 11:52:18AM -0600, Mathieu Poirier wrote:
> > From: Arnaud Pouliquen <arnaud.pouliquen@st.com>
> >
> > Make the RPMSG name service announcement a stand alone driver so that it
> > can be reused by other subsystems. It is also the first step in making the
> > functionatlity transport independent, i.e that is not tied to virtIO.
> >
> > Co-developed-by: Mathieu Poirier <mathieu.poirier@linaro.org>
> > Signed-off-by: Arnaud Pouliquen <arnaud.pouliquen@st.com>
> > ---
>
> [snip]
>
> > diff --git a/include/linux/rpmsg_ns.h b/include/linux/rpmsg_ns.h
> > index bb479f430080..42786bb759b5 100644
> > --- a/include/linux/rpmsg_ns.h
> > +++ b/include/linux/rpmsg_ns.h
> > @@ -39,4 +39,21 @@ enum rpmsg_ns_flags {
> > /* Address 53 is reserved for advertising remote services */
> > #define RPMSG_NS_ADDR (53)
> >
> > +/**
> > + * rpmsg_ns_register_device() - register name service device based on rpdev
> > + * @rpdev: prepared rpdev to be used for creating endpoints
> > + *
> > + * This function wraps rpmsg_register_device() preparing the rpdev for use as
> > + * basis for the rpmsg name service device.
> > + */
> > +static inline int rpmsg_ns_register_device(struct rpmsg_device *rpdev)
> > +{
> > + strcpy(rpdev->id.name, "rpmsg_ns");
>
> you need to
>
> #include <linux/rpmsg.h>
Of course yes - I'll simply add the header file. I plan on having another
revision addressing your comments out by the end of the week or early next week.
Thanks,
Mathieu
>
> in this file for rpdev definition. Or you could leave this function in
> rpmsg_ns.c, then it's enough to forward-declare struct rpdev here.
>
> Thanks
> Guennadi
>
> > + rpdev->driver_override = "rpmsg_ns";
> > + rpdev->src = RPMSG_NS_ADDR;
> > + rpdev->dst = RPMSG_NS_ADDR;
> > +
> > + return rpmsg_register_device(rpdev);
> > +}
> > +
> > #endif
> > --
> > 2.25.1
> >
next prev parent reply other threads:[~2020-11-04 17:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 17:52 [PATCH v4 0/8] rpmsg: Make RPMSG name service modular Mathieu Poirier
2020-10-27 17:52 ` [PATCH v4 1/8] rpmsg: Introduce __rpmsg{16|32|64} types Mathieu Poirier
2020-10-27 17:52 ` [PATCH v4 2/8] rpmsg: virtio: Move from virtio to rpmsg byte conversion Mathieu Poirier
2020-10-27 17:52 ` [PATCH v4 3/8] rpmsg: Move structure rpmsg_ns_msg to header file Mathieu Poirier
2020-11-03 16:32 ` Guennadi Liakhovetski
2020-11-04 17:30 ` Mathieu Poirier
2020-11-04 14:03 ` Guennadi Liakhovetski
2020-10-27 17:52 ` [PATCH v4 4/8] rpmsg: virtio: Rename rpmsg_create_channel Mathieu Poirier
2020-10-27 17:52 ` [PATCH v4 5/8] rpmsg: core: Add channel creation internal API Mathieu Poirier
2020-10-27 17:52 ` [PATCH v4 6/8] rpmsg: virtio: Add rpmsg channel device ops Mathieu Poirier
2020-10-27 17:52 ` [PATCH v4 7/8] rpmsg: Make rpmsg_{register|unregister}_device() public Mathieu Poirier
2020-10-27 17:52 ` [PATCH v4 8/8] rpmsg: Turn name service into a stand alone driver Mathieu Poirier
2020-11-04 14:01 ` Guennadi Liakhovetski
2020-11-04 17:34 ` Mathieu Poirier [this message]
2020-11-04 18:39 ` Guennadi Liakhovetski
2020-11-04 20:03 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20201104173424.GB2893396@xps15 \
--to=mathieu.poirier@linaro.org \
--cc=arnaud.pouliquen@st.com \
--cc=bjorn.andersson@linaro.org \
--cc=guennadi.liakhovetski@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).