Linux-remoteproc Archive on lore.kernel.org
 help / color / Atom feed
From: Rob Herring <robh@kernel.org>
To: Sibi Sankar <sibis@codeaurora.org>
Cc: bjorn.andersson@linaro.org, ulf.hansson@linaro.org,
	mathieu.poirier@linaro.org, swboyd@chromium.org,
	rjw@rjwysocki.net, agross@kernel.org, ohad@wizery.com,
	linux-arm-msm@vger.kernel.org, linux-remoteproc@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	dianders@chromium.org, rishabhb@codeaurora.org,
	sidgup@codeaurora.org
Subject: Re: [PATCH 01/12] dt-bindings: soc: qcom: aoss: Drop power-domain bindings
Date: Fri, 30 Apr 2021 09:59:50 -0500
Message-ID: <20210430145950.GA3311658@robh.at.kernel.org> (raw)
In-Reply-To: <1618574638-5117-2-git-send-email-sibis@codeaurora.org>

On Fri, Apr 16, 2021 at 05:33:47PM +0530, Sibi Sankar wrote:
> Drop power-domain bindings exposed by AOSS QMP node.

That's obvious from the diff. The commit msg should tell us why.

> 
> Signed-off-by: Sibi Sankar <sibis@codeaurora.org>
> ---
>  .../devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt       | 16 ++--------------
>  1 file changed, 2 insertions(+), 14 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> index 783dc81b0f26..c0ae051a5b76 100644
> --- a/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> +++ b/Documentation/devicetree/bindings/soc/qcom/qcom,aoss-qmp.txt
> @@ -9,8 +9,7 @@ Messaging Protocol (QMP)
>  
>  The AOSS side channel exposes control over a set of resources, used to control
>  a set of debug related clocks and to affect the low power state of resources
> -related to the secondary subsystems. These resources are exposed as a set of
> -power-domains.
> +related to the secondary subsystems.
>  
>  - compatible:
>  	Usage: required
> @@ -46,14 +45,6 @@ power-domains.
>  	Definition: must be 0
>  		    The single clock represents the QDSS clock.
>  
> -- #power-domain-cells:
> -	Usage: optional
> -	Value type: <u32>
> -	Definition: must be 1
> -		    The provided power-domains are:
> -		    CDSP state (0), LPASS state (1), modem state (2), SLPI
> -		    state (3), SPSS state (4) and Venus state (5).
> -
>  = SUBNODES
>  The AOSS side channel also provides the controls for three cooling devices,
>  these are expressed as subnodes of the QMP node. The name of the node is used
> @@ -66,8 +57,7 @@ to identify the resource and must therefor be "cx", "mx" or "ebi".
>  
>  = EXAMPLE
>  
> -The following example represents the AOSS side-channel message RAM and the
> -mechanism exposing the power-domains, as found in SDM845.
> +The following example represents the AOSS side-channel message RAM as found in SDM845.
>  
>    aoss_qmp: qmp@c300000 {
>  	  compatible = "qcom,sdm845-aoss-qmp";
> @@ -75,8 +65,6 @@ mechanism exposing the power-domains, as found in SDM845.
>  	  interrupts = <GIC_SPI 389 IRQ_TYPE_EDGE_RISING>;
>  	  mboxes = <&apss_shared 0>;
>  
> -	  #power-domain-cells = <1>;
> -
>  	  cx_cdev: cx {
>  		#cooling-cells = <2>;
>  	  };
> -- 
> The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
> a Linux Foundation Collaborative Project
> 

  parent reply index

Thread overview: 31+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-04-16 12:03 [PATCH 00/12] Use qmp_send to update co-processor load state Sibi Sankar
2021-04-16 12:03 ` [PATCH 01/12] dt-bindings: soc: qcom: aoss: Drop power-domain bindings Sibi Sankar
2021-04-18  1:54   ` Stephen Boyd
2021-04-30 14:59   ` Rob Herring [this message]
2021-04-16 12:03 ` [PATCH 02/12] soc: qcom: aoss: Drop power domain support Sibi Sankar
2021-04-18  2:01   ` Stephen Boyd
2021-04-27  6:25     ` Sibi Sankar
2021-05-28  4:05       ` Bjorn Andersson
2021-06-02  3:56         ` Sibi Sankar
2021-04-16 12:03 ` [PATCH 03/12] dt-bindings: remoteproc: qcom: pas: Add QMP bindings Sibi Sankar
2021-04-18  1:55   ` Stephen Boyd
2021-04-30 15:02   ` Rob Herring
2021-04-16 12:03 ` [PATCH 04/12] dt-bindings: remoteproc: qcom: " Sibi Sankar
2021-04-18  1:55   ` Stephen Boyd
2021-04-30 15:02   ` Rob Herring
2021-04-16 12:03 ` [PATCH 05/12] remoteproc: qcom: q6v5: Use qmp_send to update co-processor load state Sibi Sankar
2021-04-16 12:03 ` [PATCH 06/12] arm64: dts: qcom: sc7180: Use QMP binding to control " Sibi Sankar
2021-04-18  2:02   ` Stephen Boyd
2021-04-16 12:03 ` [PATCH 07/12] arm64: dts: qcom: sc7280: " Sibi Sankar
2021-04-18  2:02   ` Stephen Boyd
2021-04-16 12:03 ` [PATCH 08/12] arm64: dts: qcom: sdm845: " Sibi Sankar
2021-04-18  2:02   ` Stephen Boyd
2021-04-16 12:03 ` [PATCH 09/12] arm64: dts: qcom: sm8150: " Sibi Sankar
2021-04-18  2:02   ` Stephen Boyd
2021-04-16 12:03 ` [PATCH 10/12] arm64: dts: qcom: sm8250: " Sibi Sankar
2021-04-18  2:03   ` Stephen Boyd
2021-04-16 12:03 ` [PATCH 11/12] arm64: dts: qcom: sm8350: " Sibi Sankar
2021-04-18  2:03   ` Stephen Boyd
2021-04-16 12:03 ` [PATCH 12/12] dt-bindings: soc: qcom: aoss: Delete unused power-domain definitions Sibi Sankar
2021-04-18  2:03   ` Stephen Boyd
2021-04-30 15:02   ` Rob Herring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20210430145950.GA3311658@robh.at.kernel.org \
    --to=robh@kernel.org \
    --cc=agross@kernel.org \
    --cc=bjorn.andersson@linaro.org \
    --cc=devicetree@vger.kernel.org \
    --cc=dianders@chromium.org \
    --cc=linux-arm-msm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-remoteproc@vger.kernel.org \
    --cc=mathieu.poirier@linaro.org \
    --cc=ohad@wizery.com \
    --cc=rishabhb@codeaurora.org \
    --cc=rjw@rjwysocki.net \
    --cc=sibis@codeaurora.org \
    --cc=sidgup@codeaurora.org \
    --cc=swboyd@chromium.org \
    --cc=ulf.hansson@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-remoteproc Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-remoteproc/0 linux-remoteproc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-remoteproc linux-remoteproc/ https://lore.kernel.org/linux-remoteproc \
		linux-remoteproc@vger.kernel.org
	public-inbox-index linux-remoteproc

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-remoteproc


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git