From: Dong Aisheng <aisheng.dong@nxp.com>
To: linux-remoteproc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, ohad@wizery.com,
dongas86@gmail.com, bjorn.andersson@linaro.org,
mathieu.poirier@linaro.org, cleger@kalray.eu, peng.fan@nxp.com,
Dong Aisheng <aisheng.dong@nxp.com>
Subject: [PATCH v3 1/5] remoteproc: fix the wrong default value of is_iomem
Date: Thu, 5 Aug 2021 11:32:02 +0800 [thread overview]
Message-ID: <20210805033206.1295269-1-aisheng.dong@nxp.com> (raw)
Currently the is_iomem is a random value in the stack which may
be default to true even on those platforms that not use iomem to
store firmware.
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
Fixes: 40df0a91b2a5 ("remoteproc: add is_iomem to da_to_va")
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
---
v2->v3:
* no changes
v1->v2:
* update rproc_copy_segment as well
---
drivers/remoteproc/remoteproc_coredump.c | 2 +-
drivers/remoteproc/remoteproc_elf_loader.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/remoteproc/remoteproc_coredump.c b/drivers/remoteproc/remoteproc_coredump.c
index aee657cc08c6..c892f433a323 100644
--- a/drivers/remoteproc/remoteproc_coredump.c
+++ b/drivers/remoteproc/remoteproc_coredump.c
@@ -152,8 +152,8 @@ static void rproc_copy_segment(struct rproc *rproc, void *dest,
struct rproc_dump_segment *segment,
size_t offset, size_t size)
{
+ bool is_iomem = false;
void *ptr;
- bool is_iomem;
if (segment->dump) {
segment->dump(rproc, segment, dest, offset, size);
diff --git a/drivers/remoteproc/remoteproc_elf_loader.c b/drivers/remoteproc/remoteproc_elf_loader.c
index e8078efb3dec..3cd1798f17a3 100644
--- a/drivers/remoteproc/remoteproc_elf_loader.c
+++ b/drivers/remoteproc/remoteproc_elf_loader.c
@@ -178,8 +178,8 @@ int rproc_elf_load_segments(struct rproc *rproc, const struct firmware *fw)
u64 filesz = elf_phdr_get_p_filesz(class, phdr);
u64 offset = elf_phdr_get_p_offset(class, phdr);
u32 type = elf_phdr_get_p_type(class, phdr);
+ bool is_iomem = false;
void *ptr;
- bool is_iomem;
if (type != PT_LOAD)
continue;
--
2.25.1
next reply other threads:[~2021-08-05 3:33 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 3:32 Dong Aisheng [this message]
2021-08-05 3:32 ` [PATCH v3 2/5] remoteproc: imx_rproc: fix TCM io memory type Dong Aisheng
2021-08-05 9:59 ` Peng Fan
2021-08-05 16:34 ` Mathieu Poirier
2021-08-05 3:32 ` [PATCH v3 3/5] remoteproc: imx_rproc: fix ignoring mapping vdev regions Dong Aisheng
2021-08-05 9:59 ` Peng Fan
2021-08-05 3:32 ` [PATCH v3 4/5] remoteproc: imx_rproc: fix rsc-table name Dong Aisheng
2021-08-05 9:59 ` Peng Fan
2021-08-05 3:32 ` [PATCH v3 5/5] remoteproc: imx_rproc: change to ioremap_wc for dram Dong Aisheng
2021-08-05 9:57 ` Peng Fan (OSS)
2021-08-05 16:36 ` Mathieu Poirier
2021-09-10 8:57 ` Peng Fan
2021-08-05 9:58 ` [PATCH v3 1/5] remoteproc: fix the wrong default value of is_iomem Peng Fan (OSS)
2021-08-05 16:37 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20210805033206.1295269-1-aisheng.dong@nxp.com \
--to=aisheng.dong@nxp.com \
--cc=bjorn.andersson@linaro.org \
--cc=cleger@kalray.eu \
--cc=dongas86@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
--cc=peng.fan@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).