From: "Peng Fan (OSS)" <peng.fan@oss.nxp.com>
To: Aisheng Dong <aisheng.dong@nxp.com>,
"linux-remoteproc@vger.kernel.org"
<linux-remoteproc@vger.kernel.org>
Cc: "linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"ohad@wizery.com" <ohad@wizery.com>,
"dongas86@gmail.com" <dongas86@gmail.com>,
"bjorn.andersson@linaro.org" <bjorn.andersson@linaro.org>,
"mathieu.poirier@linaro.org" <mathieu.poirier@linaro.org>,
"cleger@kalray.eu" <cleger@kalray.eu>
Subject: RE: [PATCH v3 5/5] remoteproc: imx_rproc: change to ioremap_wc for dram
Date: Thu, 5 Aug 2021 09:57:10 +0000 [thread overview]
Message-ID: <AM5PR0402MB275630A505C7828931043F1988F29@AM5PR0402MB2756.eurprd04.prod.outlook.com> (raw)
In-Reply-To: <20210805033206.1295269-5-aisheng.dong@nxp.com>
> Subject: [PATCH v3 5/5] remoteproc: imx_rproc: change to ioremap_wc for
> dram
>
> DRAM is not io memory, so changed to ioremap_wc. This is also aligned with
> core io accessories. e.g. memcpy/memset and cpu direct access.
>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Mathieu Poirier <mathieu.poirier@linaro.org>
> Cc: Peng Fan <peng.fan@nxp.com>
> Signed-off-by: Dong Aisheng <aisheng.dong@nxp.com>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
> ---
> v2->v3:
> * patch content unchanged.
> Only drop the wrong tag in v2
> Tested on MX8MQ and MX8MP, MX7ULP.
> v1->v2:
> * new patch
> ---
> drivers/remoteproc/imx_rproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/imx_rproc.c
> b/drivers/remoteproc/imx_rproc.c index ff620688fad9..4ae416ba5080
> 100644
> --- a/drivers/remoteproc/imx_rproc.c
> +++ b/drivers/remoteproc/imx_rproc.c
> @@ -597,7 +597,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
> break;
>
> /* Not use resource version, because we might share region */
> - priv->mem[b].cpu_addr = devm_ioremap(&pdev->dev, res.start,
> resource_size(&res));
> + priv->mem[b].cpu_addr = devm_ioremap_wc(&pdev->dev,
> res.start,
> +resource_size(&res));
> if (!priv->mem[b].cpu_addr) {
> dev_err(dev, "failed to remap %pr\n", &res);
> return -ENOMEM;
> --
> 2.25.1
next prev parent reply other threads:[~2021-08-05 9:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-05 3:32 [PATCH v3 1/5] remoteproc: fix the wrong default value of is_iomem Dong Aisheng
2021-08-05 3:32 ` [PATCH v3 2/5] remoteproc: imx_rproc: fix TCM io memory type Dong Aisheng
2021-08-05 9:59 ` Peng Fan
2021-08-05 16:34 ` Mathieu Poirier
2021-08-05 3:32 ` [PATCH v3 3/5] remoteproc: imx_rproc: fix ignoring mapping vdev regions Dong Aisheng
2021-08-05 9:59 ` Peng Fan
2021-08-05 3:32 ` [PATCH v3 4/5] remoteproc: imx_rproc: fix rsc-table name Dong Aisheng
2021-08-05 9:59 ` Peng Fan
2021-08-05 3:32 ` [PATCH v3 5/5] remoteproc: imx_rproc: change to ioremap_wc for dram Dong Aisheng
2021-08-05 9:57 ` Peng Fan (OSS) [this message]
2021-08-05 16:36 ` Mathieu Poirier
2021-09-10 8:57 ` Peng Fan
2021-08-05 9:58 ` [PATCH v3 1/5] remoteproc: fix the wrong default value of is_iomem Peng Fan (OSS)
2021-08-05 16:37 ` Mathieu Poirier
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AM5PR0402MB275630A505C7828931043F1988F29@AM5PR0402MB2756.eurprd04.prod.outlook.com \
--to=peng.fan@oss.nxp.com \
--cc=aisheng.dong@nxp.com \
--cc=bjorn.andersson@linaro.org \
--cc=cleger@kalray.eu \
--cc=dongas86@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).