From: Tanmay Shah <tanmay.shah@amd.com>
To: <andersson@kernel.org>, <mathieu.poirier@linaro.org>
Cc: <linux-remoteproc@vger.kernel.org>,
<linux-kernel@vger.kernel.org>, Tanmay Shah <tanmay.shah@amd.com>,
Tarak Reddy <tarak.reddy@amd.com>
Subject: [PATCH v2 2/2] remoteproc: enhance rproc_put() for clusters
Date: Tue, 21 Mar 2023 21:09:36 -0700 [thread overview]
Message-ID: <20230322040933.924813-3-tanmay.shah@amd.com> (raw)
In-Reply-To: <20230322040933.924813-1-tanmay.shah@amd.com>
This patch enhances rproc_put() to support remoteproc clusters
with multiple child nodes as in rproc_get_by_phandle().
Signed-off-by: Tarak Reddy <tarak.reddy@amd.com>
Signed-off-by: Tanmay Shah <tanmay.shah@amd.com>
---
drivers/remoteproc/remoteproc_core.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/drivers/remoteproc/remoteproc_core.c b/drivers/remoteproc/remoteproc_core.c
index a3e7c8798381..e7e451012615 100644
--- a/drivers/remoteproc/remoteproc_core.c
+++ b/drivers/remoteproc/remoteproc_core.c
@@ -2560,6 +2560,19 @@ EXPORT_SYMBOL(rproc_free);
void rproc_put(struct rproc *rproc)
{
module_put(rproc->dev.parent->driver->owner);
+ struct platform_device *cluster_pdev;
+
+ if (rproc->dev.parent) {
+ if (rproc->dev.parent->driver) {
+ module_put(rproc->dev.parent->driver->owner);
+ } else {
+ cluster_pdev = of_find_device_by_node(rproc->dev.parent->of_node->parent);
+ if (cluster_pdev) {
+ module_put(cluster_pdev->dev.driver->owner);
+ put_device(&cluster_pdev->dev);
+ }
+ }
+ }
put_device(&rproc->dev);
}
EXPORT_SYMBOL(rproc_put);
--
2.25.1
next prev parent reply other threads:[~2023-03-22 4:10 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 4:09 [PATCH v2 0/2] remoteproc: get rproc devices for clusters Tanmay Shah
2023-03-22 4:09 ` [PATCH v2 1/2] remoteproc: Make rproc_get_by_phandle() work " Tanmay Shah
2023-03-22 4:09 ` Tanmay Shah [this message]
2023-03-22 6:20 ` [PATCH v2 2/2] remoteproc: enhance rproc_put() " kernel test robot
2023-03-22 7:31 ` kernel test robot
2023-03-22 11:52 ` Dan Carpenter
2023-03-22 16:05 ` Mathieu Poirier
2023-03-22 17:34 ` Tanmay Shah
2023-03-23 22:45 ` Mathieu Poirier
2023-03-22 14:12 ` [PATCH v2 0/2] remoteproc: get rproc devices " Bjorn Andersson
2023-03-22 16:11 ` Mathieu Poirier
2023-03-22 17:37 ` Tanmay Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230322040933.924813-3-tanmay.shah@amd.com \
--to=tanmay.shah@amd.com \
--cc=andersson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=tarak.reddy@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).