From: Dan Carpenter <error27@gmail.com>
To: oe-kbuild@lists.linux.dev, Tanmay Shah <tanmay.shah@amd.com>,
andersson@kernel.org, mathieu.poirier@linaro.org
Cc: lkp@intel.com, oe-kbuild-all@lists.linux.dev,
linux-remoteproc@vger.kernel.org, linux-kernel@vger.kernel.org,
Tanmay Shah <tanmay.shah@amd.com>,
Tarak Reddy <tarak.reddy@amd.com>
Subject: Re: [PATCH v2 2/2] remoteproc: enhance rproc_put() for clusters
Date: Wed, 22 Mar 2023 14:52:45 +0300 [thread overview]
Message-ID: <82ff071d-cd00-47f8-bc72-4d78bfed731d@kili.mountain> (raw)
In-Reply-To: <20230322040933.924813-3-tanmay.shah@amd.com>
Hi Tanmay,
url: https://github.com/intel-lab-lkp/linux/commits/Tanmay-Shah/remoteproc-Make-rproc_get_by_phandle-work-for-clusters/20230322-121102
base: e19967994d342a5986d950a1bfddf19d7e1191b7
patch link: https://lore.kernel.org/r/20230322040933.924813-3-tanmay.shah%40amd.com
patch subject: [PATCH v2 2/2] remoteproc: enhance rproc_put() for clusters
config: powerpc-randconfig-m041-20230322 (https://download.01.org/0day-ci/archive/20230322/202303221916.LgKkr8Gk-lkp@intel.com/config)
compiler: powerpc-linux-gcc (GCC) 12.1.0
If you fix the issue, kindly add following tag where applicable
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Link: https://lore.kernel.org/r/202303221916.LgKkr8Gk-lkp@intel.com/
smatch warnings:
drivers/remoteproc/remoteproc_core.c:2565 rproc_put() warn: variable dereferenced before check 'rproc->dev.parent' (see line 2562)
drivers/remoteproc/remoteproc_core.c:2566 rproc_put() warn: variable dereferenced before check 'rproc->dev.parent->driver' (see line 2562)
vim +2565 drivers/remoteproc/remoteproc_core.c
160e7c840fe858 Ohad Ben-Cohen 2012-07-04 2560 void rproc_put(struct rproc *rproc)
400e64df6b237e Ohad Ben-Cohen 2011-10-20 2561 {
fbb6aacb078285 Bjorn Andersson 2016-10-02 @2562 module_put(rproc->dev.parent->driver->owner);
^^^^^^^^^^^^^^^^^^^^^^^^^^^
Unchecked dereferences.
573d22d13a6970 Tanmay Shah 2023-03-21 2563 struct platform_device *cluster_pdev;
573d22d13a6970 Tanmay Shah 2023-03-21 2564
573d22d13a6970 Tanmay Shah 2023-03-21 @2565 if (rproc->dev.parent) {
^^^^^^^^^^^^^^^^^
Checked too late.
573d22d13a6970 Tanmay Shah 2023-03-21 @2566 if (rproc->dev.parent->driver) {
^^^^^^^^^^^^^^^^^^^^^^^^^
573d22d13a6970 Tanmay Shah 2023-03-21 2567 module_put(rproc->dev.parent->driver->owner);
573d22d13a6970 Tanmay Shah 2023-03-21 2568 } else {
573d22d13a6970 Tanmay Shah 2023-03-21 2569 cluster_pdev = of_find_device_by_node(rproc->dev.parent->of_node->parent);
573d22d13a6970 Tanmay Shah 2023-03-21 2570 if (cluster_pdev) {
573d22d13a6970 Tanmay Shah 2023-03-21 2571 module_put(cluster_pdev->dev.driver->owner);
573d22d13a6970 Tanmay Shah 2023-03-21 2572 put_device(&cluster_pdev->dev);
573d22d13a6970 Tanmay Shah 2023-03-21 2573 }
573d22d13a6970 Tanmay Shah 2023-03-21 2574 }
573d22d13a6970 Tanmay Shah 2023-03-21 2575 }
b5ab5e24e960b9 Ohad Ben-Cohen 2012-05-30 2576 put_device(&rproc->dev);
400e64df6b237e Ohad Ben-Cohen 2011-10-20 2577 }
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests
next prev parent reply other threads:[~2023-03-22 11:52 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-03-22 4:09 [PATCH v2 0/2] remoteproc: get rproc devices for clusters Tanmay Shah
2023-03-22 4:09 ` [PATCH v2 1/2] remoteproc: Make rproc_get_by_phandle() work " Tanmay Shah
2023-03-22 4:09 ` [PATCH v2 2/2] remoteproc: enhance rproc_put() " Tanmay Shah
2023-03-22 6:20 ` kernel test robot
2023-03-22 7:31 ` kernel test robot
2023-03-22 11:52 ` Dan Carpenter [this message]
2023-03-22 16:05 ` Mathieu Poirier
2023-03-22 17:34 ` Tanmay Shah
2023-03-23 22:45 ` Mathieu Poirier
2023-03-22 14:12 ` [PATCH v2 0/2] remoteproc: get rproc devices " Bjorn Andersson
2023-03-22 16:11 ` Mathieu Poirier
2023-03-22 17:37 ` Tanmay Shah
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=82ff071d-cd00-47f8-bc72-4d78bfed731d@kili.mountain \
--to=error27@gmail.com \
--cc=andersson@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=lkp@intel.com \
--cc=mathieu.poirier@linaro.org \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=oe-kbuild@lists.linux.dev \
--cc=tanmay.shah@amd.com \
--cc=tarak.reddy@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).