From: Arnaud POULIQUEN <arnaud.pouliquen@foss.st.com>
To: Arnd Bergmann <arnd@kernel.org>, Ohad Ben-Cohen <ohad@wizery.com>,
"Bjorn Andersson" <bjorn.andersson@linaro.org>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
Alexandre Torgue <alexandre.torgue@foss.st.com>,
Arnaud Pouliquen <arnaud.pouliquen@st.com>
Cc: Arnd Bergmann <arnd@arndb.de>, <linux-remoteproc@vger.kernel.org>,
<linux-stm32@st-md-mailman.stormreply.com>,
<linux-arm-kernel@lists.infradead.org>,
<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] remoteproc: stm32: fix phys_addr_t format string
Date: Thu, 22 Apr 2021 12:22:23 +0200 [thread overview]
Message-ID: <5c8724b8-ec88-de4d-26b9-b95620bff3d9@foss.st.com> (raw)
In-Reply-To: <20210421140053.3727528-1-arnd@kernel.org>
Hello Arnd,
On 4/21/21 4:00 PM, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
>
> A phys_addr_t may be wider than an int or pointer:
>
> drivers/remoteproc/stm32_rproc.c: In function 'stm32_rproc_da_to_pa':
> drivers/remoteproc/stm32_rproc.c:583:30: error: format '%x' expects argument of type 'unsigned int', but argument 5 has type 'phys_addr_t' {aka 'long long unsigned int'} [-Werror=format=]
> 583 | dev_dbg(dev, "da %llx to pa %#x\n", da, *pa);
>
> Print it by reference using the special %pap format string.
>
> Fixes: 8a471396d21c ("remoteproc: stm32: Move resource table setup to rproc_ops")
> igned-off-by: Arnd Bergmann <arnd@arndb.de>
It seems that the 'S' has disappeared during the copy/past :)
It's strange that no bot has made a report...
Reviewed-by: Arnaud Pouliquen <arnaud.pouliquen@foss.st.com>
Thanks for the fix!
Arnaud
> ---
> drivers/remoteproc/stm32_rproc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/remoteproc/stm32_rproc.c b/drivers/remoteproc/stm32_rproc.c
> index 7353f9e7e7af..32595c950569 100644
> --- a/drivers/remoteproc/stm32_rproc.c
> +++ b/drivers/remoteproc/stm32_rproc.c
> @@ -580,7 +580,7 @@ static int stm32_rproc_da_to_pa(struct rproc *rproc,
> continue;
>
> *pa = da - p_mem->dev_addr + p_mem->bus_addr;
> - dev_dbg(dev, "da %llx to pa %#x\n", da, *pa);
> + dev_dbg(dev, "da %llx to pa %pap\n", da, pa);
>
> return 0;
> }
>
next prev parent reply other threads:[~2021-04-22 10:22 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-21 14:00 [PATCH] remoteproc: stm32: fix phys_addr_t format string Arnd Bergmann
2021-04-22 10:22 ` Arnaud POULIQUEN [this message]
2021-05-31 14:50 ` patchwork-bot+linux-remoteproc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c8724b8-ec88-de4d-26b9-b95620bff3d9@foss.st.com \
--to=arnaud.pouliquen@foss.st.com \
--cc=alexandre.torgue@foss.st.com \
--cc=arnaud.pouliquen@st.com \
--cc=arnd@arndb.de \
--cc=arnd@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-remoteproc@vger.kernel.org \
--cc=linux-stm32@st-md-mailman.stormreply.com \
--cc=mathieu.poirier@linaro.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=ohad@wizery.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).