Linux-Renesas-SoC Archive on lore.kernel.org
 help / Atom feed
* [PATCH RFT] spi-renesas-rpc: manual read issue workaround
@ 2018-12-27 20:21 Sergei Shtylyov
  2019-01-07 18:15 ` Mark Brown
  0 siblings, 1 reply; 7+ messages in thread
From: Sergei Shtylyov @ 2018-12-27 20:21 UTC (permalink / raw)
  To: Mark Brown, linux-spi, Mason Yang; +Cc: linux-renesas-soc

Even with the trickery introduced in the latest version of the RPC-IF SPI
driver, RPC-IF corrupts the data byte 4 for the RDID command, so the flash
chip is still not detected. It started to work correctly after I tried to
implement the workaround to this issue using the U-Boot RPC-IF driver's
approach, i.e. using the external address space read mode.

While at it, I'm removing the aforementioned trickery... 

Signed-off-by: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>

---
The patch is against the 'devel' branch of Simon Horman's 'renesas,git' repo
plus the RPC-IF SPI driver patch [1] and its prerequisites...
 
[1] https://patchwork.kernel.org/patch/10742037/

 drivers/spi/spi-renesas-rpc.c |   66 ++++++++++++++++++++++++++----------------
 1 file changed, 42 insertions(+), 24 deletions(-)

Index: renesas/drivers/spi/spi-renesas-rpc.c
===================================================================
--- renesas.orig/drivers/spi/spi-renesas-rpc.c
+++ renesas/drivers/spi/spi-renesas-rpc.c
@@ -270,34 +270,52 @@ static int rpc_spi_io_xfer(struct rpc_sp
 	} else if (rx_buf) {
 		smenr = rpc->smenr;
 
-		while (pos < rpc->xferlen) {
+		/*
+		 * RPC-IF spoils the data for the commands without an address
+		 * phase (like RDID) in the manual mode, so we'll have to work
+		 * around this issue by using the external address space read
+		 * mode instead; we seem to be able to read 8 bytes at most in
+		 * this mode though...
+		 */
+		if (!(smenr & RPC_SMENR_ADE(0xf))) {
 			u32 nbytes = rpc->xferlen - pos;
+			u64 tmp;
 
-			if (nbytes > 4)
-				nbytes = 4;
+			if (nbytes > 8)
+				nbytes = 8;
 
-			smcr = rpc->smcr | RPC_SMCR_SPIE;
+			regmap_write(rpc->regmap, RPC_CMNCR, RPC_CMNCR_SFDE |
+				     RPC_CMNCR_MOIIO_HIZ | RPC_CMNCR_IOFV_HIZ |
+				     RPC_CMNCR_BSZ(0));
+			regmap_write(rpc->regmap, RPC_DRCR, 0);
+			regmap_write(rpc->regmap, RPC_DREAR, RPC_DREAR_EAC(1));
+			regmap_write(rpc->regmap, RPC_DRCMR, rpc->cmd);
+			regmap_write(rpc->regmap, RPC_DRDMCR, rpc->dummy);
+			regmap_write(rpc->regmap, RPC_DROPR, 0);
+			regmap_write(rpc->regmap, RPC_DRENR, rpc->smenr &
+				     ~RPC_SMENR_SPIDE(0xf));
+
+			tmp = readq(rpc->dirmap);
+			memcpy(rx_buf, &tmp, nbytes);
+		} else {
+			while (pos < rpc->xferlen) {
+				u32 nbytes = rpc->xferlen - pos;
+
+				if (nbytes > 4)
+					nbytes = 4;
+
+				smcr = rpc->smcr | RPC_SMCR_SPIE;
+
+				regmap_write(rpc->regmap, RPC_SMENR, smenr);
+				regmap_write(rpc->regmap, RPC_SMCR, smcr);
+				ret = wait_msg_xfer_end(rpc);
+				if (ret)
+					goto out;
+
+				regmap_read(rpc->regmap, RPC_SMRDR0, &data);
+				memcpy(rx_buf + pos, &data, nbytes);
+				pos += nbytes;
 
-			if (rpc->xferlen > 4 && rpc->xferlen < 8 && pos == 0)
-				smcr |= RPC_SMCR_SSLKP;
-
-			regmap_write(rpc->regmap, RPC_SMENR, smenr);
-			regmap_write(rpc->regmap, RPC_SMCR, smcr);
-			ret = wait_msg_xfer_end(rpc);
-			if (ret)
-				goto out;
-
-			regmap_read(rpc->regmap, RPC_SMRDR0, &data);
-			memcpy(rx_buf + pos, &data, nbytes);
-			pos += nbytes;
-
-			if (rpc->xferlen > 4 && rpc->xferlen < 8 && pos == 4) {
-				smenr = rpc->smenr & ~RPC_SMENR_CDE &
-					~RPC_SMENR_ADE(0xf);
-			} else {
-				regmap_write(rpc->regmap, RPC_SMCMR, rpc->cmd);
-				regmap_write(rpc->regmap, RPC_SMDMCR,
-					     rpc->dummy);
 				regmap_write(rpc->regmap, RPC_SMADR,
 					     rpc->addr + pos);
 			}

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH RFT] spi-renesas-rpc: manual read issue workaround
  2018-12-27 20:21 [PATCH RFT] spi-renesas-rpc: manual read issue workaround Sergei Shtylyov
@ 2019-01-07 18:15 ` Mark Brown
  2019-01-08  7:52   ` Sergei Shtylyov
  0 siblings, 1 reply; 7+ messages in thread
From: Mark Brown @ 2019-01-07 18:15 UTC (permalink / raw)
  To: Sergei Shtylyov; +Cc: linux-spi, Mason Yang, linux-renesas-soc

[-- Attachment #1: Type: text/plain, Size: 180 bytes --]

On Thu, Dec 27, 2018 at 11:21:14PM +0300, Sergei Shtylyov wrote:

>  drivers/spi/spi-renesas-rpc.c |   66 ++++++++++++++++++++++++++----------------

This does not exist upstream.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH RFT] spi-renesas-rpc: manual read issue workaround
  2019-01-07 18:15 ` Mark Brown
@ 2019-01-08  7:52   ` Sergei Shtylyov
  2019-01-08 12:29     ` Mark Brown
  0 siblings, 1 reply; 7+ messages in thread
From: Sergei Shtylyov @ 2019-01-08  7:52 UTC (permalink / raw)
  To: Mark Brown; +Cc: linux-spi, Mason Yang, linux-renesas-soc

Hello!

On 07.01.2019 21:15, Mark Brown wrote:

> On Thu, Dec 27, 2018 at 11:21:14PM +0300, Sergei Shtylyov wrote:
> 
>>   drivers/spi/spi-renesas-rpc.c |   66 ++++++++++++++++++++++++++----------------
> 
> This does not exist upstream.

    As I said, the patch was atop of the RPC-IF driver patch by M. Yang.

MBR, Sergei

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH RFT] spi-renesas-rpc: manual read issue workaround
  2019-01-08  7:52   ` Sergei Shtylyov
@ 2019-01-08 12:29     ` Mark Brown
  2019-01-10 18:38       ` Sergei Shtylyov
  0 siblings, 1 reply; 7+ messages in thread
From: Mark Brown @ 2019-01-08 12:29 UTC (permalink / raw)
  To: Sergei Shtylyov; +Cc: linux-spi, Mason Yang, linux-renesas-soc

[-- Attachment #1: Type: text/plain, Size: 335 bytes --]

On Tue, Jan 08, 2019 at 10:52:11AM +0300, Sergei Shtylyov wrote:

> > >   drivers/spi/spi-renesas-rpc.c |   66 ++++++++++++++++++++++++++----------------

> > This does not exist upstream.

>    As I said, the patch was atop of the RPC-IF driver patch by M. Yang.

Please don't submit patches for things that aren't upstream upstream.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH RFT] spi-renesas-rpc: manual read issue workaround
  2019-01-08 12:29     ` Mark Brown
@ 2019-01-10 18:38       ` Sergei Shtylyov
  2019-01-14 22:47         ` Mark Brown
  0 siblings, 1 reply; 7+ messages in thread
From: Sergei Shtylyov @ 2019-01-10 18:38 UTC (permalink / raw)
  To: Mark Brown; +Cc: linux-spi, Mason Yang, linux-renesas-soc

On 01/08/2019 03:29 PM, Mark Brown wrote:

>>>>   drivers/spi/spi-renesas-rpc.c |   66 ++++++++++++++++++++++++++----------------
> 
>>> This does not exist upstream.
> 
>>    As I said, the patch was atop of the RPC-IF driver patch by M. Yang.
> 
> Please don't submit patches for things that aren't upstream upstream.

   Even with RFC/RFT in the subject?

MBR, Sergei

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH RFT] spi-renesas-rpc: manual read issue workaround
  2019-01-10 18:38       ` Sergei Shtylyov
@ 2019-01-14 22:47         ` Mark Brown
  2019-01-15 16:25           ` Sergei Shtylyov
  0 siblings, 1 reply; 7+ messages in thread
From: Mark Brown @ 2019-01-14 22:47 UTC (permalink / raw)
  To: Sergei Shtylyov; +Cc: linux-spi, Mason Yang, linux-renesas-soc

[-- Attachment #1: Type: text/plain, Size: 609 bytes --]

On Thu, Jan 10, 2019 at 09:38:33PM +0300, Sergei Shtylyov wrote:
> On 01/08/2019 03:29 PM, Mark Brown wrote:

> >>    As I said, the patch was atop of the RPC-IF driver patch by M. Yang.

> > Please don't submit patches for things that aren't upstream upstream.

>    Even with RFC/RFT in the subject?

It's certainly an issue for the testing side of things if someone needs
to apply it on top of a patch that isn't even on the list in order to
test!  It's obviously OK to propose changes to a thing that's currently
in review but it it's something nobody is even trying to upstream then
that's less helpful.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 488 bytes --]

^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH RFT] spi-renesas-rpc: manual read issue workaround
  2019-01-14 22:47         ` Mark Brown
@ 2019-01-15 16:25           ` Sergei Shtylyov
  0 siblings, 0 replies; 7+ messages in thread
From: Sergei Shtylyov @ 2019-01-15 16:25 UTC (permalink / raw)
  To: Mark Brown; +Cc: linux-spi, Mason Yang, linux-renesas-soc

On 01/15/2019 01:47 AM, Mark Brown wrote:

>>>>    As I said, the patch was atop of the RPC-IF driver patch by M. Yang.
> 
>>> Please don't submit patches for things that aren't upstream upstream.
> 
>>    Even with RFC/RFT in the subject?
> 
> It's certainly an issue for the testing side of things if someone needs
> to apply it on top of a patch that isn't even on the list in order to
> test!  It's obviously OK to propose changes to a thing that's currently
> in review but it it's something nobody is even trying to upstream then
> that's less helpful.

   Hm... I'm seeing the linux-spi ML among the addressees of the RPC-IF patch
by Mason Yang. and I'm seeing it in the archives:

https://marc.info/?l=linux-spi&m=154563438006940

MBR, Sergei

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-27 20:21 [PATCH RFT] spi-renesas-rpc: manual read issue workaround Sergei Shtylyov
2019-01-07 18:15 ` Mark Brown
2019-01-08  7:52   ` Sergei Shtylyov
2019-01-08 12:29     ` Mark Brown
2019-01-10 18:38       ` Sergei Shtylyov
2019-01-14 22:47         ` Mark Brown
2019-01-15 16:25           ` Sergei Shtylyov

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org linux-renesas-soc@archiver.kernel.org
	public-inbox-index linux-renesas-soc


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox