* [PATCH 0/2] arm64: dts: renesas: Fix MSIOF1 DMA channels
@ 2020-09-17 13:21 Geert Uytterhoeven
2020-09-17 13:21 ` [PATCH 1/2] arm64: dts: renesas: r8a77990: " Geert Uytterhoeven
2020-09-17 13:21 ` [PATCH 2/2] arm64: dts: renesas: r8a774c0: " Geert Uytterhoeven
0 siblings, 2 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2020-09-17 13:21 UTC (permalink / raw)
To: Magnus Damm; +Cc: linux-renesas-soc, Geert Uytterhoeven
Hi all,
According to Technical Update TN-RCT-S0352A/E, MSIOF1 DMA can only be
used with SYS-DMAC0 on some SoCs. This patch series fixes the DTS files
for the affected SoCs,
I have tested this on Ebisu/4D with R-Car E3 using spidev_test and DT
overlays
- r8a77990-msiof1-dmac0-spidev.dtso
- r8a77990-msiof1-dmac1-spidev-bad.dtso
- r8a77990-msiof1-dmac2-spidev-bad.dtso
from
https://git.kernel.org/pub/scm/linux/kernel/git/geert/renesas-drivers.git/log/?h=topic/renesas-overlays
The bad ones fail with:
spi_sh_msiof e6ea0000.spi: failed to start hardware
spidev spi0.0: SPI transfer failed: -110
I intend to queue these in renesas-devel for v5.10.
Thanks for your comments!
Geert Uytterhoeven (2):
arm64: dts: renesas: r8a77990: Fix MSIOF1 DMA channels
arm64: dts: renesas: r8a774c0: Fix MSIOF1 DMA channels
arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 5 ++---
arch/arm64/boot/dts/renesas/r8a77990.dtsi | 5 ++---
2 files changed, 4 insertions(+), 6 deletions(-)
--
2.17.1
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 1/2] arm64: dts: renesas: r8a77990: Fix MSIOF1 DMA channels
2020-09-17 13:21 [PATCH 0/2] arm64: dts: renesas: Fix MSIOF1 DMA channels Geert Uytterhoeven
@ 2020-09-17 13:21 ` Geert Uytterhoeven
2020-09-19 9:34 ` Ulrich Hecht
2020-09-17 13:21 ` [PATCH 2/2] arm64: dts: renesas: r8a774c0: " Geert Uytterhoeven
1 sibling, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2020-09-17 13:21 UTC (permalink / raw)
To: Magnus Damm; +Cc: linux-renesas-soc, Geert Uytterhoeven
According to Technical Update TN-RCT-S0352A/E, MSIOF1 DMA can only be
used with SYS-DMAC0 on R-Car E3.
Fixes: 8517042060b55a37 ("arm64: dts: renesas: r8a77990: Add DMA properties to MSIOF nodes")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm64/boot/dts/renesas/r8a77990.dtsi | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
index 2cdf766fe3651809..87d41bc076a99d95 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
@@ -1193,9 +1193,8 @@
reg = <0 0xe6ea0000 0 0x0064>;
interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 210>;
- dmas = <&dmac1 0x43>, <&dmac1 0x42>,
- <&dmac2 0x43>, <&dmac2 0x42>;
- dma-names = "tx", "rx", "tx", "rx";
+ dmas = <&dmac0 0x43>, <&dmac0 0x42>;
+ dma-names = "tx", "rx";
power-domains = <&sysc R8A77990_PD_ALWAYS_ON>;
resets = <&cpg 210>;
#address-cells = <1>;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 1/2] arm64: dts: renesas: r8a77990: Fix MSIOF1 DMA channels
2020-09-17 13:21 ` [PATCH 1/2] arm64: dts: renesas: r8a77990: " Geert Uytterhoeven
@ 2020-09-19 9:34 ` Ulrich Hecht
0 siblings, 0 replies; 6+ messages in thread
From: Ulrich Hecht @ 2020-09-19 9:34 UTC (permalink / raw)
To: Geert Uytterhoeven, Magnus Damm; +Cc: linux-renesas-soc
> On 09/17/2020 3:21 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>
>
> According to Technical Update TN-RCT-S0352A/E, MSIOF1 DMA can only be
> used with SYS-DMAC0 on R-Car E3.
>
> Fixes: 8517042060b55a37 ("arm64: dts: renesas: r8a77990: Add DMA properties to MSIOF nodes")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> arch/arm64/boot/dts/renesas/r8a77990.dtsi | 5 ++---
> 1 file changed, 2 insertions(+), 3 deletions(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> index 2cdf766fe3651809..87d41bc076a99d95 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
> @@ -1193,9 +1193,8 @@
> reg = <0 0xe6ea0000 0 0x0064>;
> interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>;
> clocks = <&cpg CPG_MOD 210>;
> - dmas = <&dmac1 0x43>, <&dmac1 0x42>,
> - <&dmac2 0x43>, <&dmac2 0x42>;
> - dma-names = "tx", "rx", "tx", "rx";
> + dmas = <&dmac0 0x43>, <&dmac0 0x42>;
> + dma-names = "tx", "rx";
> power-domains = <&sysc R8A77990_PD_ALWAYS_ON>;
> resets = <&cpg 210>;
> #address-cells = <1>;
> --
> 2.17.1
Reviewed-by: Ulrich Hecht <uli+renesas@fpond.eu>
CU
Uli
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH 2/2] arm64: dts: renesas: r8a774c0: Fix MSIOF1 DMA channels
2020-09-17 13:21 [PATCH 0/2] arm64: dts: renesas: Fix MSIOF1 DMA channels Geert Uytterhoeven
2020-09-17 13:21 ` [PATCH 1/2] arm64: dts: renesas: r8a77990: " Geert Uytterhoeven
@ 2020-09-17 13:21 ` Geert Uytterhoeven
2020-09-19 9:36 ` Ulrich Hecht
1 sibling, 1 reply; 6+ messages in thread
From: Geert Uytterhoeven @ 2020-09-17 13:21 UTC (permalink / raw)
To: Magnus Damm; +Cc: linux-renesas-soc, Geert Uytterhoeven
According to Technical Update TN-RCT-S0352A/E, MSIOF1 DMA can only be
used with SYS-DMAC0 on R-Car E3.
Fixes: 62c0056f1c3eb15d ("arm64: dts: renesas: r8a774c0: Add MSIOF nodes")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 5 ++---
1 file changed, 2 insertions(+), 3 deletions(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
index a51d3a36a4d3dc9c..e0e54342cd4c77d4 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
@@ -1215,9 +1215,8 @@
reg = <0 0xe6ea0000 0 0x0064>;
interrupts = <GIC_SPI 157 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&cpg CPG_MOD 210>;
- dmas = <&dmac1 0x43>, <&dmac1 0x42>,
- <&dmac2 0x43>, <&dmac2 0x42>;
- dma-names = "tx", "rx", "tx", "rx";
+ dmas = <&dmac0 0x43>, <&dmac0 0x42>;
+ dma-names = "tx", "rx";
power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
resets = <&cpg 210>;
#address-cells = <1>;
--
2.17.1
^ permalink raw reply related [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] arm64: dts: renesas: r8a774c0: Fix MSIOF1 DMA channels
2020-09-17 13:21 ` [PATCH 2/2] arm64: dts: renesas: r8a774c0: " Geert Uytterhoeven
@ 2020-09-19 9:36 ` Ulrich Hecht
2020-09-21 7:33 ` Geert Uytterhoeven
0 siblings, 1 reply; 6+ messages in thread
From: Ulrich Hecht @ 2020-09-19 9:36 UTC (permalink / raw)
To: Geert Uytterhoeven, Magnus Damm; +Cc: linux-renesas-soc
> On 09/17/2020 3:21 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote:
>
>
> According to Technical Update TN-RCT-S0352A/E, MSIOF1 DMA can only be
> used with SYS-DMAC0 on R-Car E3.
This patch changes the file for RZ/G2E, though. And that's not mentioned in the cited document.
CU
Uli
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 2/2] arm64: dts: renesas: r8a774c0: Fix MSIOF1 DMA channels
2020-09-19 9:36 ` Ulrich Hecht
@ 2020-09-21 7:33 ` Geert Uytterhoeven
0 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2020-09-21 7:33 UTC (permalink / raw)
To: Ulrich Hecht; +Cc: Magnus Damm, Linux-Renesas
Hi Uli,
On Sat, Sep 19, 2020 at 11:36 AM Ulrich Hecht <uli@fpond.eu> wrote:
> > On 09/17/2020 3:21 PM Geert Uytterhoeven <geert+renesas@glider.be> wrote:
> > According to Technical Update TN-RCT-S0352A/E, MSIOF1 DMA can only be
> > used with SYS-DMAC0 on R-Car E3.
>
> This patch changes the file for RZ/G2E, though. And that's not mentioned in the cited document.
Thanks, that's correct. We know the issue is present there, too, and
that the RZ/G2 documentation has not been updated yet.
IMHO no need to keep known bugs alive any longer.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2020-09-21 7:33 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-09-17 13:21 [PATCH 0/2] arm64: dts: renesas: Fix MSIOF1 DMA channels Geert Uytterhoeven
2020-09-17 13:21 ` [PATCH 1/2] arm64: dts: renesas: r8a77990: " Geert Uytterhoeven
2020-09-19 9:34 ` Ulrich Hecht
2020-09-17 13:21 ` [PATCH 2/2] arm64: dts: renesas: r8a774c0: " Geert Uytterhoeven
2020-09-19 9:36 ` Ulrich Hecht
2020-09-21 7:33 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).