* [PATCH 0/3] add missing of_node_put
@ 2019-01-13 9:44 Julia Lawall
2019-01-13 9:44 ` [PATCH 1/3] drm: rcar-du: " Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2019-01-13 9:44 UTC (permalink / raw)
To: devicetree
Cc: kernel-janitors, linux-kernel, dri-devel, linux-renesas-soc,
linux-amlogic, linux-arm-kernel
The result of of_graph_get_remote_port_parent needs an of_node_put,
even if it is not available.
---
drivers/gpu/drm/meson/meson_drv.c | 9 +++++++--
drivers/gpu/drm/rcar-du/rcar_du_kms.c | 1 +
drivers/of/property.c | 1 +
3 files changed, 9 insertions(+), 2 deletions(-)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH 1/3] drm: rcar-du: add missing of_node_put
2019-01-13 9:44 [PATCH 0/3] add missing of_node_put Julia Lawall
@ 2019-01-13 9:44 ` Julia Lawall
2019-01-14 14:34 ` Kieran Bingham
0 siblings, 1 reply; 4+ messages in thread
From: Julia Lawall @ 2019-01-13 9:44 UTC (permalink / raw)
To: Laurent Pinchart
Cc: kernel-janitors, Kieran Bingham, David Airlie, Daniel Vetter,
dri-devel, linux-renesas-soc, linux-kernel
Add an of_node_put when the result of of_graph_get_remote_port_parent is
not available.
The semantic match that finds this problem is as follows
(http://coccinelle.lip6.fr):
// <smpl>
@r exists@
local idexpression e;
expression x;
@@
e = of_graph_get_remote_port_parent(...);
... when != x = e
when != true e == NULL
when != of_node_put(e)
when != of_fwnode_handle(e)
(
return e;
|
*return ...;
)
// </smpl>
Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
---
drivers/gpu/drm/rcar-du/rcar_du_kms.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
index 9c7007d..bc3fcb3 100644
--- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
+++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
@@ -331,6 +331,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
dev_dbg(rcdu->dev,
"connected entity %pOF is disabled, skipping\n",
entity);
+ of_node_put(entity);
return -ENODEV;
}
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] drm: rcar-du: add missing of_node_put
2019-01-13 9:44 ` [PATCH 1/3] drm: rcar-du: " Julia Lawall
@ 2019-01-14 14:34 ` Kieran Bingham
2019-01-14 16:19 ` Julia Lawall
0 siblings, 1 reply; 4+ messages in thread
From: Kieran Bingham @ 2019-01-14 14:34 UTC (permalink / raw)
To: Julia Lawall, Laurent Pinchart
Cc: kernel-janitors, David Airlie, Daniel Vetter, dri-devel,
linux-renesas-soc, linux-kernel
Hi Julia,
Thank you for the patch,
On 13/01/2019 09:44, Julia Lawall wrote:
> Add an of_node_put when the result of of_graph_get_remote_port_parent is
> not available.
>
> The semantic match that finds this problem is as follows
> (http://coccinelle.lip6.fr):
>
> // <smpl>
> @r exists@
> local idexpression e;
> expression x;
> @@
> e = of_graph_get_remote_port_parent(...);
> ... when != x = e
> when != true e == NULL
> when != of_node_put(e)
> when != of_fwnode_handle(e)
> (
> return e;
> |
> *return ...;
> )
> // </smpl>
>
For this part at least:
Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
But a little discussion below:
> Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
This does indeed look like a missing of_node_put() but I don't think it
will be the only one in that code. It gets a bit tangled - and I think
there's possibly another missing put on the error path of
if (!encoder) {
dev_warn(rcdu->dev,
"no encoder found for endpoint %pOF, skipping\n",
ep->local_node);
return -ENODEV;
}
because that implies that no encoder was found, and thus -
encoder = entity;
was not executed, and the tail of that function calls:
of_node_put(encoder);
which would have been the final of_node_put(entity)
I think that part could be considered separate to this patch, but it's
also quite closely related. Either way - I think it needs a second pair
of eyes to see if I'm not crazy :)
Regards
Kieran
>
> ---
> drivers/gpu/drm/rcar-du/rcar_du_kms.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> index 9c7007d..bc3fcb3 100644
> --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> @@ -331,6 +331,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
> dev_dbg(rcdu->dev,
> "connected entity %pOF is disabled, skipping\n",
> entity);
> + of_node_put(entity);
> return -ENODEV;
> }
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/3] drm: rcar-du: add missing of_node_put
2019-01-14 14:34 ` Kieran Bingham
@ 2019-01-14 16:19 ` Julia Lawall
0 siblings, 0 replies; 4+ messages in thread
From: Julia Lawall @ 2019-01-14 16:19 UTC (permalink / raw)
To: Kieran Bingham
Cc: Laurent Pinchart, kernel-janitors, David Airlie, Daniel Vetter,
dri-devel, linux-renesas-soc, linux-kernel
On Mon, 14 Jan 2019, Kieran Bingham wrote:
> Hi Julia,
>
> Thank you for the patch,
>
> On 13/01/2019 09:44, Julia Lawall wrote:
> > Add an of_node_put when the result of of_graph_get_remote_port_parent is
> > not available.
> >
> > The semantic match that finds this problem is as follows
> > (http://coccinelle.lip6.fr):
> >
> > // <smpl>
> > @r exists@
> > local idexpression e;
> > expression x;
> > @@
> > e = of_graph_get_remote_port_parent(...);
> > ... when != x = e
> > when != true e == NULL
> > when != of_node_put(e)
> > when != of_fwnode_handle(e)
> > (
> > return e;
> > |
> > *return ...;
> > )
> > // </smpl>
> >
>
> For this part at least:
>
> Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
>
> But a little discussion below:
>
>
> > Signed-off-by: Julia Lawall <Julia.Lawall@lip6.fr>
>
> This does indeed look like a missing of_node_put() but I don't think it
> will be the only one in that code. It gets a bit tangled - and I think
> there's possibly another missing put on the error path of
>
> if (!encoder) {
> dev_warn(rcdu->dev,
> "no encoder found for endpoint %pOF, skipping\n",
> ep->local_node);
> return -ENODEV;
> }
>
> because that implies that no encoder was found, and thus -
> encoder = entity;
>
> was not executed, and the tail of that function calls:
>
> of_node_put(encoder);
>
> which would have been the final of_node_put(entity)
Looking at it again, I agree. I can just extend this patch.
julia
>
>
> I think that part could be considered separate to this patch, but it's
> also quite closely related. Either way - I think it needs a second pair
> of eyes to see if I'm not crazy :)
>
> Regards
>
> Kieran
>
> >
> > ---
> > drivers/gpu/drm/rcar-du/rcar_du_kms.c | 1 +
> > 1 file changed, 1 insertion(+)
> >
> > diff --git a/drivers/gpu/drm/rcar-du/rcar_du_kms.c b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > index 9c7007d..bc3fcb3 100644
> > --- a/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > +++ b/drivers/gpu/drm/rcar-du/rcar_du_kms.c
> > @@ -331,6 +331,7 @@ static int rcar_du_encoders_init_one(struct rcar_du_device *rcdu,
> > dev_dbg(rcdu->dev,
> > "connected entity %pOF is disabled, skipping\n",
> > entity);
> > + of_node_put(entity);
> > return -ENODEV;
> > }
> >
> >
>
>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2019-01-14 16:19 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-13 9:44 [PATCH 0/3] add missing of_node_put Julia Lawall
2019-01-13 9:44 ` [PATCH 1/3] drm: rcar-du: " Julia Lawall
2019-01-14 14:34 ` Kieran Bingham
2019-01-14 16:19 ` Julia Lawall
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).