* [PATCH v4 1/2] dt-bindings: display: Add idk-1110wr binding
2020-03-11 20:03 [PATCH v4 0/2] Add LVDS panel support to HiHope RZ/G2M Lad Prabhakar
@ 2020-03-11 20:03 ` Lad Prabhakar
2020-03-14 7:38 ` Sam Ravnborg
2020-03-11 20:03 ` [PATCH v4 2/2] arm64: dts: renesas: Add HiHope RZ/G2M board with idk-1110wr display Lad Prabhakar
2020-03-12 10:10 ` [PATCH v4 0/2] Add LVDS panel support to HiHope RZ/G2M Geert Uytterhoeven
2 siblings, 1 reply; 5+ messages in thread
From: Lad Prabhakar @ 2020-03-11 20:03 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
Rob Herring, Mark Rutland, Geert Uytterhoeven, Magnus Damm
Cc: dri-devel, devicetree, linux-kernel, linux-renesas-soc,
Lad Prabhakar, Laurent Pinchart
From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Add binding for the idk-1110wr LVDS panel from Advantech.
Some panel-specific documentation can be found here:
https://buy.advantech.eu/Displays/Embedded-LCD-Kits-LCD-Kit-Modules/model-IDK-1110WR-55WSA1E.htm
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
.../display/panel/advantech,idk-1110wr.yaml | 69 ++++++++++++++++++++++
1 file changed, 69 insertions(+)
create mode 100644 Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml
diff --git a/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml b/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml
new file mode 100644
index 0000000..93878c2
--- /dev/null
+++ b/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml
@@ -0,0 +1,69 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/display/panel/advantech,idk-1110wr.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Advantech IDK-1110WR 10.1" WSVGA LVDS Display Panel
+
+maintainers:
+ - Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
+ - Thierry Reding <thierry.reding@gmail.com>
+
+allOf:
+ - $ref: lvds.yaml#
+
+properties:
+ compatible:
+ items:
+ - const: advantech,idk-1110wr
+ - {} # panel-lvds, but not listed here to avoid false select
+
+ data-mapping:
+ const: jeida-24
+
+ width-mm:
+ const: 223
+
+ height-mm:
+ const: 125
+
+ panel-timing: true
+ port: true
+
+additionalProperties: false
+
+required:
+ - compatible
+
+examples:
+ - |+
+ panel {
+ compatible = "advantech,idk-1110wr", "panel-lvds";
+
+ width-mm = <223>;
+ height-mm = <125>;
+
+ data-mapping = "jeida-24";
+
+ panel-timing {
+ /* 1024x600 @60Hz */
+ clock-frequency = <51200000>;
+ hactive = <1024>;
+ vactive = <600>;
+ hsync-len = <240>;
+ hfront-porch = <40>;
+ hback-porch = <40>;
+ vsync-len = <10>;
+ vfront-porch = <15>;
+ vback-porch = <10>;
+ };
+
+ port {
+ panel_in: endpoint {
+ remote-endpoint = <&lvds_encoder>;
+ };
+ };
+ };
+
+...
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v4 1/2] dt-bindings: display: Add idk-1110wr binding
2020-03-11 20:03 ` [PATCH v4 1/2] dt-bindings: display: Add idk-1110wr binding Lad Prabhakar
@ 2020-03-14 7:38 ` Sam Ravnborg
0 siblings, 0 replies; 5+ messages in thread
From: Sam Ravnborg @ 2020-03-14 7:38 UTC (permalink / raw)
To: Lad Prabhakar
Cc: Thierry Reding, David Airlie, Daniel Vetter, Rob Herring,
Mark Rutland, Geert Uytterhoeven, Magnus Damm, dri-devel,
devicetree, linux-kernel, linux-renesas-soc, Laurent Pinchart
Hi Prabhakar
On Wed, Mar 11, 2020 at 08:03:39PM +0000, Lad Prabhakar wrote:
> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
>
> Add binding for the idk-1110wr LVDS panel from Advantech.
>
> Some panel-specific documentation can be found here:
> https://buy.advantech.eu/Displays/Embedded-LCD-Kits-LCD-Kit-Modules/model-IDK-1110WR-55WSA1E.htm
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
Applied, and pushed to drm-misc-next.
Sam
> ---
> .../display/panel/advantech,idk-1110wr.yaml | 69 ++++++++++++++++++++++
> 1 file changed, 69 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml
>
> diff --git a/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml b/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml
> new file mode 100644
> index 0000000..93878c2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml
> @@ -0,0 +1,69 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/display/panel/advantech,idk-1110wr.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Advantech IDK-1110WR 10.1" WSVGA LVDS Display Panel
> +
> +maintainers:
> + - Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> + - Thierry Reding <thierry.reding@gmail.com>
> +
> +allOf:
> + - $ref: lvds.yaml#
> +
> +properties:
> + compatible:
> + items:
> + - const: advantech,idk-1110wr
> + - {} # panel-lvds, but not listed here to avoid false select
> +
> + data-mapping:
> + const: jeida-24
> +
> + width-mm:
> + const: 223
> +
> + height-mm:
> + const: 125
> +
> + panel-timing: true
> + port: true
> +
> +additionalProperties: false
> +
> +required:
> + - compatible
> +
> +examples:
> + - |+
> + panel {
> + compatible = "advantech,idk-1110wr", "panel-lvds";
> +
> + width-mm = <223>;
> + height-mm = <125>;
> +
> + data-mapping = "jeida-24";
> +
> + panel-timing {
> + /* 1024x600 @60Hz */
> + clock-frequency = <51200000>;
> + hactive = <1024>;
> + vactive = <600>;
> + hsync-len = <240>;
> + hfront-porch = <40>;
> + hback-porch = <40>;
> + vsync-len = <10>;
> + vfront-porch = <15>;
> + vback-porch = <10>;
> + };
> +
> + port {
> + panel_in: endpoint {
> + remote-endpoint = <&lvds_encoder>;
> + };
> + };
> + };
> +
> +...
> --
> 2.7.4
^ permalink raw reply [flat|nested] 5+ messages in thread
* [PATCH v4 2/2] arm64: dts: renesas: Add HiHope RZ/G2M board with idk-1110wr display
2020-03-11 20:03 [PATCH v4 0/2] Add LVDS panel support to HiHope RZ/G2M Lad Prabhakar
2020-03-11 20:03 ` [PATCH v4 1/2] dt-bindings: display: Add idk-1110wr binding Lad Prabhakar
@ 2020-03-11 20:03 ` Lad Prabhakar
2020-03-12 10:10 ` [PATCH v4 0/2] Add LVDS panel support to HiHope RZ/G2M Geert Uytterhoeven
2 siblings, 0 replies; 5+ messages in thread
From: Lad Prabhakar @ 2020-03-11 20:03 UTC (permalink / raw)
To: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
Rob Herring, Mark Rutland, Geert Uytterhoeven, Magnus Damm
Cc: dri-devel, devicetree, linux-kernel, linux-renesas-soc,
Lad Prabhakar, Laurent Pinchart
From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
The HiHope RZ/G2M is advertised as compatible with panel idk-1110wr
from Advantech, however the panel isn't sold alongside the board.
A new dts, adding everything that's required to get the panel to
work with HiHope RZ/G2M, is the most convenient way to support the
HiHope RZ/G2M when it's connected to the idk-1110wr.
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
arch/arm64/boot/dts/renesas/Makefile | 1 +
.../r8a774a1-hihope-rzg2m-ex-idk-1110wr.dts | 52 ++++++++++++++++++++++
2 files changed, 53 insertions(+)
create mode 100644 arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-ex-idk-1110wr.dts
diff --git a/arch/arm64/boot/dts/renesas/Makefile b/arch/arm64/boot/dts/renesas/Makefile
index 2153842..82dd245 100644
--- a/arch/arm64/boot/dts/renesas/Makefile
+++ b/arch/arm64/boot/dts/renesas/Makefile
@@ -1,6 +1,7 @@
# SPDX-License-Identifier: GPL-2.0
dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-hihope-rzg2m.dtb
dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-hihope-rzg2m-ex.dtb
+dtb-$(CONFIG_ARCH_R8A774A1) += r8a774a1-hihope-rzg2m-ex-idk-1110wr.dtb
dtb-$(CONFIG_ARCH_R8A774B1) += r8a774b1-hihope-rzg2n.dtb
dtb-$(CONFIG_ARCH_R8A774B1) += r8a774b1-hihope-rzg2n-ex.dtb
dtb-$(CONFIG_ARCH_R8A774C0) += r8a774c0-cat874.dtb r8a774c0-ek874.dtb \
diff --git a/arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-ex-idk-1110wr.dts b/arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-ex-idk-1110wr.dts
new file mode 100644
index 0000000..2ab5edd
--- /dev/null
+++ b/arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-ex-idk-1110wr.dts
@@ -0,0 +1,52 @@
+// SPDX-License-Identifier: GPL-2.0
+/*
+ * Device Tree Source for the HiHope RZ/G2M sub board connected to an
+ * Advantech IDK-1110WR 10.1" LVDS panel
+ *
+ * Copyright (C) 2020 Renesas Electronics Corp.
+ */
+
+#include "r8a774a1-hihope-rzg2m-ex.dts"
+#include "rzg2-advantech-idk-1110wr-panel.dtsi"
+
+/ {
+ backlight {
+ compatible = "pwm-backlight";
+ pwms = <&pwm0 0 50000>;
+
+ brightness-levels = <0 2 8 16 32 64 128 255>;
+ default-brightness-level = <6>;
+ };
+
+};
+
+&gpio1 {
+ /*
+ * When GP1_20 is LOW LVDS0 is connected to the LVDS connector
+ * When GP1_20 is HIGH LVDS0 is connected to the LT8918L
+ */
+ lvds-connector-en-gpio {
+ gpio-hog;
+ gpios = <20 GPIO_ACTIVE_HIGH>;
+ output-low;
+ line-name = "lvds-connector-en-gpio";
+ };
+};
+
+&lvds0 {
+ status = "okay";
+};
+
+&pfc {
+ pwm0_pins: pwm0 {
+ groups = "pwm0";
+ function = "pwm0";
+ };
+};
+
+&pwm0 {
+ pinctrl-0 = <&pwm0_pins>;
+ pinctrl-names = "default";
+
+ status = "okay";
+};
--
2.7.4
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [PATCH v4 0/2] Add LVDS panel support to HiHope RZ/G2M
2020-03-11 20:03 [PATCH v4 0/2] Add LVDS panel support to HiHope RZ/G2M Lad Prabhakar
2020-03-11 20:03 ` [PATCH v4 1/2] dt-bindings: display: Add idk-1110wr binding Lad Prabhakar
2020-03-11 20:03 ` [PATCH v4 2/2] arm64: dts: renesas: Add HiHope RZ/G2M board with idk-1110wr display Lad Prabhakar
@ 2020-03-12 10:10 ` Geert Uytterhoeven
2 siblings, 0 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2020-03-12 10:10 UTC (permalink / raw)
To: Lad Prabhakar
Cc: Thierry Reding, Sam Ravnborg, David Airlie, Daniel Vetter,
Rob Herring, Mark Rutland, Geert Uytterhoeven, Magnus Damm,
DRI Development,
open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
Linux Kernel Mailing List, Linux-Renesas, Laurent Pinchart
Hi Lad,
On Wed, Mar 11, 2020 at 9:03 PM Lad Prabhakar
<prabhakar.mahadev-lad.rj@bp.renesas.com> wrote:
> The HiHope RZ/G2M is advertised as supporting panel idk-1110wr from
> Advantech, but the panel doesn't come with the board, it has to purchased
> separatey, therefore this series adds panel support to a new DT.
>
> v3->v4
> * Included rzg2-advantech-idk-1110wr-panel.dtsi in
> r8a774a1-hihope-rzg2m-ex-idk-1110wr.dts file instead of re-inventing
> the wheel.
> * Dropped the Ack from Laurent for patch 2/2 due to above changes
>
> v2->v3
> * Included Reviewed-by from Rob and Laurent
> * Switched to dual license
> * Added myself as the maintainer
> * Updated copyright year
> * Rebased the patches
>
> v1->v2
> * fixed a space according to Geert's feedback.
>
> Thanks,
> Prabhakar
>
> Fabrizio Castro (2):
> dt-bindings: display: Add idk-1110wr binding
> arm64: dts: renesas: Add HiHope RZ/G2M board with idk-1110wr display
>
> .../display/panel/advantech,idk-1110wr.yaml | 69 ++++++++++++++++++++++
> arch/arm64/boot/dts/renesas/Makefile | 1 +
> .../r8a774a1-hihope-rzg2m-ex-idk-1110wr.dts | 52 ++++++++++++++++
> 3 files changed, 122 insertions(+)
> create mode 100644 Documentation/devicetree/bindings/display/panel/advantech,idk-1110wr.yaml
> create mode 100644 arch/arm64/boot/dts/renesas/r8a774a1-hihope-rzg2m-ex-idk-1110wr.dts
Thanks for the update!
I've queued the second patch in renesas-devel for v5.7.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 5+ messages in thread