linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] ASoC: sh: rz-ssi: Fix wrong operator used issue
@ 2021-08-16 18:23 Biju Das
  2021-08-17 14:22 ` Mark Brown
  0 siblings, 1 reply; 2+ messages in thread
From: Biju Das @ 2021-08-16 18:23 UTC (permalink / raw)
  To: Jaroslav Kysela, Takashi Iwai
  Cc: Biju Das, Liam Girdwood, Mark Brown, Lad Prabhakar, alsa-devel,
	Geert Uytterhoeven, Chris Paterson, Biju Das, linux-renesas-soc

Fix wrong operator used issue reported by Coverity by replacing |
operator with & operator.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reported-by: Colin Ian King <colin.king@canonical.com>
---
 sound/soc/sh/rz-ssi.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/sound/soc/sh/rz-ssi.c b/sound/soc/sh/rz-ssi.c
index 69b45ee2d445..f097c773d413 100644
--- a/sound/soc/sh/rz-ssi.c
+++ b/sound/soc/sh/rz-ssi.c
@@ -368,7 +368,7 @@ static int rz_ssi_stop(struct rz_ssi_priv *ssi, struct rz_ssi_stream *strm)
 	/* Wait for idle */
 	timeout = 100;
 	while (--timeout) {
-		if (rz_ssi_reg_readl(ssi, SSISR) | SSISR_IIRQ)
+		if (rz_ssi_reg_readl(ssi, SSISR) & SSISR_IIRQ)
 			break;
 		udelay(1);
 	}
-- 
2.17.1


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] ASoC: sh: rz-ssi: Fix wrong operator used issue
  2021-08-16 18:23 [PATCH] ASoC: sh: rz-ssi: Fix wrong operator used issue Biju Das
@ 2021-08-17 14:22 ` Mark Brown
  0 siblings, 0 replies; 2+ messages in thread
From: Mark Brown @ 2021-08-17 14:22 UTC (permalink / raw)
  To: Jaroslav Kysela, Biju Das, Takashi Iwai
  Cc: Mark Brown, Liam Girdwood, Lad Prabhakar, Biju Das,
	linux-renesas-soc, Geert Uytterhoeven, alsa-devel,
	Chris Paterson

On Mon, 16 Aug 2021 19:23:36 +0100, Biju Das wrote:
> Fix wrong operator used issue reported by Coverity by replacing |
> operator with & operator.
> 
> 
> 
> 

Applied to

   https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: sh: rz-ssi: Fix wrong operator used issue
      commit: 1b5d1d3a2f77250707225509cadc17997bab4353

All being well this means that it will be integrated into the linux-next
tree (usually sometime in the next 24 hours) and sent to Linus during
the next merge window (or sooner if it is a bug fix), however if
problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing
and review of the tree, please engage with people reporting problems and
send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they
should be sent as incremental updates against current git, existing
patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying
to this mail.

Thanks,
Mark

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2021-08-17 14:23 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-08-16 18:23 [PATCH] ASoC: sh: rz-ssi: Fix wrong operator used issue Biju Das
2021-08-17 14:22 ` Mark Brown

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).