* [PATCH] net: sh_eth: Fix PHY state warning splat during system resume
@ 2022-09-19 14:48 Geert Uytterhoeven
2022-09-19 16:56 ` Florian Fainelli
` (3 more replies)
0 siblings, 4 replies; 5+ messages in thread
From: Geert Uytterhoeven @ 2022-09-19 14:48 UTC (permalink / raw)
To: Sergey Shtylyov, David S . Miller, Eric Dumazet, Jakub Kicinski,
Paolo Abeni, Heiner Kallweit, Florian Fainelli
Cc: netdev, linux-renesas-soc, linux-kernel, Geert Uytterhoeven
Since commit 744d23c71af39c7d ("net: phy: Warn about incorrect
mdio_bus_phy_resume() state"), a warning splat is printed during system
resume with Wake-on-LAN disabled:
WARNING: CPU: 0 PID: 626 at drivers/net/phy/phy_device.c:323 mdio_bus_phy_resume+0xbc/0xe4
As the Renesas SuperH Ethernet driver already calls phy_{stop,start}()
in its suspend/resume callbacks, it is sufficient to just mark the MAC
responsible for managing the power state of the PHY.
Fixes: fba863b816049b03 ("net: phy: make PHY PM ops a no-op if MAC driver manages PHY PM")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/net/ethernet/renesas/sh_eth.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
index 67ade78fb7671c4a..7fd8828d3a846169 100644
--- a/drivers/net/ethernet/renesas/sh_eth.c
+++ b/drivers/net/ethernet/renesas/sh_eth.c
@@ -2029,6 +2029,8 @@ static int sh_eth_phy_init(struct net_device *ndev)
if (mdp->cd->register_type != SH_ETH_REG_GIGABIT)
phy_set_max_speed(phydev, SPEED_100);
+ /* Indicate that the MAC is responsible for managing PHY PM */
+ phydev->mac_managed_pm = true;
phy_attached_info(phydev);
return 0;
--
2.25.1
^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] net: sh_eth: Fix PHY state warning splat during system resume
2022-09-19 14:48 [PATCH] net: sh_eth: Fix PHY state warning splat during system resume Geert Uytterhoeven
@ 2022-09-19 16:56 ` Florian Fainelli
2022-09-19 18:43 ` Sergey Shtylyov
` (2 subsequent siblings)
3 siblings, 0 replies; 5+ messages in thread
From: Florian Fainelli @ 2022-09-19 16:56 UTC (permalink / raw)
To: Geert Uytterhoeven, Sergey Shtylyov, David S . Miller,
Eric Dumazet, Jakub Kicinski, Paolo Abeni, Heiner Kallweit
Cc: netdev, linux-renesas-soc, linux-kernel
On 9/19/22 07:48, Geert Uytterhoeven wrote:
> Since commit 744d23c71af39c7d ("net: phy: Warn about incorrect
> mdio_bus_phy_resume() state"), a warning splat is printed during system
> resume with Wake-on-LAN disabled:
>
> WARNING: CPU: 0 PID: 626 at drivers/net/phy/phy_device.c:323 mdio_bus_phy_resume+0xbc/0xe4
>
> As the Renesas SuperH Ethernet driver already calls phy_{stop,start}()
> in its suspend/resume callbacks, it is sufficient to just mark the MAC
> responsible for managing the power state of the PHY.
>
> Fixes: fba863b816049b03 ("net: phy: make PHY PM ops a no-op if MAC driver manages PHY PM")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Florian Fainelli <f.fainelli@gmail.com>
--
Florian
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: sh_eth: Fix PHY state warning splat during system resume
2022-09-19 14:48 [PATCH] net: sh_eth: Fix PHY state warning splat during system resume Geert Uytterhoeven
2022-09-19 16:56 ` Florian Fainelli
@ 2022-09-19 18:43 ` Sergey Shtylyov
2022-09-19 18:43 ` Sergey Shtylyov
2022-09-21 0:10 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Sergey Shtylyov @ 2022-09-19 18:43 UTC (permalink / raw)
To: Geert Uytterhoeven, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Heiner Kallweit, Florian Fainelli
Cc: netdev, linux-renesas-soc, linux-kernel
On 9/19/22 5:48 PM, Geert Uytterhoeven wrote:
> Since commit 744d23c71af39c7d ("net: phy: Warn about incorrect
> mdio_bus_phy_resume() state"), a warning splat is printed during system
> resume with Wake-on-LAN disabled:
>
> WARNING: CPU: 0 PID: 626 at drivers/net/phy/phy_device.c:323 mdio_bus_phy_resume+0xbc/0xe4
>
> As the Renesas SuperH Ethernet driver already calls phy_{stop,start}()
> in its suspend/resume callbacks, it is sufficient to just mark the MAC
> responsible for managing the power state of the PHY.
>
> Fixes: fba863b816049b03 ("net: phy: make PHY PM ops a no-op if MAC driver manages PHY PM")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index 67ade78fb7671c4a..7fd8828d3a846169 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -2029,6 +2029,8 @@ static int sh_eth_phy_init(struct net_device *ndev)
> if (mdp->cd->register_type != SH_ETH_REG_GIGABIT)
> phy_set_max_speed(phydev, SPEED_100);
>
> + /* Indicate that the MAC is responsible for managing PHY PM */
Again, this field is declared as *unsigned*...
> + phydev->mac_managed_pm = true;
> phy_attached_info(phydev);
[...]
MBR, Sergey
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: sh_eth: Fix PHY state warning splat during system resume
2022-09-19 14:48 [PATCH] net: sh_eth: Fix PHY state warning splat during system resume Geert Uytterhoeven
2022-09-19 16:56 ` Florian Fainelli
2022-09-19 18:43 ` Sergey Shtylyov
@ 2022-09-19 18:43 ` Sergey Shtylyov
2022-09-21 0:10 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: Sergey Shtylyov @ 2022-09-19 18:43 UTC (permalink / raw)
To: Geert Uytterhoeven, David S . Miller, Eric Dumazet,
Jakub Kicinski, Paolo Abeni, Heiner Kallweit, Florian Fainelli
Cc: netdev, linux-renesas-soc, linux-kernel
On 9/19/22 5:48 PM, Geert Uytterhoeven wrote:
> Since commit 744d23c71af39c7d ("net: phy: Warn about incorrect
> mdio_bus_phy_resume() state"), a warning splat is printed during system
> resume with Wake-on-LAN disabled:
>
> WARNING: CPU: 0 PID: 626 at drivers/net/phy/phy_device.c:323 mdio_bus_phy_resume+0xbc/0xe4
>
> As the Renesas SuperH Ethernet driver already calls phy_{stop,start}()
> in its suspend/resume callbacks, it is sufficient to just mark the MAC
> responsible for managing the power state of the PHY.
>
> Fixes: fba863b816049b03 ("net: phy: make PHY PM ops a no-op if MAC driver manages PHY PM")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Sergey Shtylyov <s.shtylyov@omp.ru>
[...]
> diff --git a/drivers/net/ethernet/renesas/sh_eth.c b/drivers/net/ethernet/renesas/sh_eth.c
> index 67ade78fb7671c4a..7fd8828d3a846169 100644
> --- a/drivers/net/ethernet/renesas/sh_eth.c
> +++ b/drivers/net/ethernet/renesas/sh_eth.c
> @@ -2029,6 +2029,8 @@ static int sh_eth_phy_init(struct net_device *ndev)
> if (mdp->cd->register_type != SH_ETH_REG_GIGABIT)
> phy_set_max_speed(phydev, SPEED_100);
>
> + /* Indicate that the MAC is responsible for managing PHY PM */
> + phydev->mac_managed_pm = true;
Again, this field is declared as *unsigned*...
> phy_attached_info(phydev);
[...]
MBR, Sergey
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net: sh_eth: Fix PHY state warning splat during system resume
2022-09-19 14:48 [PATCH] net: sh_eth: Fix PHY state warning splat during system resume Geert Uytterhoeven
` (2 preceding siblings ...)
2022-09-19 18:43 ` Sergey Shtylyov
@ 2022-09-21 0:10 ` patchwork-bot+netdevbpf
3 siblings, 0 replies; 5+ messages in thread
From: patchwork-bot+netdevbpf @ 2022-09-21 0:10 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: s.shtylyov, davem, edumazet, kuba, pabeni, hkallweit1,
f.fainelli, netdev, linux-renesas-soc, linux-kernel
Hello:
This patch was applied to netdev/net.git (master)
by Jakub Kicinski <kuba@kernel.org>:
On Mon, 19 Sep 2022 16:48:28 +0200 you wrote:
> Since commit 744d23c71af39c7d ("net: phy: Warn about incorrect
> mdio_bus_phy_resume() state"), a warning splat is printed during system
> resume with Wake-on-LAN disabled:
>
> WARNING: CPU: 0 PID: 626 at drivers/net/phy/phy_device.c:323 mdio_bus_phy_resume+0xbc/0xe4
>
> As the Renesas SuperH Ethernet driver already calls phy_{stop,start}()
> in its suspend/resume callbacks, it is sufficient to just mark the MAC
> responsible for managing the power state of the PHY.
>
> [...]
Here is the summary with links:
- net: sh_eth: Fix PHY state warning splat during system resume
https://git.kernel.org/netdev/net/c/6a1dbfefdae4
You are awesome, thank you!
--
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-09-21 0:10 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-09-19 14:48 [PATCH] net: sh_eth: Fix PHY state warning splat during system resume Geert Uytterhoeven
2022-09-19 16:56 ` Florian Fainelli
2022-09-19 18:43 ` Sergey Shtylyov
2022-09-19 18:43 ` Sergey Shtylyov
2022-09-21 0:10 ` patchwork-bot+netdevbpf
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).