[PATCH v2] PCI: rcar-host: Remove unused static pcie_base and pcie_dev

[PATCH v2] PCI: rcar-host: Remove unused static pcie_base and pcie_dev

[Geert Uytterhoeven]

After the L1 link state transition exception handler rework, the static
copies of the remapped PCIe controller address and the PCIe device
pointer became unused.  Remove them.

Fixes: 6e36203bc14ce147 ("PCI: rcar: Use PCI_SET_ERROR_RESPONSE after read which triggered an exception")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>
---
Probably this was not noticed before due to two function parameters with
the same name, thus shadowing the static globals.

v2:
  - Add Reviewed-by.
---
 drivers/pci/controller/pcie-rcar-host.c | 21 ---------------------
 1 file changed, 21 deletions(-)

diff --git a/drivers/pci/controller/pcie-rcar-host.c b/drivers/pci/controller/pcie-rcar-host.c
index e80e56b2a84243e5..7ffcd0f5aa45c989 100644
--- a/drivers/pci/controller/pcie-rcar-host.c
+++ b/drivers/pci/controller/pcie-rcar-host.c
@@ -41,21 +41,6 @@ struct rcar_msi {
 	int irq2;
 };
 
-#ifdef CONFIG_ARM
-/*
- * Here we keep a static copy of the remapped PCIe controller address.
- * This is only used on aarch32 systems, all of which have one single
- * PCIe controller, to provide quick access to the PCIe controller in
- * the L1 link state fixup function, called from the ARM fault handler.
- */
-static void __iomem *pcie_base;
-/*
- * Static copy of PCIe device pointer, so we can check whether the
- * device is runtime suspended or not.
- */
-static struct device *pcie_dev;
-#endif
-
 /* Structure representing the PCIe interface */
 struct rcar_pcie_host {
 	struct rcar_pcie	pcie;
@@ -879,12 +864,6 @@ static int rcar_pcie_get_resources(struct rcar_pcie_host *host)
 	}
 	host->msi.irq2 = i;
 
-#ifdef CONFIG_ARM
-	/* Cache static copy for L1 link state fixup hook on aarch32 */
-	pcie_base = pcie->base;
-	pcie_dev = pcie->dev;
-#endif
-
 	return 0;
 
 err_irq2:
-- 
2.34.1

Re: [PATCH v2] PCI: rcar-host: Remove unused static pcie_base and pcie_dev

[Lorenzo Pieralisi]

On Tue, 23 May 2023 17:52:44 +0200, Geert Uytterhoeven wrote:
> After the L1 link state transition exception handler rework, the static
> copies of the remapped PCIe controller address and the PCIe device
> pointer became unused.  Remove them.
> 
> 

Applied to controller/rcar, thanks!

[1/1] PCI: rcar-host: Remove unused static pcie_base and pcie_dev
      https://git.kernel.org/pci/pci/c/56ad9b211069

Thanks,
Lorenzo