Re: [PATCH 11/17] arm64: dts: renesas: r8a774c0: Add USB-DMAC and HSUSB device nodes

[Simon Horman <horms@verge.net.au>]

On Mon, Dec 17, 2018 at 12:17:12PM +0000, Fabrizio Castro wrote:
> Hello Simon,
> 
> Thank you for your feedback!
> 
> > From: Simon Horman <horms@verge.net.au>
> > Sent: 17 December 2018 10:55
> > To: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Subject: Re: [PATCH 11/17] arm64: dts: renesas: r8a774c0: Add USB-DMAC and HSUSB device nodes
> >
> > On Fri, Dec 14, 2018 at 09:37:34AM +0000, Fabrizio Castro wrote:
> > > Add usb dmac and hsusb device nodes on RZ/G2E SoC dtsi.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > ---
> > >  arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 45 +++++++++++++++++++++++++++++++
> > >  1 file changed, 45 insertions(+)
> > >
> > > diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> > > index 0ab3aa6..79cdaac 100644
> > > --- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> > > +++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> > > @@ -514,6 +514,51 @@
> > >  status = "disabled";
> > >  };
> > >
> > > +hsusb: usb@e6590000 {
> > > +compatible = "renesas,usbhs-r8a774c0",
> > > +     "renesas,rcar-gen3-usbhs";
> > > +reg = <0 0xe6590000 0 0x200>;
> >
> > The above looks good but while reviewing this patch I noticed
> > that the size of the hsusb register range on in the DT for r8a774a1
> > is 0x100, Is that correct?
> 
> That is a good catch! No, I don't think it's correct, I'll send a patch to fix that.

Great, thanks!