RE: [PATCH 11/17] arm64: dts: renesas: r8a774c0: Add USB-DMAC and HSUSB device nodes

[Fabrizio Castro <fabrizio.castro@bp.renesas.com>]

Hello Simon,

Thank you for your feedback!

> From: Simon Horman <horms@verge.net.au>
> Sent: 17 December 2018 10:55
> To: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Subject: Re: [PATCH 11/17] arm64: dts: renesas: r8a774c0: Add USB-DMAC and HSUSB device nodes
>
> On Fri, Dec 14, 2018 at 09:37:34AM +0000, Fabrizio Castro wrote:
> > Add usb dmac and hsusb device nodes on RZ/G2E SoC dtsi.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > ---
> >  arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 45 +++++++++++++++++++++++++++++++
> >  1 file changed, 45 insertions(+)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> > index 0ab3aa6..79cdaac 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> > +++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> > @@ -514,6 +514,51 @@
> >  status = "disabled";
> >  };
> >
> > +hsusb: usb@e6590000 {
> > +compatible = "renesas,usbhs-r8a774c0",
> > +     "renesas,rcar-gen3-usbhs";
> > +reg = <0 0xe6590000 0 0x200>;
>
> The above looks good but while reviewing this patch I noticed
> that the size of the hsusb register range on in the DT for r8a774a1
> is 0x100, Is that correct?

That is a good catch! No, I don't think it's correct, I'll send a patch to fix that.

Thanks,
Fab

>
> As for this patch, it looks good to me but I will wait to see if there are
> other reviews before applying.
>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
> > +interrupts = <GIC_SPI 107 IRQ_TYPE_LEVEL_HIGH>;
> > +clocks = <&cpg CPG_MOD 704>, <&cpg CPG_MOD 703>;
> > +dmas = <&usb_dmac0 0>, <&usb_dmac0 1>,
> > +       <&usb_dmac1 0>, <&usb_dmac1 1>;
> > +dma-names = "ch0", "ch1", "ch2", "ch3";
> > +renesas,buswait = <11>;
> > +phys = <&usb2_phy0>;
> > +phy-names = "usb";
> > +power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
> > +resets = <&cpg 704>, <&cpg 703>;
> > +status = "disabled";
> > +};
> > +
> > +usb_dmac0: dma-controller@e65a0000 {
> > +compatible = "renesas,r8a774c0-usb-dmac",
> > +     "renesas,usb-dmac";
> > +reg = <0 0xe65a0000 0 0x100>;
> > +interrupts = <GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH
> > +      GIC_SPI 109 IRQ_TYPE_LEVEL_HIGH>;
> > +interrupt-names = "ch0", "ch1";
> > +clocks = <&cpg CPG_MOD 330>;
> > +power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
> > +resets = <&cpg 330>;
> > +#dma-cells = <1>;
> > +dma-channels = <2>;
> > +};
> > +
> > +usb_dmac1: dma-controller@e65b0000 {
> > +compatible = "renesas,r8a774c0-usb-dmac",
> > +     "renesas,usb-dmac";
> > +reg = <0 0xe65b0000 0 0x100>;
> > +interrupts = <GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH
> > +      GIC_SPI 110 IRQ_TYPE_LEVEL_HIGH>;
> > +interrupt-names = "ch0", "ch1";
> > +clocks = <&cpg CPG_MOD 331>;
> > +power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
> > +resets = <&cpg 331>;
> > +#dma-cells = <1>;
> > +dma-channels = <2>;
> > +};
> > +
> >  dmac0: dma-controller@e6700000 {
> >  compatible = "renesas,dmac-r8a774c0",
> >       "renesas,rcar-dmac";
> > --
> > 2.7.4
> >


[https://www2.renesas.eu/media/email/unicef.jpg]

This Christmas, instead of sending out cards, Renesas Electronics Europe have decided to support Unicef with a donation. For further details click here<https://www.unicef.org/> to find out about the valuable work they do, helping children all over the world.
We would like to take this opportunity to wish you a Merry Christmas and a prosperous New Year.



Renesas Electronics Europe Ltd, Dukes Meadow, Millboard Road, Bourne End, Buckinghamshire, SL8 5FH, UK. Registered in England & Wales under Registered No. 04586709.