linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Will Deacon <will.deacon@arm.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
	Arnd Bergmann <arnd@arndb.de>
Subject: Re: renesas-drivers-2018-12-26-v4.20
Date: Thu, 3 Jan 2019 15:45:10 +0000	[thread overview]
Message-ID: <20190103154510.GH16311@edgewater-inn.cambridge.arm.com> (raw)
In-Reply-To: <CAMuHMdXjXi1dbpk0sOf-qhzJB+uzMVYyyMVHRqv+QSCeNVVgtQ@mail.gmail.com>

On Thu, Dec 27, 2018 at 11:12:25AM +0100, Geert Uytterhoeven wrote:
> Hi Shimoda-san,
> 
> Thanks for the report!
> 
> CC Will (commit author), Arnd (compiler collective).
> 
> On Thu, Dec 27, 2018 at 2:58 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> > > From: Geert Uytterhoeven, Sent: Wednesday, December 26, 2018 8:06 PM
> > > I have pushed renesas-drivers-2018-12-26-v4.20 to
> > > https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git
> > >
> > > This tree is meant to ease development of platform support and drivers
> > > for Renesas ARM SoCs. It is created by merging (a) the for-next branches
> > > of various subsystem trees and (b) branches with driver code submitted
> > > or planned for submission to maintainers into the development branch of
> > > Simon Horman's renesas.git tree.
> > >
> > > Today's version is based on renesas-devel-20181220-v4.20-rc7.
> >
> > I built this version with "gcc version 5.2.1 20151005 (Linaro GCC 5.2-2015.11-1)",
> > and then the following build error happened:
> >
> >   AS      arch/arm64/kernel/head.o
> > /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S: Assembler messages:
> > /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: missing ')'
> > /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: missing ')'
> > /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: missing ')'
> > /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: unexpected characters following instruction at operand 2 -- `mov x2,#(2)|(2U<<(8))'
> >
> > This error seems to cause the commit 66f16a24512f ("arm64: smp: Rework early feature mismatched detection").
> > And if I modified the code as following, the build error disappeared:
> >
> > ---
> > diff --git a/arch/arm64/include/asm/smp.h b/arch/arm64/include/asm/smp.h
> > index 18955618..e9b9cee 100644
> > --- a/arch/arm64/include/asm/smp.h
> > +++ b/arch/arm64/include/asm/smp.h
> > @@ -30,7 +30,7 @@
> >  #define CPU_PANIC_KERNEL               (3)
> >
> >  #define CPU_STUCK_REASON_52_BIT_VA     (1U << CPU_STUCK_REASON_SHIFT)
> > -#define CPU_STUCK_REASON_NO_GRAN       (2U << CPU_STUCK_REASON_SHIFT)
> > +#define CPU_STUCK_REASON_NO_GRAN       (UL(2) << CPU_STUCK_REASON_SHIFT)
> >
> >  #ifndef __ASSEMBLY__
> > ---
> >
> > So, I think we have to fix this, but what do you think?
> > # I don't know why the line 812 doesn't cause the build error,
> > # but the line 824 causes the build error though...

I'm about to queue a flavour of:

http://lists.infradead.org/pipermail/linux-arm-kernel/2018-December/622858.html

to address this.

Cheers,

Will

      reply	other threads:[~2019-01-03 15:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-12-26 11:05 renesas-drivers-2018-12-26-v4.20 Geert Uytterhoeven
2018-12-27  1:58 ` renesas-drivers-2018-12-26-v4.20 Yoshihiro Shimoda
2018-12-27 10:12   ` renesas-drivers-2018-12-26-v4.20 Geert Uytterhoeven
2019-01-03 15:45     ` Will Deacon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190103154510.GH16311@edgewater-inn.cambridge.arm.com \
    --to=will.deacon@arm.com \
    --cc=arnd@arndb.de \
    --cc=geert+renesas@glider.be \
    --cc=geert@linux-m68k.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).