renesas-drivers-2018-12-26-v4.20

renesas-drivers-2018-12-26-v4.20

[Geert Uytterhoeven]

I have pushed renesas-drivers-2018-12-26-v4.20 to
https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git

This tree is meant to ease development of platform support and drivers
for Renesas ARM SoCs. It is created by merging (a) the for-next branches
of various subsystem trees and (b) branches with driver code submitted
or planned for submission to maintainers into the development branch of
Simon Horman's renesas.git tree.

Today's version is based on renesas-devel-20181220-v4.20-rc7.

Included branches with driver code:
  - clk-renesas
  - sh-pfc
  - topic/scif-pio-fallback-v4
  - git://linuxtv.org/pinchartl/media.git#drm-du-iommu-v1-20171115
  - git://linuxtv.org/pinchartl/media.git#drm/du/next
  - git://git.ragnatech.se/linux#for-renesas-drivers
  - git://git.kernel.org/pub/scm/linux/kernel/git/kbingham/rcar.git#gmsl/for-renesas-drivers

Included fixes:
  - [LOCAL] arm64: defconfig: Update renesas_defconfig

Included subsystem trees:
  - git://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git#linux-next
  - git://git.kernel.org/pub/scm/linux/kernel/git/clk/linux.git#clk-next
  - git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-pinctrl.git#for-next
  - git://git.kernel.org/pub/scm/linux/kernel/git/linusw/linux-gpio.git#for-next
  - git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi.git#for-next
  - git://git.infradead.org/users/dedekind/l2-mtd-2.6.git#master
  - git://git.kernel.org/pub/scm/linux/kernel/git/davem/net-next.git#master
  - git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/tty.git#tty-next
  - git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git#i2c/for-next
  - git://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git#for-next
  - git://git.kernel.org/pub/scm/linux/kernel/git/mkl/linux-can-next.git#master
  - git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/usb.git#usb-next
  - git://git.freedesktop.org/git/drm/drm.git#drm-next
  - git://git.kernel.org/pub/scm/linux/kernel/git/joro/iommu.git#next
  - git://linuxtv.org/media_tree.git#master
  - git://git.kernel.org/pub/scm/linux/kernel/git/ulfh/mmc.git#next
  - git://git.kernel.org/pub/scm/linux/kernel/git/thierry.reding/linux-pwm.git#for-next
  - git://git.linaro.org/people/daniel.lezcano/linux.git#clockevents/next
  - git://git.kernel.org/pub/scm/linux/kernel/git/balbi/usb.git#testing/next
  - git://git.infradead.org/users/vkoul/slave-dma.git#next
  - git://git.kernel.org/pub/scm/linux/kernel/git/gregkh/staging.git#staging-next
  - git://git.armlinux.org.uk/~rmk/linux-arm.git#for-next
  - git://git.kernel.org/pub/scm/linux/kernel/git/rzhang/linux.git#next
  - git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regmap.git#for-next
  - git://git.infradead.org/users/jcooper/linux.git#irqchip/for-next
  - git://github.com/bzolnier/linux.git#fbdev-for-next
  - git://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git#for-next
  - git://git.kernel.org/pub/scm/linux/kernel/git/sre/linux-power-supply.git#for-next
  - git://www.linux-watchdog.org/linux-watchdog-next.git#master
  - git://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git#for-next
  - git://git.kernel.org/pub/scm/linux/kernel/git/broonie/regulator.git#for-next
  - git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git#for-next/core
  - git://anongit.freedesktop.org/drm/drm-misc#for-linux-next
  - git://git.kernel.org/pub/scm/linux/kernel/git/helgaas/pci.git#next
  - git://git.kernel.org/pub/scm/linux/kernel/git/kishon/linux-phy.git#next
  - git://git.kernel.org/pub/scm/linux/kernel/git/evalenti/linux-soc-thermal.git#next
  - git://git.kernel.org/pub/scm/linux/kernel/git/lee/mfd.git#for-mfd-next
  - git://git.kernel.org/pub/scm/linux/kernel/git/robh/linux.git#for-next

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

RE: renesas-drivers-2018-12-26-v4.20

[Yoshihiro Shimoda]

Hi Geert-san,

> From: Geert Uytterhoeven, Sent: Wednesday, December 26, 2018 8:06 PM
> 
> I have pushed renesas-drivers-2018-12-26-v4.20 to
> https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git
> 
> This tree is meant to ease development of platform support and drivers
> for Renesas ARM SoCs. It is created by merging (a) the for-next branches
> of various subsystem trees and (b) branches with driver code submitted
> or planned for submission to maintainers into the development branch of
> Simon Horman's renesas.git tree.
> 
> Today's version is based on renesas-devel-20181220-v4.20-rc7.

I built this version with "gcc version 5.2.1 20151005 (Linaro GCC 5.2-2015.11-1)",
and then the following build error happened:

  AS      arch/arm64/kernel/head.o
/home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S: Assembler messages:
/home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: missing ')'
/home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: missing ')'
/home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: missing ')'
/home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: unexpected characters following instruction at operand 2 -- `mov x2,#(2)|(2U<<(8))'

This error seems to cause the commit 66f16a24512f ("arm64: smp: Rework early feature mismatched detection").
And if I modified the code as following, the build error disappeared:

---
diff --git a/arch/arm64/include/asm/smp.h b/arch/arm64/include/asm/smp.h
index 18955618..e9b9cee 100644
--- a/arch/arm64/include/asm/smp.h
+++ b/arch/arm64/include/asm/smp.h
@@ -30,7 +30,7 @@
 #define CPU_PANIC_KERNEL		(3)
 
 #define CPU_STUCK_REASON_52_BIT_VA	(1U << CPU_STUCK_REASON_SHIFT)
-#define CPU_STUCK_REASON_NO_GRAN	(2U << CPU_STUCK_REASON_SHIFT)
+#define CPU_STUCK_REASON_NO_GRAN	(UL(2) << CPU_STUCK_REASON_SHIFT)
 
 #ifndef __ASSEMBLY__
---

So, I think we have to fix this, but what do you think?
# I don't know why the line 812 doesn't cause the build error,
# but the line 824 causes the build error though...

Best regards,
Yoshihiro Shimoda

Re: renesas-drivers-2018-12-26-v4.20

[Geert Uytterhoeven]

Hi Shimoda-san,

Thanks for the report!

CC Will (commit author), Arnd (compiler collective).

On Thu, Dec 27, 2018 at 2:58 AM Yoshihiro Shimoda
<yoshihiro.shimoda.uh@renesas.com> wrote:
> > From: Geert Uytterhoeven, Sent: Wednesday, December 26, 2018 8:06 PM
> > I have pushed renesas-drivers-2018-12-26-v4.20 to
> > https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git
> >
> > This tree is meant to ease development of platform support and drivers
> > for Renesas ARM SoCs. It is created by merging (a) the for-next branches
> > of various subsystem trees and (b) branches with driver code submitted
> > or planned for submission to maintainers into the development branch of
> > Simon Horman's renesas.git tree.
> >
> > Today's version is based on renesas-devel-20181220-v4.20-rc7.
>
> I built this version with "gcc version 5.2.1 20151005 (Linaro GCC 5.2-2015.11-1)",
> and then the following build error happened:
>
>   AS      arch/arm64/kernel/head.o
> /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S: Assembler messages:
> /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: missing ')'
> /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: missing ')'
> /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: missing ')'
> /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: unexpected characters following instruction at operand 2 -- `mov x2,#(2)|(2U<<(8))'
>
> This error seems to cause the commit 66f16a24512f ("arm64: smp: Rework early feature mismatched detection").
> And if I modified the code as following, the build error disappeared:
>
> ---
> diff --git a/arch/arm64/include/asm/smp.h b/arch/arm64/include/asm/smp.h
> index 18955618..e9b9cee 100644
> --- a/arch/arm64/include/asm/smp.h
> +++ b/arch/arm64/include/asm/smp.h
> @@ -30,7 +30,7 @@
>  #define CPU_PANIC_KERNEL               (3)
>
>  #define CPU_STUCK_REASON_52_BIT_VA     (1U << CPU_STUCK_REASON_SHIFT)
> -#define CPU_STUCK_REASON_NO_GRAN       (2U << CPU_STUCK_REASON_SHIFT)
> +#define CPU_STUCK_REASON_NO_GRAN       (UL(2) << CPU_STUCK_REASON_SHIFT)
>
>  #ifndef __ASSEMBLY__
> ---
>
> So, I think we have to fix this, but what do you think?
> # I don't know why the line 812 doesn't cause the build error,
> # but the line 824 causes the build error though...

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: renesas-drivers-2018-12-26-v4.20

[Will Deacon]

On Thu, Dec 27, 2018 at 11:12:25AM +0100, Geert Uytterhoeven wrote:
> Hi Shimoda-san,
> 
> Thanks for the report!
> 
> CC Will (commit author), Arnd (compiler collective).
> 
> On Thu, Dec 27, 2018 at 2:58 AM Yoshihiro Shimoda
> <yoshihiro.shimoda.uh@renesas.com> wrote:
> > > From: Geert Uytterhoeven, Sent: Wednesday, December 26, 2018 8:06 PM
> > > I have pushed renesas-drivers-2018-12-26-v4.20 to
> > > https://git.kernel.org/cgit/linux/kernel/git/geert/renesas-drivers.git
> > >
> > > This tree is meant to ease development of platform support and drivers
> > > for Renesas ARM SoCs. It is created by merging (a) the for-next branches
> > > of various subsystem trees and (b) branches with driver code submitted
> > > or planned for submission to maintainers into the development branch of
> > > Simon Horman's renesas.git tree.
> > >
> > > Today's version is based on renesas-devel-20181220-v4.20-rc7.
> >
> > I built this version with "gcc version 5.2.1 20151005 (Linaro GCC 5.2-2015.11-1)",
> > and then the following build error happened:
> >
> >   AS      arch/arm64/kernel/head.o
> > /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S: Assembler messages:
> > /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: missing ')'
> > /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: missing ')'
> > /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: missing ')'
> > /home/shimoda/development/renesas/renesas-drivers/arch/arm64/kernel/head.S:824: Error: unexpected characters following instruction at operand 2 -- `mov x2,#(2)|(2U<<(8))'
> >
> > This error seems to cause the commit 66f16a24512f ("arm64: smp: Rework early feature mismatched detection").
> > And if I modified the code as following, the build error disappeared:
> >
> > ---
> > diff --git a/arch/arm64/include/asm/smp.h b/arch/arm64/include/asm/smp.h
> > index 18955618..e9b9cee 100644
> > --- a/arch/arm64/include/asm/smp.h
> > +++ b/arch/arm64/include/asm/smp.h
> > @@ -30,7 +30,7 @@
> >  #define CPU_PANIC_KERNEL               (3)
> >
> >  #define CPU_STUCK_REASON_52_BIT_VA     (1U << CPU_STUCK_REASON_SHIFT)
> > -#define CPU_STUCK_REASON_NO_GRAN       (2U << CPU_STUCK_REASON_SHIFT)
> > +#define CPU_STUCK_REASON_NO_GRAN       (UL(2) << CPU_STUCK_REASON_SHIFT)
> >
> >  #ifndef __ASSEMBLY__
> > ---
> >
> > So, I think we have to fix this, but what do you think?
> > # I don't know why the line 812 doesn't cause the build error,
> > # but the line 824 causes the build error though...

I'm about to queue a flavour of:

http://lists.infradead.org/pipermail/linux-arm-kernel/2018-December/622858.html

to address this.

Cheers,

Will