Linux-Renesas-SoC Archive on lore.kernel.org
 help / Atom feed
* [PATCH 0/5] arm64: dts: renesas: Enable DMA for SCIF2 where missing
@ 2019-01-08 13:14 Geert Uytterhoeven
  2019-01-08 13:14 ` [PATCH 1/5] arm64: dts: renesas: r8a774a1: Enable DMA for SCIF2 Geert Uytterhoeven
                   ` (5 more replies)
  0 siblings, 6 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2019-01-08 13:14 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm
  Cc: Fabrizio Castro, Biju Das, linux-renesas-soc, Geert Uytterhoeven

	Hi Simon, Magnus,

R-Car Gen3 Hardware User Manual Rev. 1.50 (finally) documents DMA
support for the SCIF2 serial port on R-Car H3, M3-W, M3-N, E3, and D3
(albeit with the wrong MID/RID, due to a hex-vs-dec mix-up).

This patch series enables DMA for the SCIF2 serial ports on R-Car Gen3
and RZ/G2 SoCs that do not have DMA enabled yet.

This has been tested on R-Car M3-W, M3-N, and E3.

Thanks!

Geert Uytterhoeven (5):
  arm64: dts: renesas: r8a774a1: Enable DMA for SCIF2
  arm64: dts: renesas: r8a774c0: Enable DMA for SCIF2
  arm64: dts: renesas: r8a7796: Enable DMA for SCIF2
  arm64: dts: renesas: r8a77965: Enable DMA for SCIF2
  arm64: dts: renesas: r8a77990: Enable DMA for SCIF2

 arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 3 +++
 arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 3 +++
 arch/arm64/boot/dts/renesas/r8a7796.dtsi  | 3 +++
 arch/arm64/boot/dts/renesas/r8a77965.dtsi | 3 +++
 arch/arm64/boot/dts/renesas/r8a77990.dtsi | 4 +++-
 5 files changed, 15 insertions(+), 1 deletion(-)

-- 
2.17.1

Gr{oetje,eeting}s,

						Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
							    -- Linus Torvalds

^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 1/5] arm64: dts: renesas: r8a774a1: Enable DMA for SCIF2
  2019-01-08 13:14 [PATCH 0/5] arm64: dts: renesas: Enable DMA for SCIF2 where missing Geert Uytterhoeven
@ 2019-01-08 13:14 ` Geert Uytterhoeven
  2019-01-08 13:14 ` [PATCH 2/5] arm64: dts: renesas: r8a774c0: " Geert Uytterhoeven
                   ` (4 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2019-01-08 13:14 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm
  Cc: Fabrizio Castro, Biju Das, linux-renesas-soc, Geert Uytterhoeven

SCIF2 on RZ/G2M can be used with both DMAC1 and DMAC2.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
index 46a8fd20108fbd3a..5cfc9cd6bb2bea8d 100644
--- a/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774a1.dtsi
@@ -1011,6 +1011,9 @@
 				 <&cpg CPG_CORE R8A774A1_CLK_S3D1>,
 				 <&scif_clk>;
 			clock-names = "fck", "brg_int", "scif_clk";
+			dmas = <&dmac1 0x13>, <&dmac1 0x12>,
+			       <&dmac2 0x13>, <&dmac2 0x12>;
+			dma-names = "tx", "rx", "tx", "rx";
 			power-domains = <&sysc R8A774A1_PD_ALWAYS_ON>;
 			resets = <&cpg 310>;
 			status = "disabled";
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 2/5] arm64: dts: renesas: r8a774c0: Enable DMA for SCIF2
  2019-01-08 13:14 [PATCH 0/5] arm64: dts: renesas: Enable DMA for SCIF2 where missing Geert Uytterhoeven
  2019-01-08 13:14 ` [PATCH 1/5] arm64: dts: renesas: r8a774a1: Enable DMA for SCIF2 Geert Uytterhoeven
@ 2019-01-08 13:14 ` " Geert Uytterhoeven
  2019-01-08 13:14 ` [PATCH 3/5] arm64: dts: renesas: r8a7796: " Geert Uytterhoeven
                   ` (3 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2019-01-08 13:14 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm
  Cc: Fabrizio Castro, Biju Das, linux-renesas-soc, Geert Uytterhoeven

SCIF2 on RZ/G2E can be used with both DMAC1 and DMAC2.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
index 3970aafeee1236c0..f2e390f7f1d5b157 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
@@ -941,6 +941,9 @@
 				 <&cpg CPG_CORE R8A774C0_CLK_S3D1C>,
 				 <&scif_clk>;
 			clock-names = "fck", "brg_int", "scif_clk";
+			dmas = <&dmac1 0x13>, <&dmac1 0x12>,
+			       <&dmac2 0x13>, <&dmac2 0x12>;
+			dma-names = "tx", "rx", "tx", "rx";
 			power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
 			resets = <&cpg 310>;
 			status = "disabled";
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 3/5] arm64: dts: renesas: r8a7796: Enable DMA for SCIF2
  2019-01-08 13:14 [PATCH 0/5] arm64: dts: renesas: Enable DMA for SCIF2 where missing Geert Uytterhoeven
  2019-01-08 13:14 ` [PATCH 1/5] arm64: dts: renesas: r8a774a1: Enable DMA for SCIF2 Geert Uytterhoeven
  2019-01-08 13:14 ` [PATCH 2/5] arm64: dts: renesas: r8a774c0: " Geert Uytterhoeven
@ 2019-01-08 13:14 ` " Geert Uytterhoeven
  2019-01-08 13:14 ` [PATCH 4/5] arm64: dts: renesas: r8a77965: " Geert Uytterhoeven
                   ` (2 subsequent siblings)
  5 siblings, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2019-01-08 13:14 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm
  Cc: Fabrizio Castro, Biju Das, linux-renesas-soc, Geert Uytterhoeven

SCIF2 on R-Car M3-W can be used with both DMAC1 and DMAC2.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/renesas/r8a7796.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a7796.dtsi b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
index 3a9f8c7081ca0366..28a4803f0e489723 100644
--- a/arch/arm64/boot/dts/renesas/r8a7796.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a7796.dtsi
@@ -1262,6 +1262,9 @@
 				 <&cpg CPG_CORE R8A7796_CLK_S3D1>,
 				 <&scif_clk>;
 			clock-names = "fck", "brg_int", "scif_clk";
+			dmas = <&dmac1 0x13>, <&dmac1 0x12>,
+			       <&dmac2 0x13>, <&dmac2 0x12>;
+			dma-names = "tx", "rx", "tx", "rx";
 			power-domains = <&sysc R8A7796_PD_ALWAYS_ON>;
 			resets = <&cpg 310>;
 			status = "disabled";
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 4/5] arm64: dts: renesas: r8a77965: Enable DMA for SCIF2
  2019-01-08 13:14 [PATCH 0/5] arm64: dts: renesas: Enable DMA for SCIF2 where missing Geert Uytterhoeven
                   ` (2 preceding siblings ...)
  2019-01-08 13:14 ` [PATCH 3/5] arm64: dts: renesas: r8a7796: " Geert Uytterhoeven
@ 2019-01-08 13:14 ` " Geert Uytterhoeven
  2019-01-08 13:14 ` [PATCH 5/5] arm64: dts: renesas: r8a77990: " Geert Uytterhoeven
  2019-01-08 15:29 ` [PATCH 0/5] arm64: dts: renesas: Enable DMA for SCIF2 where missing Simon Horman
  5 siblings, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2019-01-08 13:14 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm
  Cc: Fabrizio Castro, Biju Das, linux-renesas-soc, Geert Uytterhoeven

SCIF2 on R-Car M3-N can be used with both DMAC1 and DMAC2.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/renesas/r8a77965.dtsi | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a77965.dtsi b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
index 6dc9b1fef8303774..4b3730f640efa78b 100644
--- a/arch/arm64/boot/dts/renesas/r8a77965.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77965.dtsi
@@ -1068,6 +1068,9 @@
 				 <&cpg CPG_CORE R8A77965_CLK_S3D1>,
 				 <&scif_clk>;
 			clock-names = "fck", "brg_int", "scif_clk";
+			dmas = <&dmac1 0x13>, <&dmac1 0x12>,
+			       <&dmac2 0x13>, <&dmac2 0x12>;
+			dma-names = "tx", "rx", "tx", "rx";
 			power-domains = <&sysc R8A77965_PD_ALWAYS_ON>;
 			resets = <&cpg 310>;
 			status = "disabled";
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* [PATCH 5/5] arm64: dts: renesas: r8a77990: Enable DMA for SCIF2
  2019-01-08 13:14 [PATCH 0/5] arm64: dts: renesas: Enable DMA for SCIF2 where missing Geert Uytterhoeven
                   ` (3 preceding siblings ...)
  2019-01-08 13:14 ` [PATCH 4/5] arm64: dts: renesas: r8a77965: " Geert Uytterhoeven
@ 2019-01-08 13:14 ` " Geert Uytterhoeven
  2019-01-08 15:29 ` [PATCH 0/5] arm64: dts: renesas: Enable DMA for SCIF2 where missing Simon Horman
  5 siblings, 0 replies; 7+ messages in thread
From: Geert Uytterhoeven @ 2019-01-08 13:14 UTC (permalink / raw)
  To: Simon Horman, Magnus Damm
  Cc: Fabrizio Castro, Biju Das, linux-renesas-soc, Geert Uytterhoeven

SCIF2 on R-Car E3 can be used with both DMAC1 and DMAC2.

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
 arch/arm64/boot/dts/renesas/r8a77990.dtsi | 4 +++-
 1 file changed, 3 insertions(+), 1 deletion(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a77990.dtsi b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
index 84bbe70cb0abfc88..786178cf1ffd1304 100644
--- a/arch/arm64/boot/dts/renesas/r8a77990.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a77990.dtsi
@@ -993,7 +993,9 @@
 				 <&cpg CPG_CORE R8A77990_CLK_S3D1C>,
 				 <&scif_clk>;
 			clock-names = "fck", "brg_int", "scif_clk";
-
+			dmas = <&dmac1 0x13>, <&dmac1 0x12>,
+			       <&dmac2 0x13>, <&dmac2 0x12>;
+			dma-names = "tx", "rx", "tx", "rx";
 			power-domains = <&sysc R8A77990_PD_ALWAYS_ON>;
 			resets = <&cpg 310>;
 			status = "disabled";
-- 
2.17.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

* Re: [PATCH 0/5] arm64: dts: renesas: Enable DMA for SCIF2 where missing
  2019-01-08 13:14 [PATCH 0/5] arm64: dts: renesas: Enable DMA for SCIF2 where missing Geert Uytterhoeven
                   ` (4 preceding siblings ...)
  2019-01-08 13:14 ` [PATCH 5/5] arm64: dts: renesas: r8a77990: " Geert Uytterhoeven
@ 2019-01-08 15:29 ` Simon Horman
  5 siblings, 0 replies; 7+ messages in thread
From: Simon Horman @ 2019-01-08 15:29 UTC (permalink / raw)
  To: Geert Uytterhoeven
  Cc: Magnus Damm, Fabrizio Castro, Biju Das, linux-renesas-soc

On Tue, Jan 08, 2019 at 02:14:47PM +0100, Geert Uytterhoeven wrote:
> 	Hi Simon, Magnus,
> 
> R-Car Gen3 Hardware User Manual Rev. 1.50 (finally) documents DMA
> support for the SCIF2 serial port on R-Car H3, M3-W, M3-N, E3, and D3
> (albeit with the wrong MID/RID, due to a hex-vs-dec mix-up).
> 
> This patch series enables DMA for the SCIF2 serial ports on R-Car Gen3
> and RZ/G2 SoCs that do not have DMA enabled yet.
> 
> This has been tested on R-Car M3-W, M3-N, and E3.

Are we sure these values are also valid on RZ/G2?
Could you consider squashing this series into fewer patches - say one?

> 
> Thanks!
> 
> Geert Uytterhoeven (5):
>   arm64: dts: renesas: r8a774a1: Enable DMA for SCIF2
>   arm64: dts: renesas: r8a774c0: Enable DMA for SCIF2
>   arm64: dts: renesas: r8a7796: Enable DMA for SCIF2
>   arm64: dts: renesas: r8a77965: Enable DMA for SCIF2
>   arm64: dts: renesas: r8a77990: Enable DMA for SCIF2
> 
>  arch/arm64/boot/dts/renesas/r8a774a1.dtsi | 3 +++
>  arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 3 +++
>  arch/arm64/boot/dts/renesas/r8a7796.dtsi  | 3 +++
>  arch/arm64/boot/dts/renesas/r8a77965.dtsi | 3 +++
>  arch/arm64/boot/dts/renesas/r8a77990.dtsi | 4 +++-
>  5 files changed, 15 insertions(+), 1 deletion(-)
> 
> -- 
> 2.17.1
> 
> Gr{oetje,eeting}s,
> 
> 						Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
> 
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> 							    -- Linus Torvalds
> 

^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-01-08 13:14 [PATCH 0/5] arm64: dts: renesas: Enable DMA for SCIF2 where missing Geert Uytterhoeven
2019-01-08 13:14 ` [PATCH 1/5] arm64: dts: renesas: r8a774a1: Enable DMA for SCIF2 Geert Uytterhoeven
2019-01-08 13:14 ` [PATCH 2/5] arm64: dts: renesas: r8a774c0: " Geert Uytterhoeven
2019-01-08 13:14 ` [PATCH 3/5] arm64: dts: renesas: r8a7796: " Geert Uytterhoeven
2019-01-08 13:14 ` [PATCH 4/5] arm64: dts: renesas: r8a77965: " Geert Uytterhoeven
2019-01-08 13:14 ` [PATCH 5/5] arm64: dts: renesas: r8a77990: " Geert Uytterhoeven
2019-01-08 15:29 ` [PATCH 0/5] arm64: dts: renesas: Enable DMA for SCIF2 where missing Simon Horman

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org linux-renesas-soc@archiver.kernel.org
	public-inbox-index linux-renesas-soc


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox