From: Simon Horman <horms@verge.net.au>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/3] i2c: algo-bit: convert to SPDX header
Date: Wed, 23 Jan 2019 11:20:56 +0100 [thread overview]
Message-ID: <20190123102055.ric3gpjq6nabydth@verge.net.au> (raw)
In-Reply-To: <20190119121655.5576-3-wsa+renesas@sang-engineering.com>
On Sat, Jan 19, 2019 at 01:16:54PM +0100, Wolfram Sang wrote:
> And use kernel style for the remaining comments in the header.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/i2c/algos/i2c-algo-bit.c | 25 ++++++++-----------------
> include/linux/i2c-algo-bit.h | 31 ++++++++-----------------------
> 2 files changed, 16 insertions(+), 40 deletions(-)
>
> diff --git a/drivers/i2c/algos/i2c-algo-bit.c b/drivers/i2c/algos/i2c-algo-bit.c
> index c33dcfb87993..5e5990a83da5 100644
> --- a/drivers/i2c/algos/i2c-algo-bit.c
> +++ b/drivers/i2c/algos/i2c-algo-bit.c
> @@ -1,21 +1,12 @@
> -/* -------------------------------------------------------------------------
> - * i2c-algo-bit.c i2c driver algorithms for bit-shift adapters
> - * -------------------------------------------------------------------------
> +// SPDX-License-Identifier: GPL-2.0+
> +/*
> + * i2c-algo-bit.c: i2c driver algorithms for bit-shift adapters
> + *
> * Copyright (C) 1995-2000 Simon G. Vogl
> -
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License as published by
> - the Free Software Foundation; either version 2 of the License, or
> - (at your option) any later version.
> -
> - This program is distributed in the hope that it will be useful,
> - but WITHOUT ANY WARRANTY; without even the implied warranty of
> - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - GNU General Public License for more details.
> - * ------------------------------------------------------------------------- */
> -
> -/* With some changes from Frodo Looijaard <frodol@dds.nl>, Kyösti Mälkki
> - <kmalkki@cc.hut.fi> and Jean Delvare <jdelvare@suse.de> */
> + *
> + * With some changes from Frodo Looijaard <frodol@dds.nl>, Kyösti Mälkki
> + * <kmalkki@cc.hut.fi> and Jean Delvare <jdelvare@suse.de>
> + */
>
> #include <linux/kernel.h>
> #include <linux/module.h>
> diff --git a/include/linux/i2c-algo-bit.h b/include/linux/i2c-algo-bit.h
> index d64cebc6e65a..69045df78e2d 100644
> --- a/include/linux/i2c-algo-bit.h
> +++ b/include/linux/i2c-algo-bit.h
> @@ -1,26 +1,11 @@
> -/* ------------------------------------------------------------------------- */
> -/* i2c-algo-bit.h i2c driver algorithms for bit-shift adapters */
> -/* ------------------------------------------------------------------------- */
> -/* Copyright (C) 1995-99 Simon G. Vogl
> -
> - This program is free software; you can redistribute it and/or modify
> - it under the terms of the GNU General Public License as published by
> - the Free Software Foundation; either version 2 of the License, or
> - (at your option) any later version.
> -
> - This program is distributed in the hope that it will be useful,
> - but WITHOUT ANY WARRANTY; without even the implied warranty of
> - MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
> - GNU General Public License for more details.
> -
> - You should have received a copy of the GNU General Public License
> - along with this program; if not, write to the Free Software
> - Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston,
> - MA 02110-1301 USA. */
> -/* ------------------------------------------------------------------------- */
> -
> -/* With some changes from Kyösti Mälkki <kmalkki@cc.hut.fi> and even
> - Frodo Looijaard <frodol@dds.nl> */
> +/* SPDX-License-Identifier: GPL-2.0+ */
> +/*
> + * i2c-algo-bit.h: i2c driver algorithms for bit-shift adapters
> + *
> + * Copyright (C) 1995-99 Simon G. Vogl
> + * With some changes from Kyösti Mälkki <kmalkki@cc.hut.fi> and even
> + * Frodo Looijaard <frodol@dds.nl>
> + */
>
> #ifndef _LINUX_I2C_ALGO_BIT_H
> #define _LINUX_I2C_ALGO_BIT_H
> --
> 2.11.0
>
next prev parent reply other threads:[~2019-01-23 10:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-19 12:16 [PATCH 0/3] i2c: gpio/algo-bit: clean up headers Wolfram Sang
2019-01-19 12:16 ` [PATCH 1/3] i2c: algo-bit: include main i2c header Wolfram Sang
2019-01-23 10:23 ` Simon Horman
2019-01-19 12:16 ` [PATCH 2/3] i2c: algo-bit: convert to SPDX header Wolfram Sang
2019-01-23 10:20 ` Simon Horman [this message]
2019-01-19 12:16 ` [PATCH 3/3] i2c: gpio: sort includes Wolfram Sang
2019-01-23 10:22 ` Simon Horman
2019-02-05 13:04 ` [PATCH 0/3] i2c: gpio/algo-bit: clean up headers Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123102055.ric3gpjq6nabydth@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).