From: Simon Horman <horms@verge.net.au>
To: Wolfram Sang <wsa+renesas@sang-engineering.com>
Cc: linux-i2c@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 3/3] i2c: gpio: sort includes
Date: Wed, 23 Jan 2019 11:22:26 +0100 [thread overview]
Message-ID: <20190123102226.tmxybjroig4bplzq@verge.net.au> (raw)
In-Reply-To: <20190119121655.5576-4-wsa+renesas@sang-engineering.com>
On Sat, Jan 19, 2019 at 01:16:55PM +0100, Wolfram Sang wrote:
> Less risk for duplications when adding new ones.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> drivers/i2c/busses/i2c-gpio.c | 10 +++++-----
> 1 file changed, 5 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/i2c/busses/i2c-gpio.c b/drivers/i2c/busses/i2c-gpio.c
> index b9d43bc2853f..d8205b56f243 100644
> --- a/drivers/i2c/busses/i2c-gpio.c
> +++ b/drivers/i2c/busses/i2c-gpio.c
> @@ -9,15 +9,15 @@
> */
> #include <linux/debugfs.h>
> #include <linux/delay.h>
> -#include <linux/i2c.h>
> +#include <linux/gpio/consumer.h>
> #include <linux/i2c-algo-bit.h>
> -#include <linux/platform_data/i2c-gpio.h>
> +#include <linux/i2c.h>
> #include <linux/init.h>
> #include <linux/module.h>
> -#include <linux/slab.h>
> -#include <linux/platform_device.h>
> -#include <linux/gpio/consumer.h>
> #include <linux/of.h>
> +#include <linux/platform_data/i2c-gpio.h>
> +#include <linux/platform_device.h>
> +#include <linux/slab.h>
>
> struct i2c_gpio_private_data {
> struct gpio_desc *sda;
> --
> 2.11.0
>
next prev parent reply other threads:[~2019-01-23 10:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-01-19 12:16 [PATCH 0/3] i2c: gpio/algo-bit: clean up headers Wolfram Sang
2019-01-19 12:16 ` [PATCH 1/3] i2c: algo-bit: include main i2c header Wolfram Sang
2019-01-23 10:23 ` Simon Horman
2019-01-19 12:16 ` [PATCH 2/3] i2c: algo-bit: convert to SPDX header Wolfram Sang
2019-01-23 10:20 ` Simon Horman
2019-01-19 12:16 ` [PATCH 3/3] i2c: gpio: sort includes Wolfram Sang
2019-01-23 10:22 ` Simon Horman [this message]
2019-02-05 13:04 ` [PATCH 0/3] i2c: gpio/algo-bit: clean up headers Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190123102226.tmxybjroig4bplzq@verge.net.au \
--to=horms@verge.net.au \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=wsa+renesas@sang-engineering.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).