linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Marek Vasut <marek.vasut@gmail.com>
Cc: Wolfram Sang <wsa+renesas@sang-engineering.com>,
	linux-mmc@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
	Yoshihiro Shimoda <yoshihiro.shimoda.uh@renesas.com>,
	Takeshi Saito <takeshi.saito.xv@renesas.com>
Subject: Re: [PATCH] mmc: renesas_sdhi: Change HW adjustment register according to speed mode
Date: Wed, 13 Feb 2019 10:22:10 +0100	[thread overview]
Message-ID: <20190213092210.GG31044@bigcity.dyn.berto.se> (raw)
In-Reply-To: <d6d064f2-fa58-d31e-83b8-1cc3ffbc7dee@gmail.com>

Hi Marek,

On 2019-02-10 17:39:34 +0100, Marek Vasut wrote:
> On 2/10/19 2:39 PM, Niklas Söderlund wrote:
> > Hi Wolfram,
> 
> Hi,
> 
> > Thanks for your patch.
> > 
> > On 2019-02-08 20:30:02 +0100, Wolfram Sang wrote:
> >> From: Takeshi Saito <takeshi.saito.xv@renesas.com>
> >>
> >> SCC is used for SDR104/HS200/HS400. We need to change SCC_DT2FF
> >> according to the mode. If it is inappropriate, CRC error tends to occur.
> >>
> >> This adds variable "tap_hs400" for HS400 mode and configures SCC_DT2FF
> >> as needed.
> >>
> >> Signed-off-by: Takeshi Saito <takeshi.saito.xv@renesas.com>
> >> [wsa: rebased to upstream and updated commit message]
> >> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
> > 
> > I think this looks good.
> > 
> > Reviewed-by: Niklas Söderlund <niklas.soderlund@ragnatech.se>
> Can you test this on E3 Ebisu (do you have a board) ?

I do not have a E3 so I'm afraid I can not provide a tested by tag for 
that board.

-- 
Regards,
Niklas Söderlund

  reply	other threads:[~2019-02-13  9:22 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-02-08 19:30 [PATCH] mmc: renesas_sdhi: Change HW adjustment register according to speed mode Wolfram Sang
2019-02-10 13:39 ` Niklas Söderlund
2019-02-10 16:39   ` Marek Vasut
2019-02-13  9:22     ` Niklas Söderlund [this message]
2019-02-14 12:46       ` Simon Horman
2019-02-14 15:25         ` Marek Vasut
2019-02-14 15:53         ` Wolfram Sang
2019-02-26  8:18 ` Ulf Hansson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190213092210.GG31044@bigcity.dyn.berto.se \
    --to=niklas.soderlund@ragnatech.se \
    --cc=linux-mmc@vger.kernel.org \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=marek.vasut@gmail.com \
    --cc=takeshi.saito.xv@renesas.com \
    --cc=wsa+renesas@sang-engineering.com \
    --cc=yoshihiro.shimoda.uh@renesas.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).