* [PATCH/RFT] arm64: dts: renesas: r8a77995: draak: Fix EthernetAVB phy mode to rgmii
@ 2019-02-13 10:32 Simon Horman
2019-03-05 12:06 ` Ulrich Hecht
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2019-02-13 10:32 UTC (permalink / raw)
To: linux-renesas-soc
Cc: linux-arm-kernel, Magnus Damm, Kazuya Mizuguchi, Takeshi Kihara,
Simon Horman
From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
According to the R-Car Gen3 Hardware Manual Errata for Rev 1.00 of
August 24, 2018, the TX clock internal Delay mode does'nt support
on R-Car D3. This patch fixes EthernetAVB phy mode to rgmii.
This is achieved by simply dropping the phy-mode property from
r8a77995-draak.dts as the default property for this for r8a77995,
as set in r8a77995.dtsi, is "rgmii".
Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
---
arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
index db2bed1751b8..bfa260c9f78c 100644
--- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
+++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
@@ -168,7 +168,6 @@
pinctrl-names = "default";
renesas,no-ether-link;
phy-handle = <&phy0>;
- phy-mode = "rgmii-txid";
status = "okay";
phy0: ethernet-phy@0 {
--
2.11.0
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH/RFT] arm64: dts: renesas: r8a77995: draak: Fix EthernetAVB phy mode to rgmii
2019-02-13 10:32 [PATCH/RFT] arm64: dts: renesas: r8a77995: draak: Fix EthernetAVB phy mode to rgmii Simon Horman
@ 2019-03-05 12:06 ` Ulrich Hecht
2019-03-25 10:53 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Ulrich Hecht @ 2019-03-05 12:06 UTC (permalink / raw)
To: Simon Horman, linux-renesas-soc
Cc: linux-arm-kernel, Magnus Damm, Kazuya Mizuguchi, Takeshi Kihara
> On February 13, 2019 at 11:32 AM Simon Horman <horms+renesas@verge.net.au> wrote:
>
>
> From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
>
> According to the R-Car Gen3 Hardware Manual Errata for Rev 1.00 of
> August 24, 2018, the TX clock internal Delay mode does'nt support
> on R-Car D3. This patch fixes EthernetAVB phy mode to rgmii.
>
> This is achieved by simply dropping the phy-mode property from
> r8a77995-draak.dts as the default property for this for r8a77995,
> as set in r8a77995.dtsi, is "rgmii".
>
> Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> ---
> arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> index db2bed1751b8..bfa260c9f78c 100644
> --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> @@ -168,7 +168,6 @@
> pinctrl-names = "default";
> renesas,no-ether-link;
> phy-handle = <&phy0>;
> - phy-mode = "rgmii-txid";
> status = "okay";
>
> phy0: ethernet-phy@0 {
> --
> 2.11.0
>
Works for me.
Tested-by: Ulrich Hecht <uli+renesas@fpond.eu>
CU
Uli
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH/RFT] arm64: dts: renesas: r8a77995: draak: Fix EthernetAVB phy mode to rgmii
2019-03-05 12:06 ` Ulrich Hecht
@ 2019-03-25 10:53 ` Simon Horman
0 siblings, 0 replies; 3+ messages in thread
From: Simon Horman @ 2019-03-25 10:53 UTC (permalink / raw)
To: Ulrich Hecht
Cc: linux-renesas-soc, linux-arm-kernel, Magnus Damm,
Kazuya Mizuguchi, Takeshi Kihara
On Tue, Mar 05, 2019 at 01:06:52PM +0100, Ulrich Hecht wrote:
>
> > On February 13, 2019 at 11:32 AM Simon Horman <horms+renesas@verge.net.au> wrote:
> >
> >
> > From: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> >
> > According to the R-Car Gen3 Hardware Manual Errata for Rev 1.00 of
> > August 24, 2018, the TX clock internal Delay mode does'nt support
> > on R-Car D3. This patch fixes EthernetAVB phy mode to rgmii.
> >
> > This is achieved by simply dropping the phy-mode property from
> > r8a77995-draak.dts as the default property for this for r8a77995,
> > as set in r8a77995.dtsi, is "rgmii".
> >
> > Signed-off-by: Kazuya Mizuguchi <kazuya.mizuguchi.ks@renesas.com>
> > Signed-off-by: Takeshi Kihara <takeshi.kihara.df@renesas.com>
> > Signed-off-by: Simon Horman <horms+renesas@verge.net.au>
> > ---
> > arch/arm64/boot/dts/renesas/r8a77995-draak.dts | 1 -
> > 1 file changed, 1 deletion(-)
> >
> > diff --git a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > index db2bed1751b8..bfa260c9f78c 100644
> > --- a/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > +++ b/arch/arm64/boot/dts/renesas/r8a77995-draak.dts
> > @@ -168,7 +168,6 @@
> > pinctrl-names = "default";
> > renesas,no-ether-link;
> > phy-handle = <&phy0>;
> > - phy-mode = "rgmii-txid";
> > status = "okay";
> >
> > phy0: ethernet-phy@0 {
> > --
> > 2.11.0
> >
>
> Works for me.
>
> Tested-by: Ulrich Hecht <uli+renesas@fpond.eu>
Thanks, applied for v5.2.
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-25 10:53 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-13 10:32 [PATCH/RFT] arm64: dts: renesas: r8a77995: draak: Fix EthernetAVB phy mode to rgmii Simon Horman
2019-03-05 12:06 ` Ulrich Hecht
2019-03-25 10:53 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).