* [PATCH] clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK
@ 2019-02-22 11:59 Fabrizio Castro
2019-02-22 12:01 ` Chris Paterson
2019-02-25 17:13 ` Stephen Boyd
0 siblings, 2 replies; 8+ messages in thread
From: Fabrizio Castro @ 2019-02-22 11:59 UTC (permalink / raw)
To: Geert Uytterhoeven, Michael Turquette, Stephen Boyd
Cc: Fabrizio Castro, linux-renesas-soc, linux-clk, Simon Horman,
Chris Paterson, Biju Das
Enum LAST_DT_CORE_CLK needs updating as R8A774A1_CLK_CANFD
was recently added and it's the core clock with the highest
index.
Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
---
drivers/clk/renesas/r8a774a1-cpg-mssr.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/clk/renesas/r8a774a1-cpg-mssr.c b/drivers/clk/renesas/r8a774a1-cpg-mssr.c
index 5fcd6c5..8e7bb43 100644
--- a/drivers/clk/renesas/r8a774a1-cpg-mssr.c
+++ b/drivers/clk/renesas/r8a774a1-cpg-mssr.c
@@ -21,7 +21,7 @@
enum clk_ids {
/* Core Clock Outputs exported to DT */
- LAST_DT_CORE_CLK = R8A774A1_CLK_OSC,
+ LAST_DT_CORE_CLK = R8A774A1_CLK_CANFD,
/* External Input Clocks */
CLK_EXTAL,
--
2.7.4
^ permalink raw reply related [flat|nested] 8+ messages in thread* RE: [PATCH] clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK
2019-02-22 11:59 [PATCH] clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK Fabrizio Castro
@ 2019-02-22 12:01 ` Chris Paterson
2019-02-25 9:27 ` Simon Horman
2019-02-25 17:13 ` Stephen Boyd
1 sibling, 1 reply; 8+ messages in thread
From: Chris Paterson @ 2019-02-22 12:01 UTC (permalink / raw)
To: Fabrizio Castro, Geert Uytterhoeven, Michael Turquette, Stephen Boyd
Cc: Fabrizio Castro, linux-renesas-soc, linux-clk, Simon Horman, Biju Das
> From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Sent: 22 February 2019 12:00
>
> Enum LAST_DT_CORE_CLK needs updating as R8A774A1_CLK_CANFD
> was recently added and it's the core clock with the highest
> index.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> ---
> drivers/clk/renesas/r8a774a1-cpg-mssr.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/clk/renesas/r8a774a1-cpg-mssr.c
> b/drivers/clk/renesas/r8a774a1-cpg-mssr.c
> index 5fcd6c5..8e7bb43 100644
> --- a/drivers/clk/renesas/r8a774a1-cpg-mssr.c
> +++ b/drivers/clk/renesas/r8a774a1-cpg-mssr.c
> @@ -21,7 +21,7 @@
>
> enum clk_ids {
> /* Core Clock Outputs exported to DT */
> - LAST_DT_CORE_CLK = R8A774A1_CLK_OSC,
> + LAST_DT_CORE_CLK = R8A774A1_CLK_CANFD,
>
> /* External Input Clocks */
> CLK_EXTAL,
> --
> 2.7.4
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK
2019-02-22 12:01 ` Chris Paterson
@ 2019-02-25 9:27 ` Simon Horman
2019-02-25 9:32 ` Geert Uytterhoeven
2019-02-25 9:44 ` Fabrizio Castro
0 siblings, 2 replies; 8+ messages in thread
From: Simon Horman @ 2019-02-25 9:27 UTC (permalink / raw)
To: Chris Paterson
Cc: Fabrizio Castro, Geert Uytterhoeven, Michael Turquette,
Stephen Boyd, linux-renesas-soc, linux-clk, Biju Das
On Fri, Feb 22, 2019 at 12:01:21PM +0000, Chris Paterson wrote:
>
> > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Sent: 22 February 2019 12:00
> >
> > Enum LAST_DT_CORE_CLK needs updating as R8A774A1_CLK_CANFD
> > was recently added and it's the core clock with the highest
> > index.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
I think this needs:
Fixes: 9d034e151b40 ("clk: renesas: r8a774a1: Add missing CANFD clock")
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
> > ---
> > drivers/clk/renesas/r8a774a1-cpg-mssr.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/clk/renesas/r8a774a1-cpg-mssr.c
> > b/drivers/clk/renesas/r8a774a1-cpg-mssr.c
> > index 5fcd6c5..8e7bb43 100644
> > --- a/drivers/clk/renesas/r8a774a1-cpg-mssr.c
> > +++ b/drivers/clk/renesas/r8a774a1-cpg-mssr.c
> > @@ -21,7 +21,7 @@
> >
> > enum clk_ids {
> > /* Core Clock Outputs exported to DT */
> > - LAST_DT_CORE_CLK = R8A774A1_CLK_OSC,
> > + LAST_DT_CORE_CLK = R8A774A1_CLK_CANFD,
> >
> > /* External Input Clocks */
> > CLK_EXTAL,
> > --
> > 2.7.4
>
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK
2019-02-25 9:27 ` Simon Horman
@ 2019-02-25 9:32 ` Geert Uytterhoeven
2019-02-25 9:44 ` Fabrizio Castro
1 sibling, 0 replies; 8+ messages in thread
From: Geert Uytterhoeven @ 2019-02-25 9:32 UTC (permalink / raw)
To: Fabrizio Castro, Michael Turquette, Stephen Boyd
Cc: Chris Paterson, linux-renesas-soc, linux-clk, Biju Das, Simon Horman
On Mon, Feb 25, 2019 at 10:27 AM Simon Horman <horms@verge.net.au> wrote:
> On Fri, Feb 22, 2019 at 12:01:21PM +0000, Chris Paterson wrote:
> > > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Sent: 22 February 2019 12:00
> > >
> > > Enum LAST_DT_CORE_CLK needs updating as R8A774A1_CLK_CANFD
> > > was recently added and it's the core clock with the highest
> > > index.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
>
> I think this needs:
>
> Fixes: 9d034e151b40 ("clk: renesas: r8a774a1: Add missing CANFD clock")
Exactly.
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Mike/Stephen: can you please take this one directly, as it is a fix for
clk-next?
Thanks!
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread* RE: [PATCH] clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK
2019-02-25 9:27 ` Simon Horman
2019-02-25 9:32 ` Geert Uytterhoeven
@ 2019-02-25 9:44 ` Fabrizio Castro
2019-02-25 9:47 ` Geert Uytterhoeven
1 sibling, 1 reply; 8+ messages in thread
From: Fabrizio Castro @ 2019-02-25 9:44 UTC (permalink / raw)
To: Simon Horman, Geert Uytterhoeven
Cc: Michael Turquette, Stephen Boyd, linux-renesas-soc, linux-clk,
Biju Das, Chris Paterson
Hello Simon, Geert
Thank you for your feedback!
> From: Simon Horman <horms@verge.net.au>
> Sent: 25 February 2019 09:27
> Subject: Re: [PATCH] clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK
>
> On Fri, Feb 22, 2019 at 12:01:21PM +0000, Chris Paterson wrote:
> >
> > > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Sent: 22 February 2019 12:00
> > >
> > > Enum LAST_DT_CORE_CLK needs updating as R8A774A1_CLK_CANFD
> > > was recently added and it's the core clock with the highest
> > > index.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
>
> I think this needs:
>
> Fixes: 9d034e151b40 ("clk: renesas: r8a774a1: Add missing CANFD clock")
I naively thought I could only refer to commits from Torvald's, which is clearly wrong,
therefore thank you for fixing.
Cheers,
Fab
>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
> >
> > > ---
> > > drivers/clk/renesas/r8a774a1-cpg-mssr.c | 2 +-
> > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > >
> > > diff --git a/drivers/clk/renesas/r8a774a1-cpg-mssr.c
> > > b/drivers/clk/renesas/r8a774a1-cpg-mssr.c
> > > index 5fcd6c5..8e7bb43 100644
> > > --- a/drivers/clk/renesas/r8a774a1-cpg-mssr.c
> > > +++ b/drivers/clk/renesas/r8a774a1-cpg-mssr.c
> > > @@ -21,7 +21,7 @@
> > >
> > > enum clk_ids {
> > > /* Core Clock Outputs exported to DT */
> > > - LAST_DT_CORE_CLK = R8A774A1_CLK_OSC,
> > > + LAST_DT_CORE_CLK = R8A774A1_CLK_CANFD,
> > >
> > > /* External Input Clocks */
> > > CLK_EXTAL,
> > > --
> > > 2.7.4
> >
^ permalink raw reply [flat|nested] 8+ messages in thread* Re: [PATCH] clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK
2019-02-25 9:44 ` Fabrizio Castro
@ 2019-02-25 9:47 ` Geert Uytterhoeven
2019-02-25 9:49 ` Fabrizio Castro
0 siblings, 1 reply; 8+ messages in thread
From: Geert Uytterhoeven @ 2019-02-25 9:47 UTC (permalink / raw)
To: Fabrizio Castro
Cc: Simon Horman, Geert Uytterhoeven, Michael Turquette,
Stephen Boyd, linux-renesas-soc, linux-clk, Biju Das,
Chris Paterson
Hi Fabrizio,
On Mon, Feb 25, 2019 at 10:44 AM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> > From: Simon Horman <horms@verge.net.au>
> > Sent: 25 February 2019 09:27
> > Subject: Re: [PATCH] clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK
> >
> > On Fri, Feb 22, 2019 at 12:01:21PM +0000, Chris Paterson wrote:
> > >
> > > > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > Sent: 22 February 2019 12:00
> > > >
> > > > Enum LAST_DT_CORE_CLK needs updating as R8A774A1_CLK_CANFD
> > > > was recently added and it's the core clock with the highest
> > > > index.
> > > >
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> >
> > I think this needs:
> >
> > Fixes: 9d034e151b40 ("clk: renesas: r8a774a1: Add missing CANFD clock")
>
> I naively thought I could only refer to commits from Torvald's, which is clearly wrong,
> therefore thank you for fixing.
FTR: You can refer to any commits in linux-next that are considered stable,
i.e. on branches that are never rebased.
This includes all for-next branches of maintainers who accept pull requests.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread* RE: [PATCH] clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK
2019-02-25 9:47 ` Geert Uytterhoeven
@ 2019-02-25 9:49 ` Fabrizio Castro
0 siblings, 0 replies; 8+ messages in thread
From: Fabrizio Castro @ 2019-02-25 9:49 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Simon Horman, Geert Uytterhoeven, Michael Turquette,
Stephen Boyd, linux-renesas-soc, linux-clk, Biju Das,
Chris Paterson
Hello Geert,
> From: linux-renesas-soc-owner@vger.kernel.org <linux-renesas-soc-owner@vger.kernel.org> On Behalf Of Geert Uytterhoeven
> Sent: 25 February 2019 09:48
> Subject: Re: [PATCH] clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK
>
> Hi Fabrizio,
>
> On Mon, Feb 25, 2019 at 10:44 AM Fabrizio Castro
> <fabrizio.castro@bp.renesas.com> wrote:
> > > From: Simon Horman <horms@verge.net.au>
> > > Sent: 25 February 2019 09:27
> > > Subject: Re: [PATCH] clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK
> > >
> > > On Fri, Feb 22, 2019 at 12:01:21PM +0000, Chris Paterson wrote:
> > > >
> > > > > From: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > > Sent: 22 February 2019 12:00
> > > > >
> > > > > Enum LAST_DT_CORE_CLK needs updating as R8A774A1_CLK_CANFD
> > > > > was recently added and it's the core clock with the highest
> > > > > index.
> > > > >
> > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > Reviewed-by: Chris Paterson <chris.paterson2@renesas.com>
> > >
> > > I think this needs:
> > >
> > > Fixes: 9d034e151b40 ("clk: renesas: r8a774a1: Add missing CANFD clock")
> >
> > I naively thought I could only refer to commits from Torvald's, which is clearly wrong,
> > therefore thank you for fixing.
>
> FTR: You can refer to any commits in linux-next that are considered stable,
> i.e. on branches that are never rebased.
> This includes all for-next branches of maintainers who accept pull requests.
I see, thank you for the explanation!
Cheers,
Fab
>
> Gr{oetje,eeting}s,
>
> Geert
>
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
>
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
^ permalink raw reply [flat|nested] 8+ messages in thread
* Re: [PATCH] clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK
2019-02-22 11:59 [PATCH] clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK Fabrizio Castro
2019-02-22 12:01 ` Chris Paterson
@ 2019-02-25 17:13 ` Stephen Boyd
1 sibling, 0 replies; 8+ messages in thread
From: Stephen Boyd @ 2019-02-25 17:13 UTC (permalink / raw)
To: Fabrizio Castro, Geert Uytterhoeven, Michael Turquette
Cc: Fabrizio Castro, linux-renesas-soc, linux-clk, Simon Horman,
Chris Paterson, Biju Das
Quoting Fabrizio Castro (2019-02-22 03:59:39)
> Enum LAST_DT_CORE_CLK needs updating as R8A774A1_CLK_CANFD
> was recently added and it's the core clock with the highest
> index.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> ---
Applied to clk-next
^ permalink raw reply [flat|nested] 8+ messages in thread
end of thread, other threads:[~2019-02-25 17:13 UTC | newest]
Thread overview: 8+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-02-22 11:59 [PATCH] clk: renesas: r8a774a1: Fix LAST_DT_CORE_CLK Fabrizio Castro
2019-02-22 12:01 ` Chris Paterson
2019-02-25 9:27 ` Simon Horman
2019-02-25 9:32 ` Geert Uytterhoeven
2019-02-25 9:44 ` Fabrizio Castro
2019-02-25 9:47 ` Geert Uytterhoeven
2019-02-25 9:49 ` Fabrizio Castro
2019-02-25 17:13 ` Stephen Boyd
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).