* [PATCH v2] media: rcar_drif: Remove devm_ioremap_resource() error printing
@ 2019-03-01 9:38 Geert Uytterhoeven
2019-03-02 10:09 ` Niklas Söderlund
2019-03-06 12:52 ` Simon Horman
0 siblings, 2 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2019-03-01 9:38 UTC (permalink / raw)
To: Mauro Carvalho Chehab, Ramesh Shanmugasundaram
Cc: linux-media, linux-renesas-soc, Geert Uytterhoeven
devm_ioremap_resource() already prints an error message on failure, so
there is no need to repeat that.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
v2:
- Drop assignment to ret.
---
drivers/media/platform/rcar_drif.c | 8 +++-----
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/drivers/media/platform/rcar_drif.c b/drivers/media/platform/rcar_drif.c
index c417ff8f6fe548f3..608e5217ccd50a1b 100644
--- a/drivers/media/platform/rcar_drif.c
+++ b/drivers/media/platform/rcar_drif.c
@@ -1405,11 +1405,9 @@ static int rcar_drif_probe(struct platform_device *pdev)
/* Register map */
res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
ch->base = devm_ioremap_resource(&pdev->dev, res);
- if (IS_ERR(ch->base)) {
- ret = PTR_ERR(ch->base);
- dev_err(&pdev->dev, "ioremap failed (%d)\n", ret);
- return ret;
- }
+ if (IS_ERR(ch->base))
+ return PTR_ERR(ch->base);
+
ch->start = res->start;
platform_set_drvdata(pdev, ch);
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v2] media: rcar_drif: Remove devm_ioremap_resource() error printing
2019-03-01 9:38 [PATCH v2] media: rcar_drif: Remove devm_ioremap_resource() error printing Geert Uytterhoeven
@ 2019-03-02 10:09 ` Niklas Söderlund
2019-03-06 12:52 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Niklas Söderlund @ 2019-03-02 10:09 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Mauro Carvalho Chehab, Ramesh Shanmugasundaram, linux-media,
linux-renesas-soc
Hi Geert,
Thanks for your patch.
On 2019-03-01 10:38:31 +0100, Geert Uytterhoeven wrote:
> devm_ioremap_resource() already prints an error message on failure, so
> there is no need to repeat that.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> v2:
> - Drop assignment to ret.
> ---
> drivers/media/platform/rcar_drif.c | 8 +++-----
> 1 file changed, 3 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/media/platform/rcar_drif.c b/drivers/media/platform/rcar_drif.c
> index c417ff8f6fe548f3..608e5217ccd50a1b 100644
> --- a/drivers/media/platform/rcar_drif.c
> +++ b/drivers/media/platform/rcar_drif.c
> @@ -1405,11 +1405,9 @@ static int rcar_drif_probe(struct platform_device *pdev)
> /* Register map */
> res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> ch->base = devm_ioremap_resource(&pdev->dev, res);
> - if (IS_ERR(ch->base)) {
> - ret = PTR_ERR(ch->base);
> - dev_err(&pdev->dev, "ioremap failed (%d)\n", ret);
> - return ret;
> - }
> + if (IS_ERR(ch->base))
> + return PTR_ERR(ch->base);
> +
> ch->start = res->start;
> platform_set_drvdata(pdev, ch);
>
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v2] media: rcar_drif: Remove devm_ioremap_resource() error printing
2019-03-01 9:38 [PATCH v2] media: rcar_drif: Remove devm_ioremap_resource() error printing Geert Uytterhoeven
2019-03-02 10:09 ` Niklas Söderlund
@ 2019-03-06 12:52 ` Simon Horman
1 sibling, 0 replies; 3+ messages in thread
From: Simon Horman @ 2019-03-06 12:52 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Mauro Carvalho Chehab, Ramesh Shanmugasundaram, linux-media,
linux-renesas-soc
On Fri, Mar 01, 2019 at 10:38:31AM +0100, Geert Uytterhoeven wrote:
> devm_ioremap_resource() already prints an error message on failure, so
> there is no need to repeat that.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> v2:
> - Drop assignment to ret.
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-03-06 12:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-01 9:38 [PATCH v2] media: rcar_drif: Remove devm_ioremap_resource() error printing Geert Uytterhoeven
2019-03-02 10:09 ` Niklas Söderlund
2019-03-06 12:52 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).