linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/3] PCI: rcar: Replace unsigned long with u32 for register values
@ 2019-03-17  0:06 marek.vasut
  2019-03-17  0:06 ` [PATCH 2/3] PCI: rcar: Allow 64bit MSI addresses marek.vasut
                   ` (3 more replies)
  0 siblings, 4 replies; 20+ messages in thread
From: marek.vasut @ 2019-03-17  0:06 UTC (permalink / raw)
  To: linux-pci
  Cc: Marek Vasut, Geert Uytterhoeven, Phil Edworthy, Simon Horman,
	Wolfram Sang, linux-renesas-soc

From: Marek Vasut <marek.vasut+renesas@gmail.com>

Replace unsigned long with u32 type for variables holding
register values, since the registers are 32bit. Note that
rcar_pcie_msi_irq() still uses unsigned long because both
find_first_bit() and __fls() require unsigned long as an
argument.

Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
Cc: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Phil Edworthy <phil.edworthy@renesas.com>
Cc: Simon Horman <horms+renesas@verge.net.au>
Cc: Wolfram Sang <wsa@the-dreams.de>
Cc: linux-renesas-soc@vger.kernel.org
To: linux-pci@vger.kernel.org
---
 drivers/pci/controller/pcie-rcar.c | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/drivers/pci/controller/pcie-rcar.c b/drivers/pci/controller/pcie-rcar.c
index 1408c8aa758b..857d88fd03d5 100644
--- a/drivers/pci/controller/pcie-rcar.c
+++ b/drivers/pci/controller/pcie-rcar.c
@@ -169,7 +169,7 @@ enum {
 
 static void rcar_rmw32(struct rcar_pcie *pcie, int where, u32 mask, u32 data)
 {
-	int shift = 8 * (where & 3);
+	u32 shift = 8 * (where & 3);
 	u32 val = rcar_pci_read_reg(pcie, where & ~3);
 
 	val &= ~(mask << shift);
@@ -179,7 +179,7 @@ static void rcar_rmw32(struct rcar_pcie *pcie, int where, u32 mask, u32 data)
 
 static u32 rcar_read_conf(struct rcar_pcie *pcie, int where)
 {
-	int shift = 8 * (where & 3);
+	u32 shift = 8 * (where & 3);
 	u32 val = rcar_pci_read_reg(pcie, where & ~3);
 
 	return val >> shift;
@@ -190,7 +190,7 @@ static int rcar_pcie_config_access(struct rcar_pcie *pcie,
 		unsigned char access_type, struct pci_bus *bus,
 		unsigned int devfn, int where, u32 *data)
 {
-	int dev, func, reg, index;
+	u32 dev, func, reg, index;
 
 	dev = PCI_SLOT(devfn);
 	func = PCI_FUNC(devfn);
@@ -508,7 +508,7 @@ static void phy_write_reg(struct rcar_pcie *pcie,
 				 unsigned int rate, unsigned int addr,
 				 unsigned int lane, unsigned int data)
 {
-	unsigned long phyaddr;
+	u32 phyaddr;
 
 	phyaddr = WRITE_CMD |
 		((rate & 1) << RATE_POS) |
@@ -1116,7 +1116,7 @@ static int rcar_pcie_probe(struct platform_device *pdev)
 {
 	struct device *dev = &pdev->dev;
 	struct rcar_pcie *pcie;
-	unsigned int data;
+	u32 data;
 	int err;
 	int (*phy_init_fn)(struct rcar_pcie *);
 	struct pci_host_bridge *bridge;
-- 
2.20.1


^ permalink raw reply related	[flat|nested] 20+ messages in thread
end of thread, other threads:[~2019-03-22  2:31 UTC | newest]

Thread overview: 20+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-17  0:06 [PATCH 1/3] PCI: rcar: Replace unsigned long with u32 for register values marek.vasut
2019-03-17  0:06 ` [PATCH 2/3] PCI: rcar: Allow 64bit MSI addresses marek.vasut
2019-03-17  8:03   ` Sergei Shtylyov
2019-03-17 22:59     ` Marek Vasut
2019-03-17  9:12   ` Wolfram Sang
2019-03-17 23:37     ` Marek Vasut
2019-03-18  8:39       ` Geert Uytterhoeven
2019-03-18  9:30         ` Geert Uytterhoeven
2019-03-19  1:16           ` Marek Vasut
2019-03-18  8:35   ` Geert Uytterhoeven
2019-03-22  2:30     ` Marek Vasut
2019-03-17  0:06 ` [PATCH 3/3] PCI: rcar: Clean up debug messages marek.vasut
2019-03-17  9:15   ` Wolfram Sang
2019-03-18  8:20   ` Geert Uytterhoeven
2019-03-17  9:09 ` [PATCH 1/3] PCI: rcar: Replace unsigned long with u32 for register values Wolfram Sang
2019-03-17 22:58   ` Marek Vasut
2019-03-18  7:33     ` Wolfram Sang
2019-03-18  8:47 ` Geert Uytterhoeven
2019-03-21  3:25   ` Marek Vasut
2019-03-21  7:31     ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).