[PATCH] arm64: dts: renesas: r8a774c0: Add CANFD support

[PATCH] arm64: dts: renesas: r8a774c0: Add CANFD support

[Fabrizio Castro]

The CANFD implementation on the RZ/G2E (a.k.a. r8a774c0) is
identical to the one found on the r8a77990.

Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

---
This patch depends on:
https://patchwork.kernel.org/patch/10766777/
https://patchwork.kernel.org/patch/10766781/
---
 arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 25 +++++++++++++++++++++++++
 1 file changed, 25 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
index af0abf6..f6b3eb4 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
@@ -992,6 +992,31 @@
 			status = "disabled";
 		};
 
+		canfd: can@e66c0000 {
+			compatible = "renesas,r8a774c0-canfd",
+				     "renesas,rcar-gen3-canfd";
+			reg = <0 0xe66c0000 0 0x8000>;
+			interrupts = <GIC_SPI 29 IRQ_TYPE_LEVEL_HIGH>,
+				     <GIC_SPI 30 IRQ_TYPE_LEVEL_HIGH>;
+			clocks = <&cpg CPG_MOD 914>,
+				 <&cpg CPG_CORE R8A774C0_CLK_CANFD>,
+				 <&can_clk>;
+			clock-names = "fck", "canfd", "can_clk";
+			assigned-clocks = <&cpg CPG_CORE R8A774C0_CLK_CANFD>;
+			assigned-clock-rates = <40000000>;
+			power-domains = <&sysc R8A774C0_PD_ALWAYS_ON>;
+			resets = <&cpg 914>;
+			status = "disabled";
+
+			channel0 {
+				status = "disabled";
+			};
+
+			channel1 {
+				status = "disabled";
+			};
+		};
+
 		pwm0: pwm@e6e30000 {
 			compatible = "renesas,pwm-r8a774c0", "renesas,pwm-rcar";
 			reg = <0 0xe6e30000 0 0x8>;
-- 
2.7.4

Re: [PATCH] arm64: dts: renesas: r8a774c0: Add CANFD support

[Geert Uytterhoeven]

On Fri, Mar 1, 2019 at 12:04 PM Fabrizio Castro
<fabrizio.castro@bp.renesas.com> wrote:
> The CANFD implementation on the RZ/G2E (a.k.a. r8a774c0) is
> identical to the one found on the r8a77990.
>
> Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH] arm64: dts: renesas: r8a774c0: Add CANFD support

[Simon Horman]

On Fri, Mar 01, 2019 at 02:38:53PM +0100, Geert Uytterhoeven wrote:
> On Fri, Mar 1, 2019 at 12:04 PM Fabrizio Castro
> <fabrizio.castro@bp.renesas.com> wrote:
> > The CANFD implementation on the RZ/G2E (a.k.a. r8a774c0) is
> > identical to the one found on the r8a77990.
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> 
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Thanks, applied.

RE: [PATCH] arm64: dts: renesas: r8a774c0: Add CANFD support

[Fabrizio Castro]

Hello Simon,

Thank you for your feedback!

> From: Simon Horman <horms@verge.net.au>
> Sent: 04 March 2019 09:59
> To: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>; Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>;
> Magnus Damm <magnus.damm@gmail.com>; Linux-Renesas <linux-renesas-soc@vger.kernel.org>; open list:OPEN FIRMWARE AND
> FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; Chris Paterson <Chris.Paterson2@renesas.com>; Biju Das
> <biju.das@bp.renesas.com>
> Subject: Re: [PATCH] arm64: dts: renesas: r8a774c0: Add CANFD support
> 
> On Fri, Mar 01, 2019 at 02:38:53PM +0100, Geert Uytterhoeven wrote:
> > On Fri, Mar 1, 2019 at 12:04 PM Fabrizio Castro
> > <fabrizio.castro@bp.renesas.com> wrote:
> > > The CANFD implementation on the RZ/G2E (a.k.a. r8a774c0) is
> > > identical to the one found on the r8a77990.
> > >
> > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> >
> > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> 
> Thanks, applied.

The patch that adds R8A774C0_CLK_CANFD (https://patchwork.kernel.org/patch/10766867/)
Isn't in a release candidate just yet, therefore I was expecting this patch to be deferred to
to when R8A774C0_CLK_CANFD is finally available, similarly to:
https://www.spinics.net/lists/netdev/msg547320.html

Was I wrong?

Thanks,
Fab

Re: [PATCH] arm64: dts: renesas: r8a774c0: Add CANFD support

[Simon Horman]

On Mon, Mar 04, 2019 at 10:10:49AM +0000, Fabrizio Castro wrote:
> Hello Simon,
> 
> Thank you for your feedback!
> 
> > From: Simon Horman <horms@verge.net.au>
> > Sent: 04 March 2019 09:59
> > To: Geert Uytterhoeven <geert@linux-m68k.org>
> > Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>; Rob Herring <robh+dt@kernel.org>; Mark Rutland <mark.rutland@arm.com>;
> > Magnus Damm <magnus.damm@gmail.com>; Linux-Renesas <linux-renesas-soc@vger.kernel.org>; open list:OPEN FIRMWARE AND
> > FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; Chris Paterson <Chris.Paterson2@renesas.com>; Biju Das
> > <biju.das@bp.renesas.com>
> > Subject: Re: [PATCH] arm64: dts: renesas: r8a774c0: Add CANFD support
> > 
> > On Fri, Mar 01, 2019 at 02:38:53PM +0100, Geert Uytterhoeven wrote:
> > > On Fri, Mar 1, 2019 at 12:04 PM Fabrizio Castro
> > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > The CANFD implementation on the RZ/G2E (a.k.a. r8a774c0) is
> > > > identical to the one found on the r8a77990.
> > > >
> > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > >
> > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > 
> > Thanks, applied.
> 
> The patch that adds R8A774C0_CLK_CANFD (https://patchwork.kernel.org/patch/10766867/)
> Isn't in a release candidate just yet, therefore I was expecting this patch to be deferred to
> to when R8A774C0_CLK_CANFD is finally available, similarly to:
> https://www.spinics.net/lists/netdev/msg547320.html
> 
> Was I wrong?

No, I was wrong in sending out the email above.

The patch is still deferred.

RE: [PATCH] arm64: dts: renesas: r8a774c0: Add CANFD support

[Fabrizio Castro]

Hello Simon,

> From: Simon Horman <horms@verge.net.au>
> Sent: 06 March 2019 12:54
> Subject: Re: [PATCH] arm64: dts: renesas: r8a774c0: Add CANFD support
> 
> On Mon, Mar 04, 2019 at 10:10:49AM +0000, Fabrizio Castro wrote:
> > Hello Simon,
> >
> > Thank you for your feedback!
> >
> > > From: Simon Horman <horms@verge.net.au>
> > > Sent: 04 March 2019 09:59
> > > To: Geert Uytterhoeven <geert@linux-m68k.org>
> > > Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>; Rob Herring <robh+dt@kernel.org>; Mark Rutland
> <mark.rutland@arm.com>;
> > > Magnus Damm <magnus.damm@gmail.com>; Linux-Renesas <linux-renesas-soc@vger.kernel.org>; open list:OPEN FIRMWARE
> AND
> > > FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; Chris Paterson <Chris.Paterson2@renesas.com>; Biju Das
> > > <biju.das@bp.renesas.com>
> > > Subject: Re: [PATCH] arm64: dts: renesas: r8a774c0: Add CANFD support
> > >
> > > On Fri, Mar 01, 2019 at 02:38:53PM +0100, Geert Uytterhoeven wrote:
> > > > On Fri, Mar 1, 2019 at 12:04 PM Fabrizio Castro
> > > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > > The CANFD implementation on the RZ/G2E (a.k.a. r8a774c0) is
> > > > > identical to the one found on the r8a77990.
> > > > >
> > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > >
> > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > >
> > > Thanks, applied.
> >
> > The patch that adds R8A774C0_CLK_CANFD (https://patchwork.kernel.org/patch/10766867/)
> > Isn't in a release candidate just yet, therefore I was expecting this patch to be deferred to
> > to when R8A774C0_CLK_CANFD is finally available, similarly to:
> > https://www.spinics.net/lists/netdev/msg547320.html
> >
> > Was I wrong?
> 
> No, I was wrong in sending out the email above.
> 
> The patch is still deferred.

My understanding is that this patch can be taken now, and it still applies neatly.

Thanks,
Fab

Re: [PATCH] arm64: dts: renesas: r8a774c0: Add CANFD support

[Simon Horman]

On Tue, Mar 19, 2019 at 11:16:36AM +0000, Fabrizio Castro wrote:
> Hello Simon,
> 
> > From: Simon Horman <horms@verge.net.au>
> > Sent: 06 March 2019 12:54
> > Subject: Re: [PATCH] arm64: dts: renesas: r8a774c0: Add CANFD support
> > 
> > On Mon, Mar 04, 2019 at 10:10:49AM +0000, Fabrizio Castro wrote:
> > > Hello Simon,
> > >
> > > Thank you for your feedback!
> > >
> > > > From: Simon Horman <horms@verge.net.au>
> > > > Sent: 04 March 2019 09:59
> > > > To: Geert Uytterhoeven <geert@linux-m68k.org>
> > > > Cc: Fabrizio Castro <fabrizio.castro@bp.renesas.com>; Rob Herring <robh+dt@kernel.org>; Mark Rutland
> > <mark.rutland@arm.com>;
> > > > Magnus Damm <magnus.damm@gmail.com>; Linux-Renesas <linux-renesas-soc@vger.kernel.org>; open list:OPEN FIRMWARE
> > AND
> > > > FLATTENED DEVICE TREE BINDINGS <devicetree@vger.kernel.org>; Chris Paterson <Chris.Paterson2@renesas.com>; Biju Das
> > > > <biju.das@bp.renesas.com>
> > > > Subject: Re: [PATCH] arm64: dts: renesas: r8a774c0: Add CANFD support
> > > >
> > > > On Fri, Mar 01, 2019 at 02:38:53PM +0100, Geert Uytterhoeven wrote:
> > > > > On Fri, Mar 1, 2019 at 12:04 PM Fabrizio Castro
> > > > > <fabrizio.castro@bp.renesas.com> wrote:
> > > > > > The CANFD implementation on the RZ/G2E (a.k.a. r8a774c0) is
> > > > > > identical to the one found on the r8a77990.
> > > > > >
> > > > > > Signed-off-by: Fabrizio Castro <fabrizio.castro@bp.renesas.com>
> > > > >
> > > > > Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> > > >
> > > > Thanks, applied.
> > >
> > > The patch that adds R8A774C0_CLK_CANFD (https://patchwork.kernel.org/patch/10766867/)
> > > Isn't in a release candidate just yet, therefore I was expecting this patch to be deferred to
> > > to when R8A774C0_CLK_CANFD is finally available, similarly to:
> > > https://www.spinics.net/lists/netdev/msg547320.html
> > >
> > > Was I wrong?
> > 
> > No, I was wrong in sending out the email above.
> > 
> > The patch is still deferred.
> 
> My understanding is that this patch can be taken now, and it still applies neatly.

Thanks, I agree this should be ready now.
I've applied it for v5.2.