* [PATCH] clk: renesas: r7s9210: Always use readl()
@ 2019-03-20 10:25 Geert Uytterhoeven
2019-03-27 11:53 ` Simon Horman
0 siblings, 1 reply; 2+ messages in thread
From: Geert Uytterhoeven @ 2019-03-20 10:25 UTC (permalink / raw)
To: Michael Turquette, Stephen Boyd, Chris Brandt
Cc: linux-renesas-soc, linux-clk, Geert Uytterhoeven
On arm32, there is no reason to use the (soon deprecated) clk_readl().
Hence use the generic readl() instead.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
To be queued in clk-renesas-for-v5.2.
drivers/clk/renesas/r7s9210-cpg-mssr.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/clk/renesas/r7s9210-cpg-mssr.c b/drivers/clk/renesas/r7s9210-cpg-mssr.c
index 57c49fe8829567e1..cf65d4e0e1166647 100644
--- a/drivers/clk/renesas/r7s9210-cpg-mssr.c
+++ b/drivers/clk/renesas/r7s9210-cpg-mssr.c
@@ -11,6 +11,7 @@
#include <linux/clk.h>
#include <linux/clk-provider.h>
+#include <linux/io.h>
#include <dt-bindings/clock/r7s9210-cpg-mssr.h>
#include "renesas-cpg-mssr.h"
@@ -119,7 +120,7 @@ static void __init r7s9210_update_clk_table(struct clk *extal_clk,
if (clk_get_rate(extal_clk) > 12000000)
cpg_mode = 1;
- frqcr = clk_readl(base + CPG_FRQCR) & 0xFFF;
+ frqcr = readl(base + CPG_FRQCR) & 0xFFF;
if (frqcr == 0x012)
index = 0;
else if (frqcr == 0x112)
--
2.17.1
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] clk: renesas: r7s9210: Always use readl()
2019-03-20 10:25 [PATCH] clk: renesas: r7s9210: Always use readl() Geert Uytterhoeven
@ 2019-03-27 11:53 ` Simon Horman
0 siblings, 0 replies; 2+ messages in thread
From: Simon Horman @ 2019-03-27 11:53 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Michael Turquette, Stephen Boyd, Chris Brandt, linux-renesas-soc,
linux-clk
On Wed, Mar 20, 2019 at 11:25:12AM +0100, Geert Uytterhoeven wrote:
> On arm32, there is no reason to use the (soon deprecated) clk_readl().
> Hence use the generic readl() instead.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> To be queued in clk-renesas-for-v5.2.
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
>
> drivers/clk/renesas/r7s9210-cpg-mssr.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/clk/renesas/r7s9210-cpg-mssr.c b/drivers/clk/renesas/r7s9210-cpg-mssr.c
> index 57c49fe8829567e1..cf65d4e0e1166647 100644
> --- a/drivers/clk/renesas/r7s9210-cpg-mssr.c
> +++ b/drivers/clk/renesas/r7s9210-cpg-mssr.c
> @@ -11,6 +11,7 @@
>
> #include <linux/clk.h>
> #include <linux/clk-provider.h>
> +#include <linux/io.h>
> #include <dt-bindings/clock/r7s9210-cpg-mssr.h>
> #include "renesas-cpg-mssr.h"
>
> @@ -119,7 +120,7 @@ static void __init r7s9210_update_clk_table(struct clk *extal_clk,
> if (clk_get_rate(extal_clk) > 12000000)
> cpg_mode = 1;
>
> - frqcr = clk_readl(base + CPG_FRQCR) & 0xFFF;
> + frqcr = readl(base + CPG_FRQCR) & 0xFFF;
> if (frqcr == 0x012)
> index = 0;
> else if (frqcr == 0x112)
> --
> 2.17.1
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2019-03-27 11:53 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-03-20 10:25 [PATCH] clk: renesas: r7s9210: Always use readl() Geert Uytterhoeven
2019-03-27 11:53 ` Simon Horman
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).