From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Geert Uytterhoeven <geert+renesas@glider.be>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Ulrich Hecht <uli+renesas@fpond.eu>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-renesas-soc@vger.kernel.org, linux-gpio@vger.kernel.org
Subject: Re: [PATCH] pinctrl: sh-pfc: Improve PINMUX_IPSR_PHYS() documentation
Date: Wed, 20 Mar 2019 15:41:40 +0100 [thread overview]
Message-ID: <20190320144140.GK26015@bigcity.dyn.berto.se> (raw)
In-Reply-To: <20190320104446.21833-1-geert+renesas@glider.be>
Hi Geert,
Thanks for your work.
On 2019-03-20 11:44:46 +0100, Geert Uytterhoeven wrote:
> - The IPSR field is meant for documentation only,
> - The function name refers to the pin function, not to the IPSR field.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> To be queued in sh-pfc-for-v5.2.
>
> drivers/pinctrl/sh-pfc/sh_pfc.h | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/pinctrl/sh-pfc/sh_pfc.h b/drivers/pinctrl/sh-pfc/sh_pfc.h
> index 2a6abeb62bab659b..7db5819eea7e6e0d 100644
> --- a/drivers/pinctrl/sh-pfc/sh_pfc.h
> +++ b/drivers/pinctrl/sh-pfc/sh_pfc.h
> @@ -418,8 +418,8 @@ extern const struct sh_pfc_soc_info shx3_pinmux_info;
> /*
> * Describe a pinmux configuration in which a pin is physically multiplexed
> * with other pins.
> - * - ipsr: IPSR field
> - * - fn: Function name, also referring to the IPSR field
> + * - ipsr: IPSR field (unused, for documentation purposes only)
> + * - fn: Function name
> * - psel: Physical multiplexing selector
> */
> #define PINMUX_IPSR_PHYS(ipsr, fn, psel) \
> --
> 2.17.1
>
--
Regards,
Niklas Söderlund
prev parent reply other threads:[~2019-03-20 14:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-20 10:44 [PATCH] pinctrl: sh-pfc: Improve PINMUX_IPSR_PHYS() documentation Geert Uytterhoeven
2019-03-20 14:41 ` Niklas Söderlund [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20190320144140.GK26015@bigcity.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=geert+renesas@glider.be \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=uli+renesas@fpond.eu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).