Linux-Renesas-SoC Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH 00/46] watchdog: move 'registration failed' messages into core
@ 2019-05-18 21:27 Wolfram Sang
  2019-06-07 12:40 ` Guenter Roeck
  0 siblings, 1 reply; 2+ messages in thread
From: Wolfram Sang @ 2019-05-18 21:27 UTC (permalink / raw)
  To: linux-watchdog; +Cc: Wolfram Sang, linux-renesas-soc

Similar to my recently merged series doing the same for
watchdog_init_timeout(), here is a series moving all error messages
after a failed {devm_}watchdog_register_device() into the core. Guenter
was right, this was even more worth it. For some cases, this also
resulted in neat code simplifications.

The core changes were tested with a Renesas Lager (R-Car H2) board. The
driver changes were created using a coccinelle script and build-tested
by buildbot.

This series is based on Linus' tree as of today which should be close
enough to -rc1, I guess. A branch can be found here:

git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/wdt/register_device

Looking forward to comments.

Happy hacking,

   Wolfram

Wolfram Sang (46):
  watchdog: make watchdog_deferred_registration_add() void
  watchdog: let core print error message when registering device fails
  watchdog: aspeed_wdt: drop warning after registering device
  watchdog: bcm2835_wdt: drop warning after registering device
  watchdog: bcm7038_wdt: drop warning after registering device
  watchdog: bcm_kona_wdt: drop warning after registering device
  watchdog: cadence_wdt: drop warning after registering device
  watchdog: da9052_wdt: drop warning after registering device
  watchdog: da9062_wdt: drop warning after registering device
  watchdog: davinci_wdt: drop warning after registering device
  watchdog: digicolor_wdt: drop warning after registering device
  watchdog: ftwdt010_wdt: drop warning after registering device
  watchdog: hpwdt: drop warning after registering device
  watchdog: i6300esb: drop warning after registering device
  watchdog: ie6xx_wdt: drop warning after registering device
  watchdog: imx2_wdt: drop warning after registering device
  watchdog: imx_sc_wdt: drop warning after registering device
  watchdog: intel-mid_wdt: drop warning after registering device
  watchdog: jz4740_wdt: drop warning after registering device
  watchdog: loongson1_wdt: drop warning after registering device
  watchdog: max77620_wdt: drop warning after registering device
  watchdog: mei_wdt: drop warning after registering device
  watchdog: mena21_wdt: drop warning after registering device
  watchdog: menf21bmc_wdt: drop warning after registering device
  watchdog: mpc8xxx_wdt: drop warning after registering device
  watchdog: ni903x_wdt: drop warning after registering device
  watchdog: nic7018_wdt: drop warning after registering device
  watchdog: npcm_wdt: drop warning after registering device
  watchdog: of_xilinx_wdt: drop warning after registering device
  watchdog: pic32-dmt: drop warning after registering device
  watchdog: pic32-wdt: drop warning after registering device
  watchdog: pnx4008_wdt: drop warning after registering device
  watchdog: qcom-wdt: drop warning after registering device
  watchdog: rave-sp-wdt: drop warning after registering device
  watchdog: s3c2410_wdt: drop warning after registering device
  watchdog: sama5d4_wdt: drop warning after registering device
  watchdog: sp5100_tco: drop warning after registering device
  watchdog: sp805_wdt: drop warning after registering device
  watchdog: sprd_wdt: drop warning after registering device
  watchdog: st_lpc_wdt: drop warning after registering device
  watchdog: stm32_iwdg: drop warning after registering device
  watchdog: stmp3xxx_rtc_wdt: drop warning after registering device
  watchdog: tegra_wdt: drop warning after registering device
  watchdog: ts4800_wdt: drop warning after registering device
  watchdog: wm831x_wdt: drop warning after registering device
  watchdog: xen_wdt: drop warning after registering device

 drivers/watchdog/aspeed_wdt.c       |  8 +-------
 drivers/watchdog/bcm2835_wdt.c      |  4 +---
 drivers/watchdog/bcm7038_wdt.c      |  4 +---
 drivers/watchdog/bcm_kona_wdt.c     |  4 +---
 drivers/watchdog/cadence_wdt.c      |  4 +---
 drivers/watchdog/da9052_wdt.c       |  9 +--------
 drivers/watchdog/da9062_wdt.c       |  5 +----
 drivers/watchdog/davinci_wdt.c      |  8 +-------
 drivers/watchdog/digicolor_wdt.c    |  8 +-------
 drivers/watchdog/ftwdt010_wdt.c     |  4 +---
 drivers/watchdog/hpwdt.c            |  4 +---
 drivers/watchdog/i6300esb.c         |  5 +----
 drivers/watchdog/ie6xx_wdt.c        |  6 +-----
 drivers/watchdog/imx2_wdt.c         |  4 +---
 drivers/watchdog/imx_sc_wdt.c       |  8 +-------
 drivers/watchdog/intel-mid_wdt.c    |  4 +---
 drivers/watchdog/jz4740_wdt.c       |  6 +-----
 drivers/watchdog/loongson1_wdt.c    |  4 +---
 drivers/watchdog/max77620_wdt.c     |  8 +-------
 drivers/watchdog/mei_wdt.c          |  4 +---
 drivers/watchdog/mena21_wdt.c       |  4 +---
 drivers/watchdog/menf21bmc_wdt.c    |  4 +---
 drivers/watchdog/mpc8xxx_wdt.c      |  5 +----
 drivers/watchdog/ni903x_wdt.c       |  4 +---
 drivers/watchdog/nic7018_wdt.c      |  1 -
 drivers/watchdog/npcm_wdt.c         |  4 +---
 drivers/watchdog/of_xilinx_wdt.c    |  4 +---
 drivers/watchdog/pic32-dmt.c        |  4 +---
 drivers/watchdog/pic32-wdt.c        |  4 +---
 drivers/watchdog/pnx4008_wdt.c      |  4 +---
 drivers/watchdog/qcom-wdt.c         |  4 +---
 drivers/watchdog/rave-sp-wdt.c      |  1 -
 drivers/watchdog/s3c2410_wdt.c      |  4 +---
 drivers/watchdog/sama5d4_wdt.c      |  4 +---
 drivers/watchdog/sp5100_tco.c       |  4 +---
 drivers/watchdog/sp805_wdt.c        |  5 +----
 drivers/watchdog/sprd_wdt.c         |  1 -
 drivers/watchdog/st_lpc_wdt.c       |  4 +---
 drivers/watchdog/stm32_iwdg.c       |  4 +---
 drivers/watchdog/stmp3xxx_rtc_wdt.c |  4 +---
 drivers/watchdog/tegra_wdt.c        |  4 +---
 drivers/watchdog/ts4800_wdt.c       |  4 +---
 drivers/watchdog/watchdog_core.c    | 16 ++++++++++++----
 drivers/watchdog/wm831x_wdt.c       |  9 +--------
 drivers/watchdog/xen_wdt.c          |  4 +---
 45 files changed, 53 insertions(+), 168 deletions(-)

-- 
2.19.1


^ permalink raw reply	[flat|nested] 2+ messages in thread

* Re: [PATCH 00/46] watchdog: move 'registration failed' messages into core
  2019-05-18 21:27 [PATCH 00/46] watchdog: move 'registration failed' messages into core Wolfram Sang
@ 2019-06-07 12:40 ` Guenter Roeck
  0 siblings, 0 replies; 2+ messages in thread
From: Guenter Roeck @ 2019-06-07 12:40 UTC (permalink / raw)
  To: Wolfram Sang, linux-watchdog; +Cc: linux-renesas-soc

On 5/18/19 2:27 PM, Wolfram Sang wrote:
> Similar to my recently merged series doing the same for
> watchdog_init_timeout(), here is a series moving all error messages
> after a failed {devm_}watchdog_register_device() into the core. Guenter
> was right, this was even more worth it. For some cases, this also
> resulted in neat code simplifications.
> 
> The core changes were tested with a Renesas Lager (R-Car H2) board. The
> driver changes were created using a coccinelle script and build-tested
> by buildbot.
> 
> This series is based on Linus' tree as of today which should be close
> enough to -rc1, I guess. A branch can be found here:
> 
> git://git.kernel.org/pub/scm/linux/kernel/git/wsa/linux.git renesas/wdt/register_device
> 
> Looking forward to comments.
> 

For the series:

Reviewed-by: Guenter Roeck <linux@roeck-us.net>

> Happy hacking,
> 
>     Wolfram
> 
> Wolfram Sang (46):
>    watchdog: make watchdog_deferred_registration_add() void
>    watchdog: let core print error message when registering device fails
>    watchdog: aspeed_wdt: drop warning after registering device
>    watchdog: bcm2835_wdt: drop warning after registering device
>    watchdog: bcm7038_wdt: drop warning after registering device
>    watchdog: bcm_kona_wdt: drop warning after registering device
>    watchdog: cadence_wdt: drop warning after registering device
>    watchdog: da9052_wdt: drop warning after registering device
>    watchdog: da9062_wdt: drop warning after registering device
>    watchdog: davinci_wdt: drop warning after registering device
>    watchdog: digicolor_wdt: drop warning after registering device
>    watchdog: ftwdt010_wdt: drop warning after registering device
>    watchdog: hpwdt: drop warning after registering device
>    watchdog: i6300esb: drop warning after registering device
>    watchdog: ie6xx_wdt: drop warning after registering device
>    watchdog: imx2_wdt: drop warning after registering device
>    watchdog: imx_sc_wdt: drop warning after registering device
>    watchdog: intel-mid_wdt: drop warning after registering device
>    watchdog: jz4740_wdt: drop warning after registering device
>    watchdog: loongson1_wdt: drop warning after registering device
>    watchdog: max77620_wdt: drop warning after registering device
>    watchdog: mei_wdt: drop warning after registering device
>    watchdog: mena21_wdt: drop warning after registering device
>    watchdog: menf21bmc_wdt: drop warning after registering device
>    watchdog: mpc8xxx_wdt: drop warning after registering device
>    watchdog: ni903x_wdt: drop warning after registering device
>    watchdog: nic7018_wdt: drop warning after registering device
>    watchdog: npcm_wdt: drop warning after registering device
>    watchdog: of_xilinx_wdt: drop warning after registering device
>    watchdog: pic32-dmt: drop warning after registering device
>    watchdog: pic32-wdt: drop warning after registering device
>    watchdog: pnx4008_wdt: drop warning after registering device
>    watchdog: qcom-wdt: drop warning after registering device
>    watchdog: rave-sp-wdt: drop warning after registering device
>    watchdog: s3c2410_wdt: drop warning after registering device
>    watchdog: sama5d4_wdt: drop warning after registering device
>    watchdog: sp5100_tco: drop warning after registering device
>    watchdog: sp805_wdt: drop warning after registering device
>    watchdog: sprd_wdt: drop warning after registering device
>    watchdog: st_lpc_wdt: drop warning after registering device
>    watchdog: stm32_iwdg: drop warning after registering device
>    watchdog: stmp3xxx_rtc_wdt: drop warning after registering device
>    watchdog: tegra_wdt: drop warning after registering device
>    watchdog: ts4800_wdt: drop warning after registering device
>    watchdog: wm831x_wdt: drop warning after registering device
>    watchdog: xen_wdt: drop warning after registering device
> 
>   drivers/watchdog/aspeed_wdt.c       |  8 +-------
>   drivers/watchdog/bcm2835_wdt.c      |  4 +---
>   drivers/watchdog/bcm7038_wdt.c      |  4 +---
>   drivers/watchdog/bcm_kona_wdt.c     |  4 +---
>   drivers/watchdog/cadence_wdt.c      |  4 +---
>   drivers/watchdog/da9052_wdt.c       |  9 +--------
>   drivers/watchdog/da9062_wdt.c       |  5 +----
>   drivers/watchdog/davinci_wdt.c      |  8 +-------
>   drivers/watchdog/digicolor_wdt.c    |  8 +-------
>   drivers/watchdog/ftwdt010_wdt.c     |  4 +---
>   drivers/watchdog/hpwdt.c            |  4 +---
>   drivers/watchdog/i6300esb.c         |  5 +----
>   drivers/watchdog/ie6xx_wdt.c        |  6 +-----
>   drivers/watchdog/imx2_wdt.c         |  4 +---
>   drivers/watchdog/imx_sc_wdt.c       |  8 +-------
>   drivers/watchdog/intel-mid_wdt.c    |  4 +---
>   drivers/watchdog/jz4740_wdt.c       |  6 +-----
>   drivers/watchdog/loongson1_wdt.c    |  4 +---
>   drivers/watchdog/max77620_wdt.c     |  8 +-------
>   drivers/watchdog/mei_wdt.c          |  4 +---
>   drivers/watchdog/mena21_wdt.c       |  4 +---
>   drivers/watchdog/menf21bmc_wdt.c    |  4 +---
>   drivers/watchdog/mpc8xxx_wdt.c      |  5 +----
>   drivers/watchdog/ni903x_wdt.c       |  4 +---
>   drivers/watchdog/nic7018_wdt.c      |  1 -
>   drivers/watchdog/npcm_wdt.c         |  4 +---
>   drivers/watchdog/of_xilinx_wdt.c    |  4 +---
>   drivers/watchdog/pic32-dmt.c        |  4 +---
>   drivers/watchdog/pic32-wdt.c        |  4 +---
>   drivers/watchdog/pnx4008_wdt.c      |  4 +---
>   drivers/watchdog/qcom-wdt.c         |  4 +---
>   drivers/watchdog/rave-sp-wdt.c      |  1 -
>   drivers/watchdog/s3c2410_wdt.c      |  4 +---
>   drivers/watchdog/sama5d4_wdt.c      |  4 +---
>   drivers/watchdog/sp5100_tco.c       |  4 +---
>   drivers/watchdog/sp805_wdt.c        |  5 +----
>   drivers/watchdog/sprd_wdt.c         |  1 -
>   drivers/watchdog/st_lpc_wdt.c       |  4 +---
>   drivers/watchdog/stm32_iwdg.c       |  4 +---
>   drivers/watchdog/stmp3xxx_rtc_wdt.c |  4 +---
>   drivers/watchdog/tegra_wdt.c        |  4 +---
>   drivers/watchdog/ts4800_wdt.c       |  4 +---
>   drivers/watchdog/watchdog_core.c    | 16 ++++++++++++----
>   drivers/watchdog/wm831x_wdt.c       |  9 +--------
>   drivers/watchdog/xen_wdt.c          |  4 +---
>   45 files changed, 53 insertions(+), 168 deletions(-)
> 


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, back to index

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-05-18 21:27 [PATCH 00/46] watchdog: move 'registration failed' messages into core Wolfram Sang
2019-06-07 12:40 ` Guenter Roeck

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org linux-renesas-soc@archiver.kernel.org
	public-inbox-index linux-renesas-soc


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox