* [PATCH] soc: renesas: rcar-sysc: Use [] to denote a flexible array member
@ 2019-06-19 12:46 Geert Uytterhoeven
2019-06-19 14:09 ` Simon Horman
0 siblings, 1 reply; 3+ messages in thread
From: Geert Uytterhoeven @ 2019-06-19 12:46 UTC (permalink / raw)
To: Simon Horman, Magnus Damm; +Cc: linux-renesas-soc, Geert Uytterhoeven
Flexible array members should be denoted using [] instead of [0], else
gcc will not warn when they are no longer at the end of the structure.
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/soc/renesas/rcar-sysc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/soc/renesas/rcar-sysc.c b/drivers/soc/renesas/rcar-sysc.c
index b28955e21a9868e0..20fa9f34295c2879 100644
--- a/drivers/soc/renesas/rcar-sysc.c
+++ b/drivers/soc/renesas/rcar-sysc.c
@@ -182,7 +182,7 @@ struct rcar_sysc_pd {
struct generic_pm_domain genpd;
struct rcar_sysc_ch ch;
unsigned int flags;
- char name[0];
+ char name[];
};
static inline struct rcar_sysc_pd *to_rcar_pd(struct generic_pm_domain *d)
--
2.17.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: renesas: rcar-sysc: Use [] to denote a flexible array member
2019-06-19 12:46 [PATCH] soc: renesas: rcar-sysc: Use [] to denote a flexible array member Geert Uytterhoeven
@ 2019-06-19 14:09 ` Simon Horman
2019-07-08 12:00 ` Geert Uytterhoeven
0 siblings, 1 reply; 3+ messages in thread
From: Simon Horman @ 2019-06-19 14:09 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Magnus Damm, linux-renesas-soc
On Wed, Jun 19, 2019 at 02:46:37PM +0200, Geert Uytterhoeven wrote:
> Flexible array members should be denoted using [] instead of [0], else
> gcc will not warn when they are no longer at the end of the structure.
>
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] soc: renesas: rcar-sysc: Use [] to denote a flexible array member
2019-06-19 14:09 ` Simon Horman
@ 2019-07-08 12:00 ` Geert Uytterhoeven
0 siblings, 0 replies; 3+ messages in thread
From: Geert Uytterhoeven @ 2019-07-08 12:00 UTC (permalink / raw)
To: Simon Horman; +Cc: Geert Uytterhoeven, Magnus Damm, Linux-Renesas
On Wed, Jun 19, 2019 at 4:09 PM Simon Horman <horms@verge.net.au> wrote:
> On Wed, Jun 19, 2019 at 02:46:37PM +0200, Geert Uytterhoeven wrote:
> > Flexible array members should be denoted using [] instead of [0], else
> > gcc will not warn when they are no longer at the end of the structure.
> >
> > Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
>
> Reviewed-by: Simon Horman <horms+renesas@verge.net.au>
Thanks, applied and queued for v5.4.
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2019-07-08 12:00 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-06-19 12:46 [PATCH] soc: renesas: rcar-sysc: Use [] to denote a flexible array member Geert Uytterhoeven
2019-06-19 14:09 ` Simon Horman
2019-07-08 12:00 ` Geert Uytterhoeven
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).