Re: [PATCH 2/2] max9286: Add MAX9286 driver

From: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
To: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
	Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
	linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/2] max9286: Add MAX9286 driver
Date: Fri, 9 Aug 2019 14:23:11 +0200	[thread overview]
Message-ID: <20190809122311.GF24385@bigcity.dyn.berto.se> (raw)
In-Reply-To: <8f5ce55a-666a-2350-b557-c275a69218c0@ideasonboard.com>

Hi Kieran,

On 2019-08-09 13:12:49 +0100, Kieran Bingham wrote:
> On 09/08/2019 13:04, Niklas Söderlund wrote:
> > Hi Kieran,
> > 
> > Thanks for your feedback.
> > 
> > On 2019-08-09 09:09:43 +0100, Kieran Bingham wrote:
> >> Hi Niklas,
> >>
> >> This should be at least v5.
> > 
> > I don't agree ;-) This is a "new" series where multiple streams are not 
> > supported and there are no external dependencies. To indicate this I 
> 
> I'm afraid there's nothing new about a version of this series with
> support for only a single stream.
> 
> See version 2 of my series:
> 
> https://lore.kernel.org/linux-media/20180808165559.29957-4-kieran.bingham@ideasonboard.com/

Was not aware of this posting, then yes I do agree with you this should 
have been v5. Sorry about that.

> 
> 
> > reset the version. I don't feel strongly about this next submission can 
> > remedy this if you do feel strongly about it.
> 
> I find it very confusing to have reset the version but kept exactly the
> same patch title.
> 
> It's a fork of the series :D

:-)

I think this proves we need to get this driver upstream so we can start 
submitting patches towards something and not brew our our brand of stuff 
we have laying around and find all over the place.

> 
> >> Did you take the last v4 and work from there?
> >> I have made changes since the last posting. Did you get an update from
> >> my branches?
> >>
> >> What changes have you made to this posting compared to whichever
> >> patch-base you have taken to start from?
> > 
> > I took my latest known good state and diffed it with all gmsl branches i 
> > could find picked what seamed most recent. Then I removed multiplexed 
> > stream support, fixed a few todos in error paths to clean up notifiers 
> > and unified naming of the private data structure.
> 
> 
> I'll diff your version with my latest.
> 
> There were other review comments worked on from Sakari too., and there
> is an outstanding comment from Rob to complete on the bindings from v4.
> 
> --
> Kieran
> 
> 
> 

-- 
Regards,
Niklas Söderlund