From: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
To: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>
Cc: Jacopo Mondi <jacopo+renesas@jmondi.org>,
Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>,
linux-media@vger.kernel.org, linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH 2/2] max9286: Add MAX9286 driver
Date: Fri, 9 Aug 2019 13:12:49 +0100 [thread overview]
Message-ID: <8f5ce55a-666a-2350-b557-c275a69218c0@ideasonboard.com> (raw)
In-Reply-To: <20190809120429.GE24385@bigcity.dyn.berto.se>
On 09/08/2019 13:04, Niklas Söderlund wrote:
> Hi Kieran,
>
> Thanks for your feedback.
>
> On 2019-08-09 09:09:43 +0100, Kieran Bingham wrote:
>> Hi Niklas,
>>
>> This should be at least v5.
>
> I don't agree ;-) This is a "new" series where multiple streams are not
> supported and there are no external dependencies. To indicate this I
I'm afraid there's nothing new about a version of this series with
support for only a single stream.
See version 2 of my series:
https://lore.kernel.org/linux-media/20180808165559.29957-4-kieran.bingham@ideasonboard.com/
> reset the version. I don't feel strongly about this next submission can
> remedy this if you do feel strongly about it.
I find it very confusing to have reset the version but kept exactly the
same patch title.
It's a fork of the series :D
>> Did you take the last v4 and work from there?
>> I have made changes since the last posting. Did you get an update from
>> my branches?
>>
>> What changes have you made to this posting compared to whichever
>> patch-base you have taken to start from?
>
> I took my latest known good state and diffed it with all gmsl branches i
> could find picked what seamed most recent. Then I removed multiplexed
> stream support, fixed a few todos in error paths to clean up notifiers
> and unified naming of the private data structure.
I'll diff your version with my latest.
There were other review comments worked on from Sakari too., and there
is an outstanding comment from Rob to complete on the bindings from v4.
--
Kieran
next prev parent reply other threads:[~2019-08-09 12:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-09 4:05 [PATCH 0/2] max9286: Add MAX9286 driver with single camera support Niklas Söderlund
2019-08-09 4:05 ` [PATCH 1/2] dt-bindings: media: i2c: Add bindings for Maxim Integrated MAX9286 Niklas Söderlund
2019-08-09 7:19 ` Geert Uytterhoeven
2019-08-09 8:04 ` Kieran Bingham
2019-08-09 4:05 ` [PATCH 2/2] max9286: Add MAX9286 driver Niklas Söderlund
2019-08-09 8:09 ` Kieran Bingham
2019-08-09 12:04 ` Niklas Söderlund
2019-08-09 12:12 ` Kieran Bingham [this message]
2019-08-09 12:23 ` Niklas Söderlund
2019-08-09 12:59 ` Kieran Bingham
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8f5ce55a-666a-2350-b557-c275a69218c0@ideasonboard.com \
--to=kieran.bingham+renesas@ideasonboard.com \
--cc=jacopo+renesas@jmondi.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).