Linux-Renesas-SoC Archive on lore.kernel.org
 help / color / Atom feed
From: Simon Horman <horms@verge.net.au>
To: Biju Das <biju.das@bp.renesas.com>
Cc: Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Geert Uytterhoeven <geert+renesas@glider.be>,
	Magnus Damm <magnus.damm@gmail.com>,
	linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org,
	Chris Paterson <Chris.Paterson2@renesas.com>,
	Fabrizio Castro <fabrizio.castro@bp.renesas.com>
Subject: Re: [PATCH 1/2] arm64: dts: renesas: r8a774c0: Create thermal zone to support IPA
Date: Fri, 13 Sep 2019 12:49:09 +0200
Message-ID: <20190913104909.toczyywsofv4s577@verge.net.au> (raw)
In-Reply-To: <1568364608-46548-1-git-send-email-biju.das@bp.renesas.com>

On Fri, Sep 13, 2019 at 09:50:07AM +0100, Biju Das wrote:
> Setup a thermal zone driven by SoC temperature sensor.
> Create passive trip points and bind them to CPUFreq cooling
> device that supports power extension.
> 
> Based on the work done by Dien Pham <dien.pham.ry@renesas.com>
> and others for r8a77990 SoC.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 19 ++++++++++++++++---
>  1 file changed, 16 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> index a1c2de9..764df4c 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> @@ -73,6 +73,7 @@
>  			compatible = "arm,cortex-a53";
>  			reg = <0>;
>  			device_type = "cpu";
> +			#cooling-cells = <2>;
>  			power-domains = <&sysc R8A774C0_PD_CA53_CPU0>;
>  			next-level-cache = <&L2_CA53>;
>  			enable-method = "psci";
> @@ -1905,18 +1906,30 @@
>  	thermal-zones {
>  		cpu-thermal {
>  			polling-delay-passive = <250>;
> -			polling-delay = <1000>;
> -			thermal-sensors = <&thermal>;
> +			polling-delay = <0>;
> +			thermal-sensors = <&thermal 0>;
> +			sustainable-power = <717>;
>  
>  			cooling-maps {
> +				map0 {
> +					trip = <&target>;
> +					cooling-device = <&a53_0 0 2>;
> +					contribution = <1024>;
> +				};
>  			};
>  
>  			trips {
> -				cpu-crit {
> +				sensor1_crit: sensor1-crit {
>  					temperature = <120000>;
>  					hysteresis = <2000>;
>  					type = "critical";
>  				};
> +
> +				target: trip-point1 {
> +					temperature = <100000>;
> +					hysteresis = <2000>;
> +					type = "passive";
> +				};
>  			};
>  		};
>  	};
> -- 
> 2.7.4
> 

      parent reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-13  8:50 Biju Das
2019-09-13  8:50 ` [PATCH 2/2] arm64: dts: renesas: r8a774c0: Add dynamic power coefficient Biju Das
2019-09-13 10:49   ` Simon Horman
2019-09-13 10:49 ` Simon Horman [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20190913104909.toczyywsofv4s577@verge.net.au \
    --to=horms@verge.net.au \
    --cc=Chris.Paterson2@renesas.com \
    --cc=biju.das@bp.renesas.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabrizio.castro@bp.renesas.com \
    --cc=geert+renesas@glider.be \
    --cc=linux-renesas-soc@vger.kernel.org \
    --cc=magnus.damm@gmail.com \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Renesas-SoC Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-renesas-soc/0 linux-renesas-soc/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-renesas-soc linux-renesas-soc/ https://lore.kernel.org/linux-renesas-soc \
		linux-renesas-soc@vger.kernel.org linux-renesas-soc@archiver.kernel.org
	public-inbox-index linux-renesas-soc


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-renesas-soc


AGPL code for this site: git clone https://public-inbox.org/ public-inbox