linux-renesas-soc.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH 1/2] arm64: dts: renesas: r8a774c0: Create thermal zone to support IPA
@ 2019-09-13  8:50 Biju Das
  2019-09-13  8:50 ` [PATCH 2/2] arm64: dts: renesas: r8a774c0: Add dynamic power coefficient Biju Das
                   ` (2 more replies)
  0 siblings, 3 replies; 6+ messages in thread
From: Biju Das @ 2019-09-13  8:50 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland
  Cc: Biju Das, Geert Uytterhoeven, Simon Horman, Magnus Damm,
	linux-renesas-soc, devicetree, Chris Paterson, Fabrizio Castro

Setup a thermal zone driven by SoC temperature sensor.
Create passive trip points and bind them to CPUFreq cooling
device that supports power extension.

Based on the work done by Dien Pham <dien.pham.ry@renesas.com>
and others for r8a77990 SoC.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 19 ++++++++++++++++---
 1 file changed, 16 insertions(+), 3 deletions(-)

diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
index a1c2de9..764df4c 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
@@ -73,6 +73,7 @@
 			compatible = "arm,cortex-a53";
 			reg = <0>;
 			device_type = "cpu";
+			#cooling-cells = <2>;
 			power-domains = <&sysc R8A774C0_PD_CA53_CPU0>;
 			next-level-cache = <&L2_CA53>;
 			enable-method = "psci";
@@ -1905,18 +1906,30 @@
 	thermal-zones {
 		cpu-thermal {
 			polling-delay-passive = <250>;
-			polling-delay = <1000>;
-			thermal-sensors = <&thermal>;
+			polling-delay = <0>;
+			thermal-sensors = <&thermal 0>;
+			sustainable-power = <717>;
 
 			cooling-maps {
+				map0 {
+					trip = <&target>;
+					cooling-device = <&a53_0 0 2>;
+					contribution = <1024>;
+				};
 			};
 
 			trips {
-				cpu-crit {
+				sensor1_crit: sensor1-crit {
 					temperature = <120000>;
 					hysteresis = <2000>;
 					type = "critical";
 				};
+
+				target: trip-point1 {
+					temperature = <100000>;
+					hysteresis = <2000>;
+					type = "passive";
+				};
 			};
 		};
 	};
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* [PATCH 2/2] arm64: dts: renesas: r8a774c0: Add dynamic power coefficient
  2019-09-13  8:50 [PATCH 1/2] arm64: dts: renesas: r8a774c0: Create thermal zone to support IPA Biju Das
@ 2019-09-13  8:50 ` Biju Das
  2019-09-13 10:49   ` Simon Horman
  2019-09-16  7:42   ` Geert Uytterhoeven
  2019-09-13 10:49 ` [PATCH 1/2] arm64: dts: renesas: r8a774c0: Create thermal zone to support IPA Simon Horman
  2019-09-16  7:41 ` Geert Uytterhoeven
  2 siblings, 2 replies; 6+ messages in thread
From: Biju Das @ 2019-09-13  8:50 UTC (permalink / raw)
  To: Rob Herring, Mark Rutland
  Cc: Biju Das, Geert Uytterhoeven, Simon Horman, Magnus Damm,
	linux-renesas-soc, devicetree, Chris Paterson, Fabrizio Castro

Describe the dynamic power coefficient of A53 CPUs.

Based on work by Gaku Inami <gaku.inami.xw@bp.renesas.com> and others.

Signed-off-by: Biju Das <biju.das@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
index 764df4c..c7bdc36 100644
--- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
+++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
@@ -77,6 +77,7 @@
 			power-domains = <&sysc R8A774C0_PD_CA53_CPU0>;
 			next-level-cache = <&L2_CA53>;
 			enable-method = "psci";
+			dynamic-power-coefficient = <277>;
 			clocks = <&cpg CPG_CORE R8A774C0_CLK_Z2>;
 			operating-points-v2 = <&cluster1_opp>;
 		};
-- 
2.7.4


^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] arm64: dts: renesas: r8a774c0: Create thermal zone to support IPA
  2019-09-13  8:50 [PATCH 1/2] arm64: dts: renesas: r8a774c0: Create thermal zone to support IPA Biju Das
  2019-09-13  8:50 ` [PATCH 2/2] arm64: dts: renesas: r8a774c0: Add dynamic power coefficient Biju Das
@ 2019-09-13 10:49 ` Simon Horman
  2019-09-16  7:41 ` Geert Uytterhoeven
  2 siblings, 0 replies; 6+ messages in thread
From: Simon Horman @ 2019-09-13 10:49 UTC (permalink / raw)
  To: Biju Das
  Cc: Rob Herring, Mark Rutland, Geert Uytterhoeven, Magnus Damm,
	linux-renesas-soc, devicetree, Chris Paterson, Fabrizio Castro

On Fri, Sep 13, 2019 at 09:50:07AM +0100, Biju Das wrote:
> Setup a thermal zone driven by SoC temperature sensor.
> Create passive trip points and bind them to CPUFreq cooling
> device that supports power extension.
> 
> Based on the work done by Dien Pham <dien.pham.ry@renesas.com>
> and others for r8a77990 SoC.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>

> ---
>  arch/arm64/boot/dts/renesas/r8a774c0.dtsi | 19 ++++++++++++++++---
>  1 file changed, 16 insertions(+), 3 deletions(-)
> 
> diff --git a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> index a1c2de9..764df4c 100644
> --- a/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> +++ b/arch/arm64/boot/dts/renesas/r8a774c0.dtsi
> @@ -73,6 +73,7 @@
>  			compatible = "arm,cortex-a53";
>  			reg = <0>;
>  			device_type = "cpu";
> +			#cooling-cells = <2>;
>  			power-domains = <&sysc R8A774C0_PD_CA53_CPU0>;
>  			next-level-cache = <&L2_CA53>;
>  			enable-method = "psci";
> @@ -1905,18 +1906,30 @@
>  	thermal-zones {
>  		cpu-thermal {
>  			polling-delay-passive = <250>;
> -			polling-delay = <1000>;
> -			thermal-sensors = <&thermal>;
> +			polling-delay = <0>;
> +			thermal-sensors = <&thermal 0>;
> +			sustainable-power = <717>;
>  
>  			cooling-maps {
> +				map0 {
> +					trip = <&target>;
> +					cooling-device = <&a53_0 0 2>;
> +					contribution = <1024>;
> +				};
>  			};
>  
>  			trips {
> -				cpu-crit {
> +				sensor1_crit: sensor1-crit {
>  					temperature = <120000>;
>  					hysteresis = <2000>;
>  					type = "critical";
>  				};
> +
> +				target: trip-point1 {
> +					temperature = <100000>;
> +					hysteresis = <2000>;
> +					type = "passive";
> +				};
>  			};
>  		};
>  	};
> -- 
> 2.7.4
> 

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] arm64: dts: renesas: r8a774c0: Add dynamic power coefficient
  2019-09-13  8:50 ` [PATCH 2/2] arm64: dts: renesas: r8a774c0: Add dynamic power coefficient Biju Das
@ 2019-09-13 10:49   ` Simon Horman
  2019-09-16  7:42   ` Geert Uytterhoeven
  1 sibling, 0 replies; 6+ messages in thread
From: Simon Horman @ 2019-09-13 10:49 UTC (permalink / raw)
  To: Biju Das
  Cc: Rob Herring, Mark Rutland, Geert Uytterhoeven, Magnus Damm,
	linux-renesas-soc, devicetree, Chris Paterson, Fabrizio Castro

On Fri, Sep 13, 2019 at 09:50:08AM +0100, Biju Das wrote:
> Describe the dynamic power coefficient of A53 CPUs.
> 
> Based on work by Gaku Inami <gaku.inami.xw@bp.renesas.com> and others.
> 
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Simon Horman <horms+renesas@verge.net.au>


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 1/2] arm64: dts: renesas: r8a774c0: Create thermal zone to support IPA
  2019-09-13  8:50 [PATCH 1/2] arm64: dts: renesas: r8a774c0: Create thermal zone to support IPA Biju Das
  2019-09-13  8:50 ` [PATCH 2/2] arm64: dts: renesas: r8a774c0: Add dynamic power coefficient Biju Das
  2019-09-13 10:49 ` [PATCH 1/2] arm64: dts: renesas: r8a774c0: Create thermal zone to support IPA Simon Horman
@ 2019-09-16  7:41 ` Geert Uytterhoeven
  2 siblings, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2019-09-16  7:41 UTC (permalink / raw)
  To: Biju Das
  Cc: Rob Herring, Mark Rutland, Geert Uytterhoeven, Simon Horman,
	Magnus Damm, Linux-Renesas,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Chris Paterson, Fabrizio Castro

On Fri, Sep 13, 2019 at 10:57 AM Biju Das <biju.das@bp.renesas.com> wrote:
> Setup a thermal zone driven by SoC temperature sensor.
> Create passive trip points and bind them to CPUFreq cooling
> device that supports power extension.
>
> Based on the work done by Dien Pham <dien.pham.ry@renesas.com>
> and others for r8a77990 SoC.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.5.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH 2/2] arm64: dts: renesas: r8a774c0: Add dynamic power coefficient
  2019-09-13  8:50 ` [PATCH 2/2] arm64: dts: renesas: r8a774c0: Add dynamic power coefficient Biju Das
  2019-09-13 10:49   ` Simon Horman
@ 2019-09-16  7:42   ` Geert Uytterhoeven
  1 sibling, 0 replies; 6+ messages in thread
From: Geert Uytterhoeven @ 2019-09-16  7:42 UTC (permalink / raw)
  To: Biju Das
  Cc: Rob Herring, Mark Rutland, Geert Uytterhoeven, Simon Horman,
	Magnus Damm, Linux-Renesas,
	open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS,
	Chris Paterson, Fabrizio Castro

On Fri, Sep 13, 2019 at 10:57 AM Biju Das <biju.das@bp.renesas.com> wrote:
> Describe the dynamic power coefficient of A53 CPUs.
>
> Based on work by Gaku Inami <gaku.inami.xw@bp.renesas.com> and others.
>
> Signed-off-by: Biju Das <biju.das@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
i.e. will queue in renesas-devel for v5.5.

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2019-09-16  7:42 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-09-13  8:50 [PATCH 1/2] arm64: dts: renesas: r8a774c0: Create thermal zone to support IPA Biju Das
2019-09-13  8:50 ` [PATCH 2/2] arm64: dts: renesas: r8a774c0: Add dynamic power coefficient Biju Das
2019-09-13 10:49   ` Simon Horman
2019-09-16  7:42   ` Geert Uytterhoeven
2019-09-13 10:49 ` [PATCH 1/2] arm64: dts: renesas: r8a774c0: Create thermal zone to support IPA Simon Horman
2019-09-16  7:41 ` Geert Uytterhoeven

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).