Re: [PATCH v2 0/2] Add definition for GPIO direction

Re: [PATCH v2 0/2] Add definition for GPIO direction

[Linus Walleij]

On Wed, Nov 6, 2019 at 3:25 PM andriy.shevchenko@linux.intel.com
<andriy.shevchenko@linux.intel.com> wrote:
> On Wed, Nov 06, 2019 at 12:25:18PM +0000, Vaittinen, Matti wrote:

> > If no one
> > else will take the pinctrl part then I can probably do pinctrl patches
> > for v5.6 cycle.
>
> For pin control Intel, since we send PR to Linus and it won't be different to
> him, we would like to see patch per driver.

It is generally good to bundle these changes because so many
driver maintainers are passive. (Not Intel!)

If you are concerned, what about we just make a separate patch
for the drivers under drivers/pinctrl/intel and bundle the rest?
Possibly Geert want the sh-pfc changes separately as well
as he build his own pinctrl changes.

Rough consensus and working patches.

Yours,
Linus Walleij

Re: [PATCH v2 0/2] Add definition for GPIO direction

[Geert Uytterhoeven]

Hi Linus,

On Thu, Nov 7, 2019 at 9:26 AM Linus Walleij <linus.walleij@linaro.org> wrote:
> On Wed, Nov 6, 2019 at 3:25 PM andriy.shevchenko@linux.intel.com
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Nov 06, 2019 at 12:25:18PM +0000, Vaittinen, Matti wrote:
>
> > > If no one
> > > else will take the pinctrl part then I can probably do pinctrl patches
> > > for v5.6 cycle.
> >
> > For pin control Intel, since we send PR to Linus and it won't be different to
> > him, we would like to see patch per driver.
>
> It is generally good to bundle these changes because so many
> driver maintainers are passive. (Not Intel!)
>
> If you are concerned, what about we just make a separate patch
> for the drivers under drivers/pinctrl/intel and bundle the rest?
> Possibly Geert want the sh-pfc changes separately as well
> as he build his own pinctrl changes.

I guess the sh-pfc change would be small, and limited to a part of the code
that isn't touched regularly?
So that means it can go in with the rest, bypassing me (but please CC me).
Thanks!

Gr{oetje,eeting}s,

                        Geert

-- 
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH v2 0/2] Add definition for GPIO direction

[Vaittinen, Matti]

On Thu, 2019-11-07 at 09:26 +0100, Linus Walleij wrote:
> On Wed, Nov 6, 2019 at 3:25 PM andriy.shevchenko@linux.intel.com
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Nov 06, 2019 at 12:25:18PM +0000, Vaittinen, Matti wrote:
> > > If no one
> > > else will take the pinctrl part then I can probably do pinctrl
> > > patches
> > > for v5.6 cycle.
> > 
> > For pin control Intel, since we send PR to Linus and it won't be
> > different to
> > him, we would like to see patch per driver.
> 
> It is generally good to bundle these changes because so many
> driver maintainers are passive. (Not Intel!)

That reminded me.. I got 'unknown recipient' replies
<nandor.han@ge.com>: 550 5.1.1 No such user - pp
<semi.malinen@ge.com>: 550 5.1.1 No such user - pp

from both Semi and Nandor - who seem to be the only maintainers listed
for XRA1403 GPIO EXPANDER in MAINTAINERS.

XRA1403 GPIO EXPANDER
M:      Nandor Han <nandor.han@ge.com>
M:      Semi Malinen <semi.malinen@ge.com>
L:      linux-gpio@vger.kernel.org
S:      Maintained
F:      drivers/gpio/gpio-xra1403.c
F:      Documentation/devicetree/bindings/gpio/gpio-xra1403.txt

Anyone knows new mail addresses or perhaps the separate entry
for XRA1403 should be removed? 

> If you are concerned, what about we just make a separate patch
> for the drivers under drivers/pinctrl/intel and bundle the rest?
> Possibly Geert want the sh-pfc changes separately as well
> as he build his own pinctrl changes.
> 
> Rough consensus and working patches.

In general - Which one is harder? xD

But this works for me.

Br,
	Matti Vaittinen

Re: [PATCH v2 0/2] Add definition for GPIO direction

[andriy.shevchenko]

On Thu, Nov 07, 2019 at 09:26:43AM +0100, Linus Walleij wrote:
> On Wed, Nov 6, 2019 at 3:25 PM andriy.shevchenko@linux.intel.com
> <andriy.shevchenko@linux.intel.com> wrote:
> > On Wed, Nov 06, 2019 at 12:25:18PM +0000, Vaittinen, Matti wrote:

> > For pin control Intel, since we send PR to Linus and it won't be different to
> > him, we would like to see patch per driver.
> 
> It is generally good to bundle these changes because so many
> driver maintainers are passive. (Not Intel!)
> 
> If you are concerned, what about we just make a separate patch
> for the drivers under drivers/pinctrl/intel and bundle the rest?

Fine with me!

-- 
With Best Regards,
Andy Shevchenko

Re: [PATCH v2 0/2] Add definition for GPIO direction

[Sebastian Reichel]

[-- Attachment #1: Type: text/plain, Size: 841 bytes --]

Hi,

On Thu, Nov 07, 2019 at 08:52:11AM +0000, Vaittinen, Matti wrote:
> That reminded me.. I got 'unknown recipient' replies
> <nandor.han@ge.com>: 550 5.1.1 No such user - pp
> <semi.malinen@ge.com>: 550 5.1.1 No such user - pp
> 
> from both Semi and Nandor - who seem to be the only maintainers listed
> for XRA1403 GPIO EXPANDER in MAINTAINERS.
> 
> XRA1403 GPIO EXPANDER
> M:      Nandor Han <nandor.han@ge.com>
> M:      Semi Malinen <semi.malinen@ge.com>
> L:      linux-gpio@vger.kernel.org
> S:      Maintained
> F:      drivers/gpio/gpio-xra1403.c
> F:      Documentation/devicetree/bindings/gpio/gpio-xra1403.txt
> 
> Anyone knows new mail addresses or perhaps the separate entry
> for XRA1403 should be removed?

+cc new mail address from Nandor Han
+cc Ian Ray with valid GE mail address

-- Sebastian

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

Re: [PATCH v2 0/2] Add definition for GPIO direction

[Nandor Han]

On 11/7/19 2:08 PM, Sebastian Reichel wrote:
> Hi,
> 
> On Thu, Nov 07, 2019 at 08:52:11AM +0000, Vaittinen, Matti wrote:
>> That reminded me.. I got 'unknown recipient' replies
>> <nandor.han@ge.com>: 550 5.1.1 No such user - pp
>> <semi.malinen@ge.com>: 550 5.1.1 No such user - pp
>>
>> from both Semi and Nandor - who seem to be the only maintainers listed
>> for XRA1403 GPIO EXPANDER in MAINTAINERS.
>>
>> XRA1403 GPIO EXPANDER
>> M:      Nandor Han <nandor.han@ge.com>
>> M:      Semi Malinen <semi.malinen@ge.com>
>> L:      linux-gpio@vger.kernel.org
>> S:      Maintained
>> F:      drivers/gpio/gpio-xra1403.c
>> F:      Documentation/devicetree/bindings/gpio/gpio-xra1403.txt
>>
>> Anyone knows new mail addresses or perhaps the separate entry
>> for XRA1403 should be removed?
> 
> +cc new mail address from Nandor Han
> +cc Ian Ray with valid GE mail address
> 
> -- Sebastian
> 

Thanks Sebastian.

Matti, I did review the gpio-xra1403 changes and LGTM.

According with the datasheet, 1 means direction input:

XRA1403 datasheet (https://www.maxlinear.com/ds/xra1403_100_092011.pdf)
```
  Setting these bits to ’1’ will enable the GPIOs as inputs.
```

Note: I will update also the maintainers list.

Nandor