[PATCH v2] drm: shmobile: Reduce include dependencies

[PATCH v2] drm: shmobile: Reduce include dependencies

[Andy Shevchenko]

This file doesn't need everything provided by <linux/kernel.h>.
All it needs are some types, which are provided by <linux/types.h>.

Note, <drm/drm_mode.h> already includes <linux/types.h>, but
not relying on implicit includes is indeed a good thing.

Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v2: Update commit message (Geert, Laurent)
 include/linux/platform_data/shmob_drm.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h
index fe815d7d9f58..08605fdb2226 100644
--- a/include/linux/platform_data/shmob_drm.h
+++ b/include/linux/platform_data/shmob_drm.h
@@ -10,7 +10,7 @@
 #ifndef __SHMOB_DRM_H__
 #define __SHMOB_DRM_H__
 
-#include <linux/kernel.h>
+#include <linux/types.h>
 
 #include <drm/drm_mode.h>
 
-- 
2.24.1

Re: [PATCH v2] drm: shmobile: Reduce include dependencies

[Kieran Bingham]

Hi Andy,

On 05/02/2020 09:32, Andy Shevchenko wrote:
> This file doesn't need everything provided by <linux/kernel.h>.
> All it needs are some types, which are provided by <linux/types.h>.
> 
> Note, <drm/drm_mode.h> already includes <linux/types.h>, but
> not relying on implicit includes is indeed a good thing.

This explains things a bit better :-)

I'm sure the others will follow too, but here's my:

Reviewed-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: Update commit message (Geert, Laurent)
>  include/linux/platform_data/shmob_drm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h
> index fe815d7d9f58..08605fdb2226 100644
> --- a/include/linux/platform_data/shmob_drm.h
> +++ b/include/linux/platform_data/shmob_drm.h
> @@ -10,7 +10,7 @@
>  #ifndef __SHMOB_DRM_H__
>  #define __SHMOB_DRM_H__
>  
> -#include <linux/kernel.h>
> +#include <linux/types.h>
>  
>  #include <drm/drm_mode.h>
>  
> 

Re: [PATCH v2] drm: shmobile: Reduce include dependencies

[Laurent Pinchart]

Hi Andy,

Thank you for the patch.

On Wed, Feb 05, 2020 at 11:32:26AM +0200, Andy Shevchenko wrote:
> This file doesn't need everything provided by <linux/kernel.h>.
> All it needs are some types, which are provided by <linux/types.h>.
> 
> Note, <drm/drm_mode.h> already includes <linux/types.h>, but
> not relying on implicit includes is indeed a good thing.

Do we even need linux/types.h ? Apart from struct drm_mode_modeinfo,
shmob_drm.h seems to only contain plain C without using any externally
defined types.

> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v2: Update commit message (Geert, Laurent)
>  include/linux/platform_data/shmob_drm.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h
> index fe815d7d9f58..08605fdb2226 100644
> --- a/include/linux/platform_data/shmob_drm.h
> +++ b/include/linux/platform_data/shmob_drm.h
> @@ -10,7 +10,7 @@
>  #ifndef __SHMOB_DRM_H__
>  #define __SHMOB_DRM_H__
>  
> -#include <linux/kernel.h>
> +#include <linux/types.h>
>  
>  #include <drm/drm_mode.h>
>  

-- 
Regards,

Laurent Pinchart

Re: [PATCH v2] drm: shmobile: Reduce include dependencies

[Andy Shevchenko]

On Wed, Feb 05, 2020 at 07:33:22PM +0200, Laurent Pinchart wrote:
> Hi Andy,
> 
> Thank you for the patch.
> 
> On Wed, Feb 05, 2020 at 11:32:26AM +0200, Andy Shevchenko wrote:
> > This file doesn't need everything provided by <linux/kernel.h>.
> > All it needs are some types, which are provided by <linux/types.h>.
> > 
> > Note, <drm/drm_mode.h> already includes <linux/types.h>, but
> > not relying on implicit includes is indeed a good thing.
> 
> Do we even need linux/types.h ? Apart from struct drm_mode_modeinfo,
> shmob_drm.h seems to only contain plain C without using any externally
> defined types.

Good point. It doesn't contain neither bool nor uXX or alike types.
Probably we may simple drop the inclusion. I'll send v3.

-- 
With Best Regards,
Andy Shevchenko