* [PATCH v3] drm: shmobile: Reduce include dependencies
@ 2020-02-06 11:12 Andy Shevchenko
2020-02-24 9:04 ` Andy Shevchenko
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2020-02-06 11:12 UTC (permalink / raw)
To: Laurent Pinchart, Kieran Bingham, dri-devel, linux-renesas-soc,
Geert Uytterhoeven
Cc: Andy Shevchenko
This file doesn't need everything provided by <linux/kernel.h>.
All it needs are some types, which are provided by <drm/drm_mode.h>.
Drop unneeded <linux/kernel.h> completely.
Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
---
v3: Drop header completely (Laurent)
include/linux/platform_data/shmob_drm.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h
index fe815d7d9f58..d661399b217d 100644
--- a/include/linux/platform_data/shmob_drm.h
+++ b/include/linux/platform_data/shmob_drm.h
@@ -10,8 +10,6 @@
#ifndef __SHMOB_DRM_H__
#define __SHMOB_DRM_H__
-#include <linux/kernel.h>
-
#include <drm/drm_mode.h>
enum shmob_drm_clk_source {
--
2.24.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v3] drm: shmobile: Reduce include dependencies
2020-02-06 11:12 [PATCH v3] drm: shmobile: Reduce include dependencies Andy Shevchenko
@ 2020-02-24 9:04 ` Andy Shevchenko
2020-02-26 1:44 ` Laurent Pinchart
0 siblings, 1 reply; 4+ messages in thread
From: Andy Shevchenko @ 2020-02-24 9:04 UTC (permalink / raw)
To: Laurent Pinchart, Kieran Bingham, dri-devel, linux-renesas-soc,
Geert Uytterhoeven
On Thu, Feb 06, 2020 at 01:12:32PM +0200, Andy Shevchenko wrote:
> This file doesn't need everything provided by <linux/kernel.h>.
> All it needs are some types, which are provided by <drm/drm_mode.h>.
>
> Drop unneeded <linux/kernel.h> completely.
Any comments on this?
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> v3: Drop header completely (Laurent)
> include/linux/platform_data/shmob_drm.h | 2 --
> 1 file changed, 2 deletions(-)
>
> diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h
> index fe815d7d9f58..d661399b217d 100644
> --- a/include/linux/platform_data/shmob_drm.h
> +++ b/include/linux/platform_data/shmob_drm.h
> @@ -10,8 +10,6 @@
> #ifndef __SHMOB_DRM_H__
> #define __SHMOB_DRM_H__
>
> -#include <linux/kernel.h>
> -
> #include <drm/drm_mode.h>
>
> enum shmob_drm_clk_source {
> --
> 2.24.1
>
--
With Best Regards,
Andy Shevchenko
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] drm: shmobile: Reduce include dependencies
2020-02-24 9:04 ` Andy Shevchenko
@ 2020-02-26 1:44 ` Laurent Pinchart
2020-10-13 14:20 ` Imre Deak
0 siblings, 1 reply; 4+ messages in thread
From: Laurent Pinchart @ 2020-02-26 1:44 UTC (permalink / raw)
To: Andy Shevchenko
Cc: Kieran Bingham, dri-devel, linux-renesas-soc, Geert Uytterhoeven
Hi Andy,
Thank you for the patch, and sorry for the delay.
On Mon, Feb 24, 2020 at 11:04:30AM +0200, Andy Shevchenko wrote:
> On Thu, Feb 06, 2020 at 01:12:32PM +0200, Andy Shevchenko wrote:
> > This file doesn't need everything provided by <linux/kernel.h>.
s/everything/anything/
> > All it needs are some types, which are provided by <drm/drm_mode.h>.
> >
> > Drop unneeded <linux/kernel.h> completely.
>
> Any comments on this?
Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Feel free to push :-)
> > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > ---
> > v3: Drop header completely (Laurent)
> > include/linux/platform_data/shmob_drm.h | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h
> > index fe815d7d9f58..d661399b217d 100644
> > --- a/include/linux/platform_data/shmob_drm.h
> > +++ b/include/linux/platform_data/shmob_drm.h
> > @@ -10,8 +10,6 @@
> > #ifndef __SHMOB_DRM_H__
> > #define __SHMOB_DRM_H__
> >
> > -#include <linux/kernel.h>
> > -
> > #include <drm/drm_mode.h>
> >
> > enum shmob_drm_clk_source {
--
Regards,
Laurent Pinchart
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v3] drm: shmobile: Reduce include dependencies
2020-02-26 1:44 ` Laurent Pinchart
@ 2020-10-13 14:20 ` Imre Deak
0 siblings, 0 replies; 4+ messages in thread
From: Imre Deak @ 2020-10-13 14:20 UTC (permalink / raw)
To: Andriy Shevchenko, Laurent Pinchart
Cc: linux-renesas-soc, Kieran Bingham, Geert Uytterhoeven, dri-devel
On Wed, Feb 26, 2020 at 03:44:06AM +0200, Laurent Pinchart wrote:
> Hi Andy,
>
> Thank you for the patch, and sorry for the delay.
>
> On Mon, Feb 24, 2020 at 11:04:30AM +0200, Andy Shevchenko wrote:
> > On Thu, Feb 06, 2020 at 01:12:32PM +0200, Andy Shevchenko wrote:
> > > This file doesn't need everything provided by <linux/kernel.h>.
>
> s/everything/anything/
>
> > > All it needs are some types, which are provided by <drm/drm_mode.h>.
> > >
> > > Drop unneeded <linux/kernel.h> completely.
> >
> > Any comments on this?
>
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
>
> Feel free to push :-)
Pushed to drm-misc-next, thanks for the patch and review.
>
> > > Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> > > ---
> > > v3: Drop header completely (Laurent)
> > > include/linux/platform_data/shmob_drm.h | 2 --
> > > 1 file changed, 2 deletions(-)
> > >
> > > diff --git a/include/linux/platform_data/shmob_drm.h b/include/linux/platform_data/shmob_drm.h
> > > index fe815d7d9f58..d661399b217d 100644
> > > --- a/include/linux/platform_data/shmob_drm.h
> > > +++ b/include/linux/platform_data/shmob_drm.h
> > > @@ -10,8 +10,6 @@
> > > #ifndef __SHMOB_DRM_H__
> > > #define __SHMOB_DRM_H__
> > >
> > > -#include <linux/kernel.h>
> > > -
> > > #include <drm/drm_mode.h>
> > >
> > > enum shmob_drm_clk_source {
>
> --
> Regards,
>
> Laurent Pinchart
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2020-10-13 14:20 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-06 11:12 [PATCH v3] drm: shmobile: Reduce include dependencies Andy Shevchenko
2020-02-24 9:04 ` Andy Shevchenko
2020-02-26 1:44 ` Laurent Pinchart
2020-10-13 14:20 ` Imre Deak
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).