From: Bjorn Helgaas <helgaas@kernel.org>
To: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
Cc: marek.vasut@gmail.com, linux-pci@vger.kernel.org,
Marek Vasut <marek.vasut+renesas@gmail.com>,
Bjorn Helgaas <bhelgaas@google.com>,
Geert Uytterhoeven <geert+renesas@glider.be>,
Wolfram Sang <wsa@the-dreams.de>,
linux-renesas-soc@vger.kernel.org
Subject: Re: [PATCH] PCI: pcie-rcar: Cache PHY init function pointer
Date: Fri, 1 May 2020 16:52:28 -0500 [thread overview]
Message-ID: <20200501215228.GA136733@bjorn-Precision-5520> (raw)
In-Reply-To: <20200428083231.GC12459@e121166-lin.cambridge.arm.com>
On Tue, Apr 28, 2020 at 09:32:31AM +0100, Lorenzo Pieralisi wrote:
> On Sun, Apr 26, 2020 at 02:31:47PM +0200, marek.vasut@gmail.com wrote:
> > From: Marek Vasut <marek.vasut+renesas@gmail.com>
> >
> > The PHY initialization function pointer does not change during the
> > lifetime of the driver instance, it is therefore sufficient to get
> > the pointer in .probe(), cache it in driver private data, and just
> > call the function through the cached pointer in .resume().
> >
> > Signed-off-by: Marek Vasut <marek.vasut+renesas@gmail.com>
> > Cc: Bjorn Helgaas <bhelgaas@google.com>
> > Cc: Lorenzo Pieralisi <lorenzo.pieralisi@arm.com>
> > Cc: Geert Uytterhoeven <geert+renesas@glider.be>
> > Cc: Wolfram Sang <wsa@the-dreams.de>
> > Cc: linux-renesas-soc@vger.kernel.org
> > ---
> > NOTE: Based on git://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/pci.git
> > branch pci/rcar
> > NOTE: The driver tag is now 'pcie-rcar' to distinguish it from pci-rcar-gen2.c
> > ---
> > drivers/pci/controller/pcie-rcar.c | 10 ++++------
> > 1 file changed, 4 insertions(+), 6 deletions(-)
>
> Squashed in https://patchwork.kernel.org/patch/11438665
>
> Do you want me to rename the $SUBJECT (and the branch name while at it)
> in the patches in my pci/rcar branch ("PCI: pcie-rcar: ...") to start
> the commit subject tag renaming from this cycle (and in the interim you
> send a rename for the drivers files ?)
My vote is a tag of "rcar" for the pcie-rcar driver because almost all
new drivers are PCIe, and none of the others use "pcie-" in the tag.
For pci-rcar-gen2.c, we could use "rcar-gen2" (already used by the
last 5 commits, last touched over two years ago). It's slightly
confusing to use "gen2" to refer to some internal R-Car thing instead
of PCIe Gen 2, so we could use something like "rcar-pci", but I'm not
sure it's worth it.
Bjorn
prev parent reply other threads:[~2020-05-01 21:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-26 12:31 [PATCH] PCI: pcie-rcar: Cache PHY init function pointer marek.vasut
2020-04-27 7:19 ` Geert Uytterhoeven
2020-04-28 8:32 ` Lorenzo Pieralisi
2020-05-01 20:42 ` Marek Vasut
2020-05-05 18:02 ` Lorenzo Pieralisi
2020-05-05 18:35 ` Marek Vasut
2020-05-06 8:57 ` Lorenzo Pieralisi
2020-05-06 9:02 ` Geert Uytterhoeven
2020-05-06 9:19 ` Lorenzo Pieralisi
2020-05-06 10:22 ` Geert Uytterhoeven
2020-05-06 15:33 ` Lorenzo Pieralisi
2020-05-06 16:59 ` Bjorn Helgaas
2020-05-01 21:52 ` Bjorn Helgaas [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200501215228.GA136733@bjorn-Precision-5520 \
--to=helgaas@kernel.org \
--cc=bhelgaas@google.com \
--cc=geert+renesas@glider.be \
--cc=linux-pci@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=lorenzo.pieralisi@arm.com \
--cc=marek.vasut+renesas@gmail.com \
--cc=marek.vasut@gmail.com \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).