* [PATCH] i2c: add Kconfig help text for slave mode
@ 2020-06-28 18:55 Wolfram Sang
2020-06-28 22:13 ` Niklas Söderlund
` (2 more replies)
0 siblings, 3 replies; 7+ messages in thread
From: Wolfram Sang @ 2020-06-28 18:55 UTC (permalink / raw)
To: linux-i2c; +Cc: linux-renesas-soc, Wolfram Sang
I can't recall why there was none, but we surely want to have it.
Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
---
drivers/i2c/Kconfig | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
index dbcbb8a6024e..e2d6063bdb4d 100644
--- a/drivers/i2c/Kconfig
+++ b/drivers/i2c/Kconfig
@@ -114,6 +114,11 @@ config I2C_STUB
config I2C_SLAVE
bool "I2C slave support"
+ help
+ This enables Linux to act as an I2C slave device. Note that your I2C
+ bus master driver also needs to support this functionality. Please
+ read Documentation/i2c/slave-interface.rst for further details.
+
if I2C_SLAVE
config I2C_SLAVE_EEPROM
--
2.20.1
^ permalink raw reply related [flat|nested] 7+ messages in thread
* Re: [PATCH] i2c: add Kconfig help text for slave mode
2020-06-28 18:55 [PATCH] i2c: add Kconfig help text for slave mode Wolfram Sang
@ 2020-06-28 22:13 ` Niklas Söderlund
2020-06-29 7:51 ` Geert Uytterhoeven
2020-07-04 6:17 ` Wolfram Sang
2 siblings, 0 replies; 7+ messages in thread
From: Niklas Söderlund @ 2020-06-28 22:13 UTC (permalink / raw)
To: Wolfram Sang; +Cc: linux-i2c, linux-renesas-soc
Hi Wolfram,
Thanks for your patch.
On 2020-06-28 20:55:22 +0200, Wolfram Sang wrote:
> I can't recall why there was none, but we surely want to have it.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
> drivers/i2c/Kconfig | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/drivers/i2c/Kconfig b/drivers/i2c/Kconfig
> index dbcbb8a6024e..e2d6063bdb4d 100644
> --- a/drivers/i2c/Kconfig
> +++ b/drivers/i2c/Kconfig
> @@ -114,6 +114,11 @@ config I2C_STUB
> config I2C_SLAVE
> bool "I2C slave support"
>
> + help
> + This enables Linux to act as an I2C slave device. Note that your I2C
> + bus master driver also needs to support this functionality. Please
> + read Documentation/i2c/slave-interface.rst for further details.
> +
> if I2C_SLAVE
>
> config I2C_SLAVE_EEPROM
> --
> 2.20.1
>
--
Regards,
Niklas Söderlund
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i2c: add Kconfig help text for slave mode
2020-06-28 18:55 [PATCH] i2c: add Kconfig help text for slave mode Wolfram Sang
2020-06-28 22:13 ` Niklas Söderlund
@ 2020-06-29 7:51 ` Geert Uytterhoeven
2020-06-29 11:21 ` Wolfram Sang
2020-07-04 6:17 ` Wolfram Sang
2 siblings, 1 reply; 7+ messages in thread
From: Geert Uytterhoeven @ 2020-06-29 7:51 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Linux I2C, Linux-Renesas
Hi Wolfram,
On Sun, Jun 28, 2020 at 8:55 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> I can't recall why there was none, but we surely want to have it.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Thanks for your patch!
> --- a/drivers/i2c/Kconfig
> +++ b/drivers/i2c/Kconfig
> @@ -114,6 +114,11 @@ config I2C_STUB
> config I2C_SLAVE
> bool "I2C slave support"
>
Why the blank line here ^^^?
> + help
> + This enables Linux to act as an I2C slave device. Note that your I2C
> + bus master driver also needs to support this functionality. Please
> + read Documentation/i2c/slave-interface.rst for further details.
> +
> if I2C_SLAVE
>
> config I2C_SLAVE_EEPROM
The rest looks fine to me.
As you don't like conditional R-b's, I'll add mine on v2 ;-)
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i2c: add Kconfig help text for slave mode
2020-06-29 7:51 ` Geert Uytterhoeven
@ 2020-06-29 11:21 ` Wolfram Sang
2020-06-29 11:28 ` Geert Uytterhoeven
0 siblings, 1 reply; 7+ messages in thread
From: Wolfram Sang @ 2020-06-29 11:21 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Linux I2C, Linux-Renesas
[-- Attachment #1: Type: text/plain, Size: 663 bytes --]
> > config I2C_SLAVE
> > bool "I2C slave support"
> >
>
> Why the blank line here ^^^?
Sure, I can fix before applying.
>
> > + help
> > + This enables Linux to act as an I2C slave device. Note that your I2C
> > + bus master driver also needs to support this functionality. Please
> > + read Documentation/i2c/slave-interface.rst for further details.
> > +
> > if I2C_SLAVE
> >
> > config I2C_SLAVE_EEPROM
>
> The rest looks fine to me.
Thanks, Geert!
> As you don't like conditional R-b's, I'll add mine on v2 ;-)
I don't? I can't recall that :) Maybe there was a corner case once...
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i2c: add Kconfig help text for slave mode
2020-06-29 11:21 ` Wolfram Sang
@ 2020-06-29 11:28 ` Geert Uytterhoeven
2020-06-29 11:37 ` Wolfram Sang
0 siblings, 1 reply; 7+ messages in thread
From: Geert Uytterhoeven @ 2020-06-29 11:28 UTC (permalink / raw)
To: Wolfram Sang; +Cc: Linux I2C, Linux-Renesas
Hi Wolfram,
On Mon, Jun 29, 2020 at 1:21 PM Wolfram Sang
<wsa+renesas@sang-engineering.com> wrote:
> > > config I2C_SLAVE
> > > bool "I2C slave support"
> > >
> >
> > Why the blank line here ^^^?
>
> Sure, I can fix before applying.
>
> >
> > > + help
> > > + This enables Linux to act as an I2C slave device. Note that your I2C
> > > + bus master driver also needs to support this functionality. Please
> > > + read Documentation/i2c/slave-interface.rst for further details.
> > > +
> > > if I2C_SLAVE
> > >
> > > config I2C_SLAVE_EEPROM
> >
> > The rest looks fine to me.
>
> Thanks, Geert!
>
> > As you don't like conditional R-b's, I'll add mine on v2 ;-)
>
> I don't? I can't recall that :) Maybe there was a corner case once...
Lore does not forgive, and does not forget ;-)
https://lore.kernel.org/r/20190802133656.GA23542@kunai
Hence with the above fixed:
Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
Gr{oetje,eeting}s,
Geert
--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org
In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
-- Linus Torvalds
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i2c: add Kconfig help text for slave mode
2020-06-29 11:28 ` Geert Uytterhoeven
@ 2020-06-29 11:37 ` Wolfram Sang
0 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2020-06-29 11:37 UTC (permalink / raw)
To: Geert Uytterhoeven; +Cc: Linux I2C, Linux-Renesas
[-- Attachment #1: Type: text/plain, Size: 160 bytes --]
> Lore does not forgive, and does not forget ;-)
> https://lore.kernel.org/r/20190802133656.GA23542@kunai
Ah, right. That reasoning still makes sense to me.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
* Re: [PATCH] i2c: add Kconfig help text for slave mode
2020-06-28 18:55 [PATCH] i2c: add Kconfig help text for slave mode Wolfram Sang
2020-06-28 22:13 ` Niklas Söderlund
2020-06-29 7:51 ` Geert Uytterhoeven
@ 2020-07-04 6:17 ` Wolfram Sang
2 siblings, 0 replies; 7+ messages in thread
From: Wolfram Sang @ 2020-07-04 6:17 UTC (permalink / raw)
To: linux-i2c; +Cc: linux-renesas-soc
[-- Attachment #1: Type: text/plain, Size: 239 bytes --]
On Sun, Jun 28, 2020 at 08:55:22PM +0200, Wolfram Sang wrote:
> I can't recall why there was none, but we surely want to have it.
>
> Signed-off-by: Wolfram Sang <wsa+renesas@sang-engineering.com>
Applied to for-current, thanks!
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 7+ messages in thread
end of thread, other threads:[~2020-07-04 6:17 UTC | newest]
Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-06-28 18:55 [PATCH] i2c: add Kconfig help text for slave mode Wolfram Sang
2020-06-28 22:13 ` Niklas Söderlund
2020-06-29 7:51 ` Geert Uytterhoeven
2020-06-29 11:21 ` Wolfram Sang
2020-06-29 11:28 ` Geert Uytterhoeven
2020-06-29 11:37 ` Wolfram Sang
2020-07-04 6:17 ` Wolfram Sang
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).