From: "Niklas Söderlund" <niklas.soderlund@ragnatech.se>
To: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
Cc: dri-devel@lists.freedesktop.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-renesas-soc@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>
Subject: Re: [PATCH v2 1/8] dt-bindings: media: renesas,fcp: Convert binding to YAML
Date: Tue, 30 Jun 2020 22:49:18 +0200 [thread overview]
Message-ID: <20200630204918.GA2365286@oden.dyn.berto.se> (raw)
In-Reply-To: <20200621004734.28602-2-laurent.pinchart+renesas@ideasonboard.com>
Hi Laurent,
Thanks for your work.
On 2020-06-21 03:47:27 +0300, Laurent Pinchart wrote:
> Convert the Renesas R-Car FCP text binding to YAML.
>
> Signed-off-by: Laurent Pinchart <laurent.pinchart+renesas@ideasonboard.com>
> Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> Changes since v1:
>
> - Simplify comments on compatible strings
> - Update MAINTAINERS
> ---
> .../devicetree/bindings/media/renesas,fcp.txt | 34 -----------
> .../bindings/media/renesas,fcp.yaml | 56 +++++++++++++++++++
> MAINTAINERS | 2 +-
> 3 files changed, 57 insertions(+), 35 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.txt
> create mode 100644 Documentation/devicetree/bindings/media/renesas,fcp.yaml
>
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.txt b/Documentation/devicetree/bindings/media/renesas,fcp.txt
> deleted file mode 100644
> index 79c37395b396..000000000000
> --- a/Documentation/devicetree/bindings/media/renesas,fcp.txt
> +++ /dev/null
> @@ -1,34 +0,0 @@
> -Renesas R-Car Frame Compression Processor (FCP)
> ------------------------------------------------
> -
> -The FCP is a companion module of video processing modules in the Renesas R-Car
> -Gen3 and RZ/G2 SoCs. It provides data compression and decompression, data
> -caching, and conversion of AXI transactions in order to reduce the memory
> -bandwidth.
> -
> -There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and FCP
> -for FDP (FCPF). Their configuration and behaviour depend on the module they
> -are paired with. These DT bindings currently support the FCPV and FCPF.
> -
> - - compatible: Must be one or more of the following
> -
> - - "renesas,fcpv" for generic compatible 'FCP for VSP'
> - - "renesas,fcpf" for generic compatible 'FCP for FDP'
> -
> - - reg: the register base and size for the device registers
> - - clocks: Reference to the functional clock
> -
> -Optional properties:
> - - power-domains : power-domain property defined with a power domain specifier
> - to respective power domain.
> -
> -
> -Device node example
> --------------------
> -
> - fcpvd1: fcp@fea2f000 {
> - compatible = "renesas,fcpv";
> - reg = <0 0xfea2f000 0 0x200>;
> - clocks = <&cpg CPG_MOD 602>;
> - power-domains = <&sysc R8A7795_PD_A3VP>;
> - };
> diff --git a/Documentation/devicetree/bindings/media/renesas,fcp.yaml b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> new file mode 100644
> index 000000000000..9241bf3c5efc
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/renesas,fcp.yaml
> @@ -0,0 +1,56 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/renesas,fcp.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Renesas R-Car Frame Compression Processor (FCP)
> +
> +maintainers:
> + - Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> +
> +description: |
> + The FCP is a companion module of video processing modules in the Renesas
> + R-Car Gen3 and RZ/G2 SoCs. It provides data compression and decompression,
> + data caching, and conversion of AXI transactions in order to reduce the
> + memory bandwidth.
> +
> + There are three types of FCP: FCP for Codec (FCPC), FCP for VSP (FCPV) and
> + FCP for FDP (FCPF). Their configuration and behaviour depend on the module
> + they are paired with. These DT bindings currently support the FCPV and FCPF.
> +
> +properties:
> + compatible:
> + enum:
> + - renesas,fcpv # FCP for VSP
> + - renesas,fcpf # FCP for FDP
> +
> + reg:
> + maxItems: 1
> +
> + clocks:
> + maxItems: 1
> +
> + power-domains:
> + maxItems: 1
> +
> +required:
> + - compatible
> + - reg
> + - clocks
> +
> +additionalProperties: false
> +
> +examples:
> + # R8A7790 (R-Car H2) VSP1-S
Hum, R8A7790 is H2 but the example below is from H3 R8A7795[01] is it
not? With this fixed,
Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> + - |
> + #include <dt-bindings/clock/renesas-cpg-mssr.h>
> + #include <dt-bindings/power/r8a7795-sysc.h>
> +
> + fcp@fea2f000 {
> + compatible = "renesas,fcpv";
> + reg = <0xfea2f000 0x200>;
> + clocks = <&cpg CPG_MOD 602>;
> + power-domains = <&sysc R8A7795_PD_ALWAYS_ON>;
> + };
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 68f21d46614c..660ed6606de2 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -10700,7 +10700,7 @@ L: linux-media@vger.kernel.org
> L: linux-renesas-soc@vger.kernel.org
> S: Supported
> T: git git://linuxtv.org/media_tree.git
> -F: Documentation/devicetree/bindings/media/renesas,fcp.txt
> +F: Documentation/devicetree/bindings/media/renesas,fcp.yaml
> F: drivers/media/platform/rcar-fcp.c
> F: include/media/rcar-fcp.h
>
> --
> Regards,
>
> Laurent Pinchart
>
--
Regards,
Niklas Söderlund
next prev parent reply other threads:[~2020-06-30 20:49 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-21 0:47 [PATCH v2 0/8] dt-bindings: media: Conversion of Renesas bindings to YAML Laurent Pinchart
2020-06-21 0:47 ` [PATCH v2 1/8] dt-bindings: media: renesas,fcp: Convert binding " Laurent Pinchart
2020-06-30 20:49 ` Niklas Söderlund [this message]
2020-07-01 6:03 ` Laurent Pinchart
2020-07-01 6:05 ` [PATCH v2.1 " Laurent Pinchart
2020-07-14 2:45 ` [PATCH v2.1 1/8] dt-bindings: media: renesas, fcp: " Rob Herring
2020-06-21 0:47 ` [PATCH v2 2/8] dt-bindings: media: renesas,fcp: Make power-domains mandatory Laurent Pinchart
2020-06-30 20:49 ` Niklas Söderlund
2020-07-13 23:59 ` [PATCH v2 2/8] dt-bindings: media: renesas, fcp: " Rob Herring
2020-06-21 0:47 ` [PATCH v2 3/8] dt-bindings: media: renesas,fcp: Add resets and iommus properties Laurent Pinchart
2020-06-30 20:50 ` Niklas Söderlund
2020-07-13 23:59 ` [PATCH v2 3/8] dt-bindings: media: renesas, fcp: " Rob Herring
2020-06-21 0:47 ` [PATCH v2 4/8] dt-bindings: media: renesas,fdp1: Convert binding to YAML Laurent Pinchart
2020-06-30 20:55 ` Niklas Söderlund
2020-07-14 0:00 ` [PATCH v2 4/8] dt-bindings: media: renesas, fdp1: " Rob Herring
2020-06-21 0:47 ` [PATCH v2 5/8] dt-bindings: media: renesas,fdp1: Make power-domains mandatory Laurent Pinchart
2020-06-30 20:56 ` Niklas Söderlund
2020-07-14 0:00 ` [PATCH v2 5/8] dt-bindings: media: renesas, fdp1: " Rob Herring
2020-06-21 0:47 ` [PATCH v2 6/8] dt-bindings: media: renesas,fdp1: Add resets property Laurent Pinchart
2020-06-30 20:57 ` Niklas Söderlund
2020-07-14 0:01 ` Rob Herring
2020-06-21 0:47 ` [PATCH v2 7/8] dt-bindings: media: renesas,vsp1: Convert binding to YAML Laurent Pinchart
2020-06-30 21:02 ` Niklas Söderlund
2020-07-14 0:02 ` [PATCH v2 7/8] dt-bindings: media: renesas, vsp1: " Rob Herring
2020-06-21 0:47 ` [PATCH v2 8/8] dt-bindings: media: renesas,vsp1: Add power-domains and resets Laurent Pinchart
2020-06-30 21:03 ` Niklas Söderlund
2020-07-14 0:02 ` [PATCH v2 8/8] dt-bindings: media: renesas, vsp1: " Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200630204918.GA2365286@oden.dyn.berto.se \
--to=niklas.soderlund@ragnatech.se \
--cc=devicetree@vger.kernel.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=laurent.pinchart+renesas@ideasonboard.com \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).