From: Rob Herring <robh@kernel.org>
To: "Lad, Prabhakar" <prabhakar.csengg@gmail.com>
Cc: Niklas <niklas.soderlund@ragnatech.se>,
Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media <linux-media@vger.kernel.org>,
Linux-Renesas <linux-renesas-soc@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>, LKML <linux-kernel@vger.kernel.org>,
Biju Das <biju.das.jz@bp.renesas.com>,
Geert Uytterhoeven <geert+renesas@glider.be>
Subject: Re: [PATCH 1/2] dt-bindings: media: renesas,vin: Document renesas-vin-ycbcr-8b-g property
Date: Fri, 31 Jul 2020 14:19:00 -0600 [thread overview]
Message-ID: <20200731201900.GA704336@bogus> (raw)
In-Reply-To: <CA+V-a8sNxUaj88DDcWyc4zrmsAAGndjoQX=OmJ3u1GRJCT6TBQ@mail.gmail.com>
On Sat, Jul 25, 2020 at 11:23:13PM +0100, Lad, Prabhakar wrote:
> Hi Niklas,
>
> On Sat, Jul 25, 2020 at 9:11 AM Niklas <niklas.soderlund@ragnatech.se> wrote:
> >
> > Hi Lad,
> >
> > On 2020-07-24 22:11:31 +0100, Lad, Prabhakar wrote:
> > > Hi Niklas,
> > >
> > > Thank you for the review.
> > >
> > > On Fri, Jul 24, 2020 at 8:37 PM Niklas <niklas.soderlund@ragnatech.se> wrote:
> > > >
> > > > Hi Lad,
> > > >
> > > > Thanks for your patch.
> > > >
> > > > On 2020-07-24 15:58:51 +0100, Lad Prabhakar wrote:
> > > > > Add a DT property "renesas-vin-ycbcr-8b-g" to select YCbCr422 8-bit data
> > > > > input pins.
> > > > >
> > > > > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> > > > > Reviewed-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > > > ---
> > > > > Documentation/devicetree/bindings/media/renesas,vin.yaml | 13 +++++++++++++
> > > > > 1 file changed, 13 insertions(+)
> > > > >
> > > > > diff --git a/Documentation/devicetree/bindings/media/renesas,vin.yaml b/Documentation/devicetree/bindings/media/renesas,vin.yaml
> > > > > index 53c0a72..7dfb781 100644
> > > > > --- a/Documentation/devicetree/bindings/media/renesas,vin.yaml
> > > > > +++ b/Documentation/devicetree/bindings/media/renesas,vin.yaml
> > > > > @@ -106,6 +106,12 @@ properties:
> > > > >
> > > > > remote-endpoint: true
> > > > >
> > > > > + renesas-vin-ycbcr-8b-g:
> > > >
> > > > I think the preferred format for vendor specific properties are
> > > > "<vendor>,<property>".
> > > >
> > > Indeed and I had it as renesas,vin-ycbcr-8b-g but dt_bindings_check
> > > complained about it.
> >
> > I see, what was the error?
> >
> CHKDT Documentation/devicetree/bindings/media/renesas,vin.yaml
> /home/prasmi/work/renasas/g2n/renesas-devel/Documentation/devicetree/bindings/media/renesas,vin.yaml:
> properties:port:properties:endpoint:properties:renesas,vin-ycbcr-8b-g:
> {'type': 'boolean', 'description': 'If present this property specifies
> to selects VIN_G[7:0] as data pins for YCbCr422 8-bit data.',
> 'default': False} is not valid under any of the given schemas
> (Possible causes of the failure):
> /home/prasmi/work/renasas/g2n/renesas-devel/Documentation/devicetree/bindings/media/renesas,vin.yaml:
> properties:port:properties:endpoint:properties:renesas,vin-ycbcr-8b-g:
> 'not' is a required property
>
> /home/prasmi/work/renasas/g2n/renesas-devel/Documentation/devicetree/bindings/media/renesas,vin.yaml:
> properties:ports:properties:port@0:properties:endpoint:properties:renesas,vin-ycbcr-8b-g:
> {'type': 'boolean', 'description': 'If present this property specifies
> to selects VIN_G[7:0] as data pins for YCbCr422 8-bit data.',
> 'default': False} is not valid under any of the given schemas
> (Possible causes of the failure):
> /home/prasmi/work/renasas/g2n/renesas-devel/Documentation/devicetree/bindings/media/renesas,vin.yaml:
> properties:ports:properties:port@0:properties:endpoint:properties:renesas,vin-ycbcr-8b-g:
> 'not' is a required property
The errors here aren't that helpful. The problem is 'default: false'
doesn't make sense for a boolean type as false is always not present for
DT.
Rob
next prev parent reply other threads:[~2020-07-31 20:19 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-24 14:58 [PATCH 0/2] media: rcar-vin: Add support to select data pins Lad Prabhakar
2020-07-24 14:58 ` [PATCH 1/2] dt-bindings: media: renesas,vin: Document renesas-vin-ycbcr-8b-g property Lad Prabhakar
2020-07-24 19:37 ` Niklas
2020-07-24 21:11 ` Lad, Prabhakar
2020-07-25 8:11 ` Niklas
2020-07-25 22:23 ` Lad, Prabhakar
2020-07-31 20:19 ` Rob Herring [this message]
2020-08-01 9:17 ` Niklas
2020-08-03 9:31 ` Geert Uytterhoeven
2020-07-24 14:58 ` [PATCH 2/2] media: rcar-vin: Add support to read " Lad Prabhakar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20200731201900.GA704336@bogus \
--to=robh@kernel.org \
--cc=biju.das.jz@bp.renesas.com \
--cc=devicetree@vger.kernel.org \
--cc=geert+renesas@glider.be \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=niklas.soderlund@ragnatech.se \
--cc=prabhakar.csengg@gmail.com \
--cc=prabhakar.mahadev-lad.rj@bp.renesas.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).