[PATCH v4 0/3] dt-bindings: media: i2c: Convert 3 sensor bindings

[PATCH v4 0/3] dt-bindings: media: i2c: Convert 3 sensor bindings

[Jacopo Mondi]

I know I've sent the previous version first as part of a longer list of patches,
later individually, and now grouped together again. Sorry for the fuss, hope
it's not too confusing.

These three sensor bindings conversions go together as they all happen in a
single patch, so I deemed it was easier to just group them.

In v4 after finalizing the discussion with Laurent and Rob on how to handle
of-graph endpoint, I have dropped them from mt9v111 and imx274. For imx214 as I
have endpoint properties to document I have also documented 'endpoint' (not
mandatory) and 'remote-endpoint' (mandatory). Hope I got the outcome of the
discussion right. For imx214 I also took in Laurent's suggestion on how to
document the 'data-lanes' supported values.

Individual maintainers cc-ed per-patch.

Thanks
   j

Jacopo Mondi (3):
  dt-bindings: media: mt9v111: Convert to json-schema
  dt-bindings: media: imx274: Convert to json-schema
  dt-bindings: media: imx214: Convert to json-schema

 .../bindings/media/i2c/aptina,mt9v111.txt     |  46 ------
 .../bindings/media/i2c/aptina,mt9v111.yaml    |  75 ++++++++++
 .../devicetree/bindings/media/i2c/imx274.txt  |  38 -----
 .../bindings/media/i2c/sony,imx214.txt        |  53 -------
 .../bindings/media/i2c/sony,imx214.yaml       | 137 ++++++++++++++++++
 .../bindings/media/i2c/sony,imx274.yaml       |  59 ++++++++
 MAINTAINERS                                   |   6 +-
 7 files changed, 274 insertions(+), 140 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/i2c/aptina,mt9v111.txt
 create mode 100644 Documentation/devicetree/bindings/media/i2c/aptina,mt9v111.yaml
 delete mode 100644 Documentation/devicetree/bindings/media/i2c/imx274.txt
 delete mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
 create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
 create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml

--
2.28.0

[PATCH v4 1/3] dt-bindings: media: mt9v111: Convert to json-schema

[Jacopo Mondi]

Convert the mt9v111 bindings document to json-schema and update
the MAINTAINERS file accordingly.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 .../bindings/media/i2c/aptina,mt9v111.txt     | 46 ------------
 .../bindings/media/i2c/aptina,mt9v111.yaml    | 75 +++++++++++++++++++
 MAINTAINERS                                   |  2 +-
 3 files changed, 76 insertions(+), 47 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/i2c/aptina,mt9v111.txt
 create mode 100644 Documentation/devicetree/bindings/media/i2c/aptina,mt9v111.yaml

diff --git a/Documentation/devicetree/bindings/media/i2c/aptina,mt9v111.txt b/Documentation/devicetree/bindings/media/i2c/aptina,mt9v111.txt
deleted file mode 100644
index bd896e9f67d1..000000000000
--- a/Documentation/devicetree/bindings/media/i2c/aptina,mt9v111.txt
+++ /dev/null
@@ -1,46 +0,0 @@
-* Aptina MT9V111 CMOS sensor
-----------------------------
-
-The Aptina MT9V111 is a 1/4-Inch VGA-format digital image sensor with a core
-based on Aptina MT9V011 sensor and an integrated Image Flow Processor (IFP).
-
-The sensor has an active pixel array of 640x480 pixels and can output a number
-of image resolution and formats controllable through a simple two-wires
-interface.
-
-Required properties:
---------------------
-
-- compatible: shall be "aptina,mt9v111".
-- clocks: reference to the system clock input provider.
-
-Optional properties:
---------------------
-
-- enable-gpios: output enable signal, pin name "OE#". Active low.
-- standby-gpios: low power state control signal, pin name "STANDBY".
-  Active high.
-- reset-gpios: chip reset signal, pin name "RESET#". Active low.
-
-The device node must contain one 'port' child node with one 'endpoint' child
-sub-node for its digital output video port, in accordance with the video
-interface bindings defined in:
-Documentation/devicetree/bindings/media/video-interfaces.txt
-
-Example:
---------
-
-        &i2c1 {
-                camera@48 {
-                        compatible = "aptina,mt9v111";
-                        reg = <0x48>;
-
-                        clocks = <&camera_clk>;
-
-                        port {
-                                mt9v111_out: endpoint {
-                                        remote-endpoint = <&ceu_in>;
-                                };
-                        };
-                };
-        };
diff --git a/Documentation/devicetree/bindings/media/i2c/aptina,mt9v111.yaml b/Documentation/devicetree/bindings/media/i2c/aptina,mt9v111.yaml
new file mode 100644
index 000000000000..ff9546e95d05
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/aptina,mt9v111.yaml
@@ -0,0 +1,75 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/aptina,mt9v111.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Aptina MT9V111 CMOS sensor
+
+maintainers:
+  - Jacopo Mondi <jacopo@jmondi.org>
+
+description: |
+  The Aptina MT9V111 is a 1/4-Inch VGA-format digital image sensor with a core
+  based on Aptina MT9V011 sensor and an integrated Image Flow Processor (IFP).
+
+  The sensor has an active pixel array of 640x480 pixels and can output a number
+  of image resolutions and formats controllable through a simple two-wires
+  interface.
+
+properties:
+  compatible:
+    const: aptina,mt9v111
+
+  reg:
+    maxItems: 1
+
+  clocks:
+    maxItems: 1
+
+  enable-gpios:
+    description: Enable signal, pin name "OE#". Active low.
+    maxItems: 1
+
+  standby-gpios:
+    description: |
+      Low power state control signal, pin name "STANDBY". Active high.
+    maxItems: 1
+
+  reset-gpios:
+    description: Chip reset signal, pin name "RESET#". Active low.
+    maxItems: 1
+
+  port:
+    type: object
+    description: |
+      Output video port. See ../video-interfaces.txt.
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c0 {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        camera@48 {
+            compatible = "aptina,mt9v111";
+            reg = <0x48>;
+            clocks = <&camera_clk>;
+
+            port {
+                mt9v111_out: endpoint {
+                    remote-endpoint = <&ceu_in>;
+                };
+            };
+        };
+    };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 4f786d18e16e..3f8f093268b7 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -11806,7 +11806,7 @@ M:	Jacopo Mondi <jacopo@jmondi.org>
 L:	linux-media@vger.kernel.org
 S:	Maintained
 T:	git git://linuxtv.org/media_tree.git
-F:	Documentation/devicetree/bindings/media/i2c/aptina,mt9v111.txt
+F:	Documentation/devicetree/bindings/media/i2c/aptina,mt9v111.yaml
 F:	drivers/media/i2c/mt9v111.c
 
 MULTIFUNCTION DEVICES (MFD)
-- 
2.28.0

[PATCH v4 2/3] dt-bindings: media: imx274: Convert to json-schema

[Jacopo Mondi]

Convert the imx274 bindings document to json-schema and update
the MAINTAINERS file accordingly.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 .../devicetree/bindings/media/i2c/imx274.txt  | 38 ------------
 .../bindings/media/i2c/sony,imx274.yaml       | 59 +++++++++++++++++++
 MAINTAINERS                                   |  2 +-
 3 files changed, 60 insertions(+), 39 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/i2c/imx274.txt
 create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml

diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt
deleted file mode 100644
index 0727079d2410..000000000000
--- a/Documentation/devicetree/bindings/media/i2c/imx274.txt
+++ /dev/null
@@ -1,38 +0,0 @@
-* Sony 1/2.5-Inch 8.51Mp CMOS Digital Image Sensor
-
-The Sony imx274 is a 1/2.5-inch CMOS active pixel digital image sensor with
-an active array size of 3864H x 2202V. It is programmable through I2C
-interface. The I2C address is fixed to 0x1a as per sensor data sheet.
-Image data is sent through MIPI CSI-2, which is configured as 4 lanes
-at 1440 Mbps.
-
-
-Required Properties:
-- compatible: value should be "sony,imx274" for imx274 sensor
-- reg: I2C bus address of the device
-
-Optional Properties:
-- reset-gpios: Sensor reset GPIO
-- clocks: Reference to the input clock.
-- clock-names: Should be "inck".
-- VANA-supply: Sensor 2.8v analog supply.
-- VDIG-supply: Sensor 1.8v digital core supply.
-- VDDL-supply: Sensor digital IO 1.2v supply.
-
-The imx274 device node should contain one 'port' child node with
-an 'endpoint' subnode. For further reading on port node refer to
-Documentation/devicetree/bindings/media/video-interfaces.txt.
-
-Example:
-	sensor@1a {
-		compatible = "sony,imx274";
-		reg = <0x1a>;
-		#address-cells = <1>;
-		#size-cells = <0>;
-		reset-gpios = <&gpio_sensor 0 0>;
-		port {
-			sensor_out: endpoint {
-				remote-endpoint = <&csiss_in>;
-			};
-		};
-	};
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
new file mode 100644
index 000000000000..f757ce380cb2
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
@@ -0,0 +1,59 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/sony,imx274.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sony 1/2.5-Inch 8.51MP CMOS Digital Image Sensor
+
+maintainers:
+  - Leon Luo <leonl@leopardimaging.com>
+
+description: |
+  The Sony IMX274 is a 1/2.5-inch CMOS active pixel digital image sensor with an
+  active array size of 3864H x 2202V. It is programmable through I2C interface.
+  Image data is sent through MIPI CSI-2, which is configured as 4 lanes at 1440
+  Mbps.
+
+properties:
+  compatible:
+    const: sony,imx274
+
+  reg:
+    const: 0x1a
+
+  reset-gpios:
+    maxItems: 1
+
+  port:
+    type: object
+    description: |
+      Output video port. See ../video-interfaces.txt.
+
+required:
+  - compatible
+  - reg
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+    i2c0 {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        imx274: camera-sensor@1a {
+            compatible = "sony,imx274";
+            reg = <0x1a>;
+            reset-gpios = <&gpio_sensor 0 0>;
+
+            port {
+                sensor_out: endpoint {
+                    remote-endpoint = <&csiss_in>;
+                };
+            };
+        };
+    };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 3f8f093268b7..093a54ae1527 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16127,7 +16127,7 @@ M:	Leon Luo <leonl@leopardimaging.com>
 L:	linux-media@vger.kernel.org
 S:	Maintained
 T:	git git://linuxtv.org/media_tree.git
-F:	Documentation/devicetree/bindings/media/i2c/imx274.txt
+F:	Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
 F:	drivers/media/i2c/imx274.c

 SONY IMX290 SENSOR DRIVER
--
2.28.0

[PATCH v4 3/3] dt-bindings: media: imx214: Convert to json-schema

[Jacopo Mondi]

Convert the imx214 bindings document to json-schema and update
the MAINTAINERS file accordingly.

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
---
 .../bindings/media/i2c/sony,imx214.txt        |  53 -------
 .../bindings/media/i2c/sony,imx214.yaml       | 137 ++++++++++++++++++
 MAINTAINERS                                   |   2 +-
 3 files changed, 138 insertions(+), 54 deletions(-)
 delete mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
 create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml

diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx214.txt b/Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
deleted file mode 100644
index f11f28a5fda4..000000000000
--- a/Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
+++ /dev/null
@@ -1,53 +0,0 @@
-* Sony 1/3.06-Inch 13.13Mp CMOS Digital Image Sensor
-
-The Sony imx214 is a 1/3.06-inch CMOS active pixel digital image sensor with
-an active array size of 4224H x 3200V. It is programmable through an I2C
-interface.
-Image data is sent through MIPI CSI-2, through 2 or 4 lanes at a maximum
-throughput of 1.2Gbps/lane.
-
-
-Required Properties:
-- compatible: Shall be "sony,imx214".
-- reg: I2C bus address of the device. Depending on how the sensor is wired,
-       it shall be <0x10> or <0x1a>;
-- enable-gpios: GPIO descriptor for the enable pin.
-- vdddo-supply: Chip digital IO regulator (1.8V).
-- vdda-supply: Chip analog regulator (2.7V).
-- vddd-supply: Chip digital core regulator (1.12V).
-- clocks: Reference to the xclk clock.
-- clock-frequency: Frequency of the xclk clock.
-
-Optional Properties:
-- flash-leds: See ../video-interfaces.txt
-- lens-focus: See ../video-interfaces.txt
-
-The imx214 device node shall contain one 'port' child node with
-an 'endpoint' subnode. For further reading on port node refer to
-Documentation/devicetree/bindings/media/video-interfaces.txt.
-
-Required Properties on endpoint:
-- data-lanes: check ../video-interfaces.txt
-- link-frequencies: check ../video-interfaces.txt
-- remote-endpoint: check ../video-interfaces.txt
-
-Example:
-
-	camera-sensor@1a {
-		compatible = "sony,imx214";
-		reg = <0x1a>;
-		vdddo-supply = <&pm8994_lvs1>;
-		vddd-supply = <&camera_vddd_1v12>;
-		vdda-supply = <&pm8994_l17>;
-		lens-focus = <&ad5820>;
-		enable-gpios = <&msmgpio 25 GPIO_ACTIVE_HIGH>;
-		clocks = <&mmcc CAMSS_MCLK0_CLK>;
-		clock-frequency = <24000000>;
-		port {
-			imx214_ep: endpoint {
-				data-lanes = <1 2 3 4>;
-				link-frequencies = /bits/ 64 <480000000>;
-				remote-endpoint = <&csiphy0_ep>;
-			};
-		};
-	};
diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
new file mode 100644
index 000000000000..21e581472911
--- /dev/null
+++ b/Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
@@ -0,0 +1,137 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/media/i2c/sony,imx214.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Sony 1/3.06-Inch 13.13MP CMOS Digital Image Sensor
+
+maintainers:
+  - Ricardo Ribalda <ribalda@kernel.org>
+
+description: |
+  The Sony IMX214 is a 1/3.06-inch CMOS active pixel digital image sensor with
+  an active array size of 4224H x 3200V. It is programmable through an I2C
+  interface. Image data is sent through MIPI CSI-2, through 2 or 4 lanes at a
+  maximum throughput of 1.2Gbps/lane.
+
+properties:
+  compatible:
+    const: sony,imx214
+
+  reg:
+    enum:
+      - 0x10
+      - 0x1a
+
+  clocks:
+    description: Reference to the xclk clock.
+    maxItems: 1
+
+  clock-frequency:
+    description: Frequency of the xclk clock in Hz.
+
+  enable-gpios:
+    description: GPIO descriptor for the enable pin.
+    maxItems: 1
+
+  vdddo-supply:
+    description: Chip digital IO regulator (1.8V).
+    maxItems: 1
+
+  vdda-supply:
+    description: Chip analog regulator (2.7V).
+    maxItems: 1
+
+  vddd-supply:
+    description: Chip digital core regulator (1.12V).
+    maxItems: 1
+
+  flash-leds:
+    description: See ../video-interfaces.txt
+
+  lens-focus:
+    description: See ../video-interfaces.txt
+
+  port:
+    type: object
+    description: |
+      Video output port. See ../video-interfaces.txt.
+
+    properties:
+      endpoint:
+        type: object
+
+        properties:
+          remote-endpoint:
+            description: See ../video-interfaces.txt
+
+          data-lanes:
+            $ref: /schemas/types.yaml#/definitions/uint32-array
+            description: See ../video-interfaces.txt
+            anyOf:
+              - items:
+                - const: 1
+                - const: 2
+              - items:
+                - const: 1
+                - const: 2
+                - const: 3
+                - const: 4
+
+          link-frequencies:
+            $ref: /schemas/types.yaml#/definitions/uint64-array
+            description: See ../video-interfaces.txt
+
+        required:
+          - remote-endpoint
+          - data-lanes
+          - link-frequencies
+
+        additionalProperties: false
+
+    additionalProperties: false
+
+required:
+  - compatible
+  - reg
+  - clocks
+  - clock-frequency
+  - enable-gpios
+  - vdddo-supply
+  - vdda-supply
+  - vddd-supply
+  - port
+
+additionalProperties: false
+
+examples:
+  - |
+    #include <dt-bindings/gpio/gpio.h>
+
+    i2c0 {
+        #address-cells = <1>;
+        #size-cells = <0>;
+
+        camera-sensor@1a {
+            compatible = "sony,imx214";
+            reg = <0x1a>;
+            vdddo-supply = <&pm8994_lvs1>;
+            vddd-supply = <&camera_vddd_1v12>;
+            vdda-supply = <&pm8994_l17>;
+            lens-focus = <&ad5820>;
+            enable-gpios = <&msmgpio 25 GPIO_ACTIVE_HIGH>;
+            clocks = <&camera_clk>;
+            clock-frequency = <24000000>;
+
+            port {
+                imx214_ep: endpoint {
+                    data-lanes = <1 2 3 4>;
+                    link-frequencies = /bits/ 64 <480000000>;
+                    remote-endpoint = <&csiphy0_ep>;
+                };
+            };
+        };
+    };
+
+...
diff --git a/MAINTAINERS b/MAINTAINERS
index 093a54ae1527..b706598d764b 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -16104,7 +16104,7 @@ M:	Ricardo Ribalda <ribalda@kernel.org>
 L:	linux-media@vger.kernel.org
 S:	Maintained
 T:	git git://linuxtv.org/media_tree.git
-F:	Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
+F:	Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
 F:	drivers/media/i2c/imx214.c

 SONY IMX219 SENSOR DRIVER
--
2.28.0

Re: [PATCH v4 2/3] dt-bindings: media: imx274: Convert to json-schema

[Sakari Ailus]

Hi Jacopo,

Thanks for the update.

On Thu, Sep 03, 2020 at 01:51:42PM +0200, Jacopo Mondi wrote:
> Convert the imx274 bindings document to json-schema and update
> the MAINTAINERS file accordingly.
> 
> Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> ---
>  .../devicetree/bindings/media/i2c/imx274.txt  | 38 ------------
>  .../bindings/media/i2c/sony,imx274.yaml       | 59 +++++++++++++++++++
>  MAINTAINERS                                   |  2 +-
>  3 files changed, 60 insertions(+), 39 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/media/i2c/imx274.txt
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> 
> diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt
> deleted file mode 100644
> index 0727079d2410..000000000000
> --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt
> +++ /dev/null
> @@ -1,38 +0,0 @@
> -* Sony 1/2.5-Inch 8.51Mp CMOS Digital Image Sensor
> -
> -The Sony imx274 is a 1/2.5-inch CMOS active pixel digital image sensor with
> -an active array size of 3864H x 2202V. It is programmable through I2C
> -interface. The I2C address is fixed to 0x1a as per sensor data sheet.
> -Image data is sent through MIPI CSI-2, which is configured as 4 lanes
> -at 1440 Mbps.
> -
> -
> -Required Properties:
> -- compatible: value should be "sony,imx274" for imx274 sensor
> -- reg: I2C bus address of the device
> -
> -Optional Properties:
> -- reset-gpios: Sensor reset GPIO
> -- clocks: Reference to the input clock.
> -- clock-names: Should be "inck".
> -- VANA-supply: Sensor 2.8v analog supply.
> -- VDIG-supply: Sensor 1.8v digital core supply.
> -- VDDL-supply: Sensor digital IO 1.2v supply.
> -
> -The imx274 device node should contain one 'port' child node with
> -an 'endpoint' subnode. For further reading on port node refer to
> -Documentation/devicetree/bindings/media/video-interfaces.txt.
> -
> -Example:
> -	sensor@1a {
> -		compatible = "sony,imx274";
> -		reg = <0x1a>;
> -		#address-cells = <1>;
> -		#size-cells = <0>;
> -		reset-gpios = <&gpio_sensor 0 0>;
> -		port {
> -			sensor_out: endpoint {
> -				remote-endpoint = <&csiss_in>;
> -			};
> -		};
> -	};
> diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> new file mode 100644
> index 000000000000..f757ce380cb2
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> @@ -0,0 +1,59 @@
> +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/media/i2c/sony,imx274.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
> +
> +title: Sony 1/2.5-Inch 8.51MP CMOS Digital Image Sensor
> +
> +maintainers:
> +  - Leon Luo <leonl@leopardimaging.com>
> +
> +description: |
> +  The Sony IMX274 is a 1/2.5-inch CMOS active pixel digital image sensor with an
> +  active array size of 3864H x 2202V. It is programmable through I2C interface.
> +  Image data is sent through MIPI CSI-2, which is configured as 4 lanes at 1440
> +  Mbps.
> +
> +properties:
> +  compatible:
> +    const: sony,imx274
> +
> +  reg:
> +    const: 0x1a
> +
> +  reset-gpios:
> +    maxItems: 1
> +
> +  port:
> +    type: object
> +    description: |
> +      Output video port. See ../video-interfaces.txt.
> +

What happened to the supplies and the clocks?

> +required:
> +  - compatible
> +  - reg
> +  - port
> +
> +additionalProperties: false
> +
> +examples:
> +  - |
> +    i2c0 {
> +        #address-cells = <1>;
> +        #size-cells = <0>;
> +
> +        imx274: camera-sensor@1a {
> +            compatible = "sony,imx274";
> +            reg = <0x1a>;
> +            reset-gpios = <&gpio_sensor 0 0>;
> +
> +            port {
> +                sensor_out: endpoint {
> +                    remote-endpoint = <&csiss_in>;
> +                };
> +            };
> +        };
> +    };
> +
> +...
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 3f8f093268b7..093a54ae1527 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -16127,7 +16127,7 @@ M:	Leon Luo <leonl@leopardimaging.com>
>  L:	linux-media@vger.kernel.org
>  S:	Maintained
>  T:	git git://linuxtv.org/media_tree.git
> -F:	Documentation/devicetree/bindings/media/i2c/imx274.txt
> +F:	Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
>  F:	drivers/media/i2c/imx274.c
> 
>  SONY IMX290 SENSOR DRIVER

-- 
Regards,

Sakari Ailus

Re: [PATCH v4 2/3] dt-bindings: media: imx274: Convert to json-schema

[Jacopo Mondi]

Hi Sakari

On Thu, Sep 03, 2020 at 03:23:31PM +0300, Sakari Ailus wrote:
> Hi Jacopo,
>
> Thanks for the update.
>
> On Thu, Sep 03, 2020 at 01:51:42PM +0200, Jacopo Mondi wrote:
> > Convert the imx274 bindings document to json-schema and update
> > the MAINTAINERS file accordingly.
> >
> > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > ---
> >  .../devicetree/bindings/media/i2c/imx274.txt  | 38 ------------
> >  .../bindings/media/i2c/sony,imx274.yaml       | 59 +++++++++++++++++++
> >  MAINTAINERS                                   |  2 +-
> >  3 files changed, 60 insertions(+), 39 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/media/i2c/imx274.txt
> >  create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> >
> > diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt
> > deleted file mode 100644
> > index 0727079d2410..000000000000
> > --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt
> > +++ /dev/null
> > @@ -1,38 +0,0 @@
> > -* Sony 1/2.5-Inch 8.51Mp CMOS Digital Image Sensor
> > -
> > -The Sony imx274 is a 1/2.5-inch CMOS active pixel digital image sensor with
> > -an active array size of 3864H x 2202V. It is programmable through I2C
> > -interface. The I2C address is fixed to 0x1a as per sensor data sheet.
> > -Image data is sent through MIPI CSI-2, which is configured as 4 lanes
> > -at 1440 Mbps.
> > -
> > -
> > -Required Properties:
> > -- compatible: value should be "sony,imx274" for imx274 sensor
> > -- reg: I2C bus address of the device
> > -
> > -Optional Properties:
> > -- reset-gpios: Sensor reset GPIO
> > -- clocks: Reference to the input clock.
> > -- clock-names: Should be "inck".
> > -- VANA-supply: Sensor 2.8v analog supply.
> > -- VDIG-supply: Sensor 1.8v digital core supply.
> > -- VDDL-supply: Sensor digital IO 1.2v supply.
> > -
> > -The imx274 device node should contain one 'port' child node with
> > -an 'endpoint' subnode. For further reading on port node refer to
> > -Documentation/devicetree/bindings/media/video-interfaces.txt.
> > -
> > -Example:
> > -	sensor@1a {
> > -		compatible = "sony,imx274";
> > -		reg = <0x1a>;
> > -		#address-cells = <1>;
> > -		#size-cells = <0>;
> > -		reset-gpios = <&gpio_sensor 0 0>;
> > -		port {
> > -			sensor_out: endpoint {
> > -				remote-endpoint = <&csiss_in>;
> > -			};
> > -		};
> > -	};
> > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> > new file mode 100644
> > index 000000000000..f757ce380cb2
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> > @@ -0,0 +1,59 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id: http://devicetree.org/schemas/media/i2c/sony,imx274.yaml#
> > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > +
> > +title: Sony 1/2.5-Inch 8.51MP CMOS Digital Image Sensor
> > +
> > +maintainers:
> > +  - Leon Luo <leonl@leopardimaging.com>
> > +
> > +description: |
> > +  The Sony IMX274 is a 1/2.5-inch CMOS active pixel digital image sensor with an
> > +  active array size of 3864H x 2202V. It is programmable through I2C interface.
> > +  Image data is sent through MIPI CSI-2, which is configured as 4 lanes at 1440
> > +  Mbps.
> > +
> > +properties:
> > +  compatible:
> > +    const: sony,imx274
> > +
> > +  reg:
> > +    const: 0x1a
> > +
> > +  reset-gpios:
> > +    maxItems: 1
> > +
> > +  port:
> > +    type: object
> > +    description: |
> > +      Output video port. See ../video-interfaces.txt.
> > +
>
> What happened to the supplies and the clocks?
>

AH!

74ea3273d24b ("dt-bindings: media: imx274: Add optional input clock and supplies")
went in a release later than my v2. From there I kep carrying on what
I had in the yaml file in v3 and v4 without noticing the original
bindings in textual form had changed in between!

I've just seen this this morning
https://patchwork.linuxtv.org/project/linux-media/patch/1599012278-10203-3-git-send-email-skomatineni@nvidia.com/
and I thought it was a new addition.

Let me reply to Sowjanya. I'll send a v4.1 of this patch in reply to
this version with the newly documented properties added.

> > +required:
> > +  - compatible
> > +  - reg
> > +  - port
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    i2c0 {
> > +        #address-cells = <1>;
> > +        #size-cells = <0>;
> > +
> > +        imx274: camera-sensor@1a {
> > +            compatible = "sony,imx274";
> > +            reg = <0x1a>;
> > +            reset-gpios = <&gpio_sensor 0 0>;
> > +
> > +            port {
> > +                sensor_out: endpoint {
> > +                    remote-endpoint = <&csiss_in>;
> > +                };
> > +            };
> > +        };
> > +    };
> > +
> > +...
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 3f8f093268b7..093a54ae1527 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -16127,7 +16127,7 @@ M:	Leon Luo <leonl@leopardimaging.com>
> >  L:	linux-media@vger.kernel.org
> >  S:	Maintained
> >  T:	git git://linuxtv.org/media_tree.git
> > -F:	Documentation/devicetree/bindings/media/i2c/imx274.txt
> > +F:	Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> >  F:	drivers/media/i2c/imx274.c
> >
> >  SONY IMX290 SENSOR DRIVER
>
> --
> Regards,
>
> Sakari Ailus

Re: [PATCH v4 0/3] dt-bindings: media: i2c: Convert 3 sensor bindings

[Laurent Pinchart]

Hi Jacopo,

On Thu, Sep 03, 2020 at 01:51:40PM +0200, Jacopo Mondi wrote:
> I know I've sent the previous version first as part of a longer list of patches,
> later individually, and now grouped together again. Sorry for the fuss, hope
> it's not too confusing.
> 
> These three sensor bindings conversions go together as they all happen in a
> single patch, so I deemed it was easier to just group them.
> 
> In v4 after finalizing the discussion with Laurent and Rob on how to handle
> of-graph endpoint, I have dropped them from mt9v111 and imx274. For imx214 as I
> have endpoint properties to document I have also documented 'endpoint' (not
> mandatory) and 'remote-endpoint' (mandatory). Hope I got the outcome of the
> discussion right. For imx214 I also took in Laurent's suggestion on how to
> document the 'data-lanes' supported values.

I think you can drop remote-endpoint, it will be defined in
of-graph.yaml. Apart from that, it sounds good to me.

> Individual maintainers cc-ed per-patch.
> 
> Jacopo Mondi (3):
>   dt-bindings: media: mt9v111: Convert to json-schema
>   dt-bindings: media: imx274: Convert to json-schema
>   dt-bindings: media: imx214: Convert to json-schema
> 
>  .../bindings/media/i2c/aptina,mt9v111.txt     |  46 ------
>  .../bindings/media/i2c/aptina,mt9v111.yaml    |  75 ++++++++++
>  .../devicetree/bindings/media/i2c/imx274.txt  |  38 -----
>  .../bindings/media/i2c/sony,imx214.txt        |  53 -------
>  .../bindings/media/i2c/sony,imx214.yaml       | 137 ++++++++++++++++++
>  .../bindings/media/i2c/sony,imx274.yaml       |  59 ++++++++
>  MAINTAINERS                                   |   6 +-
>  7 files changed, 274 insertions(+), 140 deletions(-)
>  delete mode 100644 Documentation/devicetree/bindings/media/i2c/aptina,mt9v111.txt
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/aptina,mt9v111.yaml
>  delete mode 100644 Documentation/devicetree/bindings/media/i2c/imx274.txt
>  delete mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
>  create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml

-- 
Regards,

Laurent Pinchart

Re: [PATCH v4 0/3] dt-bindings: media: i2c: Convert 3 sensor bindings

[Jacopo Mondi]

Hi Laurent,

On Fri, Sep 04, 2020 at 12:14:20AM +0300, Laurent Pinchart wrote:
> Hi Jacopo,
>
> On Thu, Sep 03, 2020 at 01:51:40PM +0200, Jacopo Mondi wrote:
> > I know I've sent the previous version first as part of a longer list of patches,
> > later individually, and now grouped together again. Sorry for the fuss, hope
> > it's not too confusing.
> >
> > These three sensor bindings conversions go together as they all happen in a
> > single patch, so I deemed it was easier to just group them.
> >
> > In v4 after finalizing the discussion with Laurent and Rob on how to handle
> > of-graph endpoint, I have dropped them from mt9v111 and imx274. For imx214 as I
> > have endpoint properties to document I have also documented 'endpoint' (not
> > mandatory) and 'remote-endpoint' (mandatory). Hope I got the outcome of the
> > discussion right. For imx214 I also took in Laurent's suggestion on how to
> > document the 'data-lanes' supported values.
>
> I think you can drop remote-endpoint, it will be defined in
> of-graph.yaml. Apart from that, it sounds good to me.
>

Will I ever get this right ? Should we record the policy to document
endpoints until we don't have an of-graph.yaml to avoid other to have
go through 5 iterations to do it right ?

On this patch:
I owe an updated to the imx274 patch but I'm waiting for this
discussion to get somewhere (you're welcome to step-in :)
https://patchwork.linuxtv.org/project/linux-media/patch/1599012278-10203-3-git-send-email-skomatineni@nvidia.com/

Then I'll re-send a v5

> > Individual maintainers cc-ed per-patch.
> >
> > Jacopo Mondi (3):
> >   dt-bindings: media: mt9v111: Convert to json-schema
> >   dt-bindings: media: imx274: Convert to json-schema
> >   dt-bindings: media: imx214: Convert to json-schema
> >
> >  .../bindings/media/i2c/aptina,mt9v111.txt     |  46 ------
> >  .../bindings/media/i2c/aptina,mt9v111.yaml    |  75 ++++++++++
> >  .../devicetree/bindings/media/i2c/imx274.txt  |  38 -----
> >  .../bindings/media/i2c/sony,imx214.txt        |  53 -------
> >  .../bindings/media/i2c/sony,imx214.yaml       | 137 ++++++++++++++++++
> >  .../bindings/media/i2c/sony,imx274.yaml       |  59 ++++++++
> >  MAINTAINERS                                   |   6 +-
> >  7 files changed, 274 insertions(+), 140 deletions(-)
> >  delete mode 100644 Documentation/devicetree/bindings/media/i2c/aptina,mt9v111.txt
> >  create mode 100644 Documentation/devicetree/bindings/media/i2c/aptina,mt9v111.yaml
> >  delete mode 100644 Documentation/devicetree/bindings/media/i2c/imx274.txt
> >  delete mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
> >  create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
> >  create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
>
> --
> Regards,
>
> Laurent Pinchart

Re: [PATCH v4 2/3] dt-bindings: media: imx274: Convert to json-schema

[Sakari Ailus]

Hi Jacopo,

On Thu, Sep 03, 2020 at 02:48:31PM +0200, Jacopo Mondi wrote:
> Hi Sakari
> 
> On Thu, Sep 03, 2020 at 03:23:31PM +0300, Sakari Ailus wrote:
> > Hi Jacopo,
> >
> > Thanks for the update.
> >
> > On Thu, Sep 03, 2020 at 01:51:42PM +0200, Jacopo Mondi wrote:
> > > Convert the imx274 bindings document to json-schema and update
> > > the MAINTAINERS file accordingly.
> > >
> > > Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
> > > Signed-off-by: Jacopo Mondi <jacopo+renesas@jmondi.org>
> > > ---
> > >  .../devicetree/bindings/media/i2c/imx274.txt  | 38 ------------
> > >  .../bindings/media/i2c/sony,imx274.yaml       | 59 +++++++++++++++++++
> > >  MAINTAINERS                                   |  2 +-
> > >  3 files changed, 60 insertions(+), 39 deletions(-)
> > >  delete mode 100644 Documentation/devicetree/bindings/media/i2c/imx274.txt
> > >  create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> > >
> > > diff --git a/Documentation/devicetree/bindings/media/i2c/imx274.txt b/Documentation/devicetree/bindings/media/i2c/imx274.txt
> > > deleted file mode 100644
> > > index 0727079d2410..000000000000
> > > --- a/Documentation/devicetree/bindings/media/i2c/imx274.txt
> > > +++ /dev/null
> > > @@ -1,38 +0,0 @@
> > > -* Sony 1/2.5-Inch 8.51Mp CMOS Digital Image Sensor
> > > -
> > > -The Sony imx274 is a 1/2.5-inch CMOS active pixel digital image sensor with
> > > -an active array size of 3864H x 2202V. It is programmable through I2C
> > > -interface. The I2C address is fixed to 0x1a as per sensor data sheet.
> > > -Image data is sent through MIPI CSI-2, which is configured as 4 lanes
> > > -at 1440 Mbps.
> > > -
> > > -
> > > -Required Properties:
> > > -- compatible: value should be "sony,imx274" for imx274 sensor
> > > -- reg: I2C bus address of the device
> > > -
> > > -Optional Properties:
> > > -- reset-gpios: Sensor reset GPIO
> > > -- clocks: Reference to the input clock.
> > > -- clock-names: Should be "inck".
> > > -- VANA-supply: Sensor 2.8v analog supply.
> > > -- VDIG-supply: Sensor 1.8v digital core supply.
> > > -- VDDL-supply: Sensor digital IO 1.2v supply.
> > > -
> > > -The imx274 device node should contain one 'port' child node with
> > > -an 'endpoint' subnode. For further reading on port node refer to
> > > -Documentation/devicetree/bindings/media/video-interfaces.txt.
> > > -
> > > -Example:
> > > -	sensor@1a {
> > > -		compatible = "sony,imx274";
> > > -		reg = <0x1a>;
> > > -		#address-cells = <1>;
> > > -		#size-cells = <0>;
> > > -		reset-gpios = <&gpio_sensor 0 0>;
> > > -		port {
> > > -			sensor_out: endpoint {
> > > -				remote-endpoint = <&csiss_in>;
> > > -			};
> > > -		};
> > > -	};
> > > diff --git a/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> > > new file mode 100644
> > > index 000000000000..f757ce380cb2
> > > --- /dev/null
> > > +++ b/Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml
> > > @@ -0,0 +1,59 @@
> > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > > +%YAML 1.2
> > > +---
> > > +$id: http://devicetree.org/schemas/media/i2c/sony,imx274.yaml#
> > > +$schema: http://devicetree.org/meta-schemas/core.yaml#
> > > +
> > > +title: Sony 1/2.5-Inch 8.51MP CMOS Digital Image Sensor
> > > +
> > > +maintainers:
> > > +  - Leon Luo <leonl@leopardimaging.com>
> > > +
> > > +description: |
> > > +  The Sony IMX274 is a 1/2.5-inch CMOS active pixel digital image sensor with an
> > > +  active array size of 3864H x 2202V. It is programmable through I2C interface.
> > > +  Image data is sent through MIPI CSI-2, which is configured as 4 lanes at 1440
> > > +  Mbps.
> > > +
> > > +properties:
> > > +  compatible:
> > > +    const: sony,imx274
> > > +
> > > +  reg:
> > > +    const: 0x1a
> > > +
> > > +  reset-gpios:
> > > +    maxItems: 1
> > > +
> > > +  port:
> > > +    type: object
> > > +    description: |
> > > +      Output video port. See ../video-interfaces.txt.
> > > +
> >
> > What happened to the supplies and the clocks?
> >
> 
> AH!
> 
> 74ea3273d24b ("dt-bindings: media: imx274: Add optional input clock and supplies")
> went in a release later than my v2. From there I kep carrying on what
> I had in the yaml file in v3 and v4 without noticing the original
> bindings in textual form had changed in between!

Yes, it was merged via Rob's tree apparently, and now is in media tree,
too. I wasn't quite expecting that.

-- 
Sakari Ailus

Re: [PATCH v4 0/3] dt-bindings: media: i2c: Convert 3 sensor bindings

[Laurent Pinchart]

Hi Jacopo,

On Fri, Sep 04, 2020 at 10:03:02AM +0200, Jacopo Mondi wrote:
> On Fri, Sep 04, 2020 at 12:14:20AM +0300, Laurent Pinchart wrote:
> > On Thu, Sep 03, 2020 at 01:51:40PM +0200, Jacopo Mondi wrote:
> > > I know I've sent the previous version first as part of a longer list of patches,
> > > later individually, and now grouped together again. Sorry for the fuss, hope
> > > it's not too confusing.
> > >
> > > These three sensor bindings conversions go together as they all happen in a
> > > single patch, so I deemed it was easier to just group them.
> > >
> > > In v4 after finalizing the discussion with Laurent and Rob on how to handle
> > > of-graph endpoint, I have dropped them from mt9v111 and imx274. For imx214 as I
> > > have endpoint properties to document I have also documented 'endpoint' (not
> > > mandatory) and 'remote-endpoint' (mandatory). Hope I got the outcome of the
> > > discussion right. For imx214 I also took in Laurent's suggestion on how to
> > > document the 'data-lanes' supported values.
> >
> > I think you can drop remote-endpoint, it will be defined in
> > of-graph.yaml. Apart from that, it sounds good to me.
> 
> Will I ever get this right ? Should we record the policy to document
> endpoints until we don't have an of-graph.yaml to avoid other to have
> go through 5 iterations to do it right ?

I'll give graph.yaml a go :-)

> On this patch:
> I owe an updated to the imx274 patch but I'm waiting for this
> discussion to get somewhere (you're welcome to step-in :)
> https://patchwork.linuxtv.org/project/linux-media/patch/1599012278-10203-3-git-send-email-skomatineni@nvidia.com/
> 
> Then I'll re-send a v5
> 
> > > Individual maintainers cc-ed per-patch.
> > >
> > > Jacopo Mondi (3):
> > >   dt-bindings: media: mt9v111: Convert to json-schema
> > >   dt-bindings: media: imx274: Convert to json-schema
> > >   dt-bindings: media: imx214: Convert to json-schema
> > >
> > >  .../bindings/media/i2c/aptina,mt9v111.txt     |  46 ------
> > >  .../bindings/media/i2c/aptina,mt9v111.yaml    |  75 ++++++++++
> > >  .../devicetree/bindings/media/i2c/imx274.txt  |  38 -----
> > >  .../bindings/media/i2c/sony,imx214.txt        |  53 -------
> > >  .../bindings/media/i2c/sony,imx214.yaml       | 137 ++++++++++++++++++
> > >  .../bindings/media/i2c/sony,imx274.yaml       |  59 ++++++++
> > >  MAINTAINERS                                   |   6 +-
> > >  7 files changed, 274 insertions(+), 140 deletions(-)
> > >  delete mode 100644 Documentation/devicetree/bindings/media/i2c/aptina,mt9v111.txt
> > >  create mode 100644 Documentation/devicetree/bindings/media/i2c/aptina,mt9v111.yaml
> > >  delete mode 100644 Documentation/devicetree/bindings/media/i2c/imx274.txt
> > >  delete mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx214.txt
> > >  create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx214.yaml
> > >  create mode 100644 Documentation/devicetree/bindings/media/i2c/sony,imx274.yaml

-- 
Regards,

Laurent Pinchart