[PATCH 0/3] Enable RZ/G2L OSTM support

[PATCH 0/3] Enable RZ/G2L OSTM support

[Biju Das]

This patch series aims to enable Generic Timer Module (a.k.a OSTM) support
for RZ/G2L SMARC platform.

This patch series is depend upon [1]
[1] https://patchwork.kernel.org/project/linux-renesas-soc/list/?series=577857

Biju Das (3):
  drivers: soc: renesas: Enable RENESAS_OSTM
  arm64: dts: renesas: r9a07g044: Add OSTM nodes
  arm64: dts: renesas: rzg2l-smarc-som: Enable OSTM

 arch/arm64/boot/dts/renesas/r9a07g044.dtsi    | 33 +++++++++++++++++++
 .../boot/dts/renesas/rzg2l-smarc-som.dtsi     |  8 +++++
 drivers/soc/renesas/Kconfig                   |  1 +
 3 files changed, 42 insertions(+)

-- 
2.17.1

[PATCH 1/3] drivers: soc: renesas: Enable RENESAS_OSTM

[Biju Das]

Enable General Timer Module (a.k.a OSTM) driver support for Renesas
RZ/G2L based platforms.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 drivers/soc/renesas/Kconfig | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/soc/renesas/Kconfig b/drivers/soc/renesas/Kconfig
index ce16ef5c939c..6b7cba495bc3 100644
--- a/drivers/soc/renesas/Kconfig
+++ b/drivers/soc/renesas/Kconfig
@@ -286,6 +286,7 @@ config ARCH_R8A774B1
 
 config ARCH_R9A07G044
 	bool "ARM64 Platform support for RZ/G2L"
+	select RENESAS_OSTM
 	help
 	  This enables support for the Renesas RZ/G2L SoC variants.
 
-- 
2.17.1

[PATCH 2/3] arm64: dts: renesas: r9a07g044: Add OSTM nodes

[Biju Das]

Add OSTM{0,1,2} nodes to RZ/G2L SoC DTSI.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/r9a07g044.dtsi | 33 ++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
index 485ef5f0fea1..ba149fd41cb6 100644
--- a/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
+++ b/arch/arm64/boot/dts/renesas/r9a07g044.dtsi
@@ -641,6 +641,39 @@
 			power-domains = <&cpg>;
 			status = "disabled";
 		};
+
+		ostm0: timer@12801000 {
+			compatible = "renesas,r9a07g044-ostm",
+				     "renesas,rzg2l-ostm";
+			reg = <0x0 0x12801000 0x0 0x400>;
+			interrupts = <GIC_SPI 46 IRQ_TYPE_EDGE_RISING>;
+			clocks = <&cpg CPG_MOD R9A07G044_OSTM0_PCLK>;
+			resets = <&cpg R9A07G044_OSTM0_PRESETZ>;
+			power-domains = <&cpg>;
+			status = "disabled";
+		};
+
+		ostm1: timer@12801400 {
+			compatible = "renesas,r9a07g044-ostm",
+				     "renesas,rzg2l-ostm";
+			reg = <0x0 0x12801400 0x0 0x400>;
+			interrupts = <GIC_SPI 47 IRQ_TYPE_EDGE_RISING>;
+			clocks = <&cpg CPG_MOD R9A07G044_OSTM1_PCLK>;
+			resets = <&cpg R9A07G044_OSTM1_PRESETZ>;
+			power-domains = <&cpg>;
+			status = "disabled";
+		};
+
+		ostm2: timer@12801800 {
+			compatible = "renesas,r9a07g044-ostm",
+				     "renesas,rzg2l-ostm";
+			reg = <0x0 0x12801800 0x0 0x400>;
+			interrupts = <GIC_SPI 48 IRQ_TYPE_EDGE_RISING>;
+			clocks = <&cpg CPG_MOD R9A07G044_OSTM2_PCLK>;
+			resets = <&cpg R9A07G044_OSTM2_PRESETZ>;
+			power-domains = <&cpg>;
+			status = "disabled";
+		};
 	};
 
 	timer {
-- 
2.17.1

[PATCH 3/3] arm64: dts: renesas: rzg2l-smarc-som: Enable OSTM

[Biju Das]

Enable OSTM{1, 2} interfaces on RZ/G2L SMARC EVK.
OSTM0 is reserved for TF-A.

Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
---
 arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi | 8 ++++++++
 1 file changed, 8 insertions(+)

diff --git a/arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi b/arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi
index 7e84a29dddfa..3bea97f16557 100644
--- a/arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi
+++ b/arch/arm64/boot/dts/renesas/rzg2l-smarc-som.dtsi
@@ -130,6 +130,14 @@
 	clock-frequency = <24000000>;
 };
 
+&ostm1 {
+	status = "okay";
+};
+
+&ostm2 {
+	status = "okay";
+};
+
 &pinctrl {
 	adc_pins: adc {
 		pinmux = <RZG2L_PORT_PINMUX(9, 0, 2)>; /* ADC_TRG */
-- 
2.17.1

Re: [PATCH 1/3] drivers: soc: renesas: Enable RENESAS_OSTM

[Geert Uytterhoeven]

Hi Biju,

On Wed, Nov 10, 2021 at 9:42 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Enable General Timer Module (a.k.a OSTM) driver support for Renesas
> RZ/G2L based platforms.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Thanks for your patch!

> --- a/drivers/soc/renesas/Kconfig
> +++ b/drivers/soc/renesas/Kconfig
> @@ -286,6 +286,7 @@ config ARCH_R8A774B1
>
>  config ARCH_R9A07G044
>         bool "ARM64 Platform support for RZ/G2L"
> +       select RENESAS_OSTM
>         help
>           This enables support for the Renesas RZ/G2L SoC variants.

As RZ/G2L uses the ARM Architected Timer as system timer, enabling
the OSTM is not mandatory.  Perhaps the RENESAS_OSTM symbol should
be made visible instead, so the user can enable it when wanted?

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

RE: [PATCH 1/3] drivers: soc: renesas: Enable RENESAS_OSTM

[Biju Das]

Hi Geert,

Thanks for the feedback.

> Subject: Re: [PATCH 1/3] drivers: soc: renesas: Enable RENESAS_OSTM
> 
> Hi Biju,
> 
> On Wed, Nov 10, 2021 at 9:42 AM Biju Das <biju.das.jz@bp.renesas.com>
> wrote:
> > Enable General Timer Module (a.k.a OSTM) driver support for Renesas
> > RZ/G2L based platforms.
> >
> > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> 
> Thanks for your patch!
> 
> > --- a/drivers/soc/renesas/Kconfig
> > +++ b/drivers/soc/renesas/Kconfig
> > @@ -286,6 +286,7 @@ config ARCH_R8A774B1
> >
> >  config ARCH_R9A07G044
> >         bool "ARM64 Platform support for RZ/G2L"
> > +       select RENESAS_OSTM
> >         help
> >           This enables support for the Renesas RZ/G2L SoC variants.
> 
> As RZ/G2L uses the ARM Architected Timer as system timer, enabling the
> OSTM is not mandatory.  Perhaps the RENESAS_OSTM symbol should be made
> visible instead, so the user can enable it when wanted?

I will do the below change to make RENESAS_OSTM symbol visible.
Is it ok?

config RENESAS_OSTM
-       bool "Renesas OSTM timer driver" if COMPILE_TEST
+       bool "Renesas OSTM timer driver"
+       depends on ARCH_RENESAS || COMPILE_TEST


Regards,
Biju

> Gr{oetje,eeting}s,
> 
>                         Geert
> 
> --
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-
> m68k.org
> 
> In personal conversations with technical people, I call myself a hacker.
> But when I'm talking to journalists I just say "programmer" or something
> like that.
>                                 -- Linus Torvalds

Re: [PATCH 1/3] drivers: soc: renesas: Enable RENESAS_OSTM

[Geert Uytterhoeven]

Hi Biju,

On Fri, Nov 12, 2021 at 4:32 PM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> > Subject: Re: [PATCH 1/3] drivers: soc: renesas: Enable RENESAS_OSTM
> > On Wed, Nov 10, 2021 at 9:42 AM Biju Das <biju.das.jz@bp.renesas.com>
> > wrote:
> > > Enable General Timer Module (a.k.a OSTM) driver support for Renesas
> > > RZ/G2L based platforms.
> > >
> > > Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> > > Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>
> >
> > Thanks for your patch!
> >
> > > --- a/drivers/soc/renesas/Kconfig
> > > +++ b/drivers/soc/renesas/Kconfig
> > > @@ -286,6 +286,7 @@ config ARCH_R8A774B1
> > >
> > >  config ARCH_R9A07G044
> > >         bool "ARM64 Platform support for RZ/G2L"
> > > +       select RENESAS_OSTM
> > >         help
> > >           This enables support for the Renesas RZ/G2L SoC variants.
> >
> > As RZ/G2L uses the ARM Architected Timer as system timer, enabling the
> > OSTM is not mandatory.  Perhaps the RENESAS_OSTM symbol should be made
> > visible instead, so the user can enable it when wanted?
>
> I will do the below change to make RENESAS_OSTM symbol visible.
> Is it ok?
>
> config RENESAS_OSTM
> -       bool "Renesas OSTM timer driver" if COMPILE_TEST
> +       bool "Renesas OSTM timer driver"
> +       depends on ARCH_RENESAS || COMPILE_TEST

LGTM.

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds

Re: [PATCH 3/3] arm64: dts: renesas: rzg2l-smarc-som: Enable OSTM

[Geert Uytterhoeven]

On Wed, Nov 10, 2021 at 9:42 AM Biju Das <biju.das.jz@bp.renesas.com> wrote:
> Enable OSTM{1, 2} interfaces on RZ/G2L SMARC EVK.
> OSTM0 is reserved for TF-A.
>
> Signed-off-by: Biju Das <biju.das.jz@bp.renesas.com>
> Reviewed-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@bp.renesas.com>

Reviewed-by: Geert Uytterhoeven <geert+renesas@glider.be>

Gr{oetje,eeting}s,

                        Geert

--
Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert@linux-m68k.org

In personal conversations with technical people, I call myself a hacker. But
when I'm talking to journalists I just say "programmer" or something like that.
                                -- Linus Torvalds